Commit graph

27982 commits

Author SHA1 Message Date
rc-swag
9eadbd6425
Merge pull request #6211 from keymanapp/fix/core/6204/capslock-key-state-ignored
fix(common/core/desktop): Add num and scroll lock mask to VKeyToChar
2022-02-24 17:46:57 +10:00
Marc Durdin
bf2270aa69 chore(web): add smp tests for text selection 2022-02-24 15:59:16 +11:00
Marc Durdin
6ba75c54f5 chore(web): disable text selection tests on mobile 2022-02-24 14:14:15 +11:00
Darcy Wong
f2ee3e6275
Merge pull request #6226 from keymanapp/chore/fv/keyboards-csv-languages
chore(oem/fv): Add keyboard version and languages
2022-02-24 07:59:11 +07:00
Marc Durdin
b58ce45ef7 fix(web): add Input text selection tests 2022-02-24 11:29:34 +11:00
Marc Durdin
9b84af8a2f fix(web): add unit tests for selection
This adds a set of unit tests for the TextArea element, initially, to
verify that selection and context are working as expected.
2022-02-24 11:25:21 +11:00
Marc Durdin
862c1f2733
Merge pull request #6262 from keymanapp/chore/codeowners
chore(common): Add CODEOWNERS file
2022-02-24 08:20:13 +11:00
Marc Durdin
a265876ab2
Merge pull request #6246 from srl295/srl295/onboard
feat(common): echo in macos.sh setup script
2022-02-24 08:19:53 +11:00
Eberhard Beilharz
e47ff34587
chore(linux): Improve message when updating to a newer version
When trying to install a keyboard with `km-package-install` and
the same version was already installed or a newer version was
available and would be installed we now output a simple message
instead of an error.
2022-02-23 17:03:00 +01:00
Marc Durdin
2bfe63db2f fix(ios): properly handle selection
Relates to #5853

This deals with deleting the selection with the new interface for
KeymanWeb. It also ensures that the selection is always correctly sent
to KeymanWeb.
2022-02-23 19:46:56 +11:00
Marc Durdin
5c687559fe chore(ios): separate ios-host.js
This is part of the fix chain for #5853. Split ios-host.js out from
keyboard.html in order to make it easier to debug and mock. No changes
to the content of the sscript, just moving it here.
2022-02-23 15:48:47 +11:00
Marc Durdin
9ba4b9645c fix(android): further selection tweaks 2022-02-23 15:16:23 +11:00
Marc Durdin
c389ad0df8 fix(android): selection on Android
Part of #5853.

Building on the fixes in KeymanWeb, we do similar patches for Android.
2022-02-23 15:16:21 +11:00
Marc Durdin
4d37fd0a5b chore(android): separate android-host.js
This is part of the fix chain for #5853. Split android-host.js out from
keyboard.html in order to make it easier to debug and mock. No changes
to the content of the script, just moving it here.
2022-02-23 15:15:22 +11:00
Marc Durdin
003665b6df chore(web): disable legacy edge testing
Legacy edge struggles with selection direction. We
no longer support it anyway, so disable testing.
2022-02-23 15:13:10 +11:00
Marc Durdin
b05fda1c6a fix(web): selection direction and tests
Selection direction was not maintained in mutations, which could have
unexpected consequences. Added support for selection direction to input
and textarea.

The functions `getTextBeforeCaret()` and `getTextAfterCaret()` are named
somewhat incorrectly, as they actually get the text before and after the
active selection (and a collapsed zero-length selection is equivalent to
the caret). It would be worth renaming these in a future refactor.

This PR fixes the unit tests so that caret position is tested correctly
with an active selection -- the caret can be at either the start or the
end of the selection, corresponding with the direction in which the user
originally selected the text. It also fixes the assumptions around the
above named functions for `input` and `textarea` types.

Note that selection interactions are still buggy with prediction
selections; these bugs were present in 15.0.118-alpha and I will tackle
them in an upcoming commit.
2022-02-23 15:13:07 +11:00
Marc Durdin
4bcfe37432 chore: add khmer_angkor to web test pages 2022-02-23 15:13:02 +11:00
Marc Durdin
cacbbee5cc fix(web): properly handle selection
Relates to #5853 and others.

Selection management was not working properly with the various
OutputTargets:

1. When there is a non-empty selection, rules have no context -- it's
   like new text.
2. Backspace over a selection deletes just the selection.
3. Typing a character replaces the selection, of course, and collapses
   the caret to the end of the new text.
4. `hasSelection` is a very strange name for `OutputTarget` descendants.
   It doesn't mean "has an active selection" but rather, kinda means
   "supports selection internally".
5. Added `isSelectionEmpty` which is used for some of the new selection
   rules above.

Note that the `touchAlias` OutputTarget class does not currently support
selection. I hope we can deprecate `touchAlias` with the use of
`inputMode` (#3030) in the future, rather than adding support for
selection.
2022-02-23 15:12:58 +11:00
Marc Durdin
addcad9f76 fix(web): further selection tweaks to mocks 2022-02-23 15:12:23 +11:00
Marc Durdin
6315d61ad9 chore(web): note chrome mobile emulation req
For android-harness, it must run in Chrome mobile emulation.
2022-02-23 08:30:59 +11:00
Eberhard Beilharz
96ae4387ef
fix(linux): Properly compare versions in km-package-install
This change will fix a bug with comparing version numbers with more
than two sections (e.g. '1.2.3').

Fixes #6182.
2022-02-22 20:03:49 +01:00
Marc Durdin
ac2cc93f2a fix(web): add readonly mode for rule behavior finalization
Relates to #5853.

Two things happened here:

1. Construction of Mocks made an assumption that the selection should
   always be deleted (outputTarget.ts:363). However, for NewContext and
   PostKeystroke processes, we don't want to change anything.

2. Even if nothing is changed, the transcription would emit what is
   in theory a no-op ruleTransform (insert="", deleteLeft=0,
   deleteRight=0). But apps would treat this as deleting the selection.

This fix goes a little broader than I would have preferred, but adds a
readonly mode to the transcription and mock model, so that we can
control explicitly when changes are applied to the text store.
2022-02-22 10:42:20 +11:00
Marc Durdin
6cd0f5d49a chore: add web_context_tests keyboard 2022-02-22 10:41:42 +11:00
Marc Durdin
c1c6c8ac84 feat(android): Android web-based test harness
This small harness simulates the Android app. I used it to try and
dig deeper into the interactions with selected text in #5853.

It is very rough, but with some extra effort we could use this
relatively easily for some low-level testing of KeymanWeb embedded
integration.
2022-02-22 10:38:20 +11:00
Keyman Server
a49261d8c0
Merge pull request #6271 from keymanapp/auto/version-master-15.0.202
auto: increment master version to 15.0.202
2022-02-22 05:03:02 +11:00
Keyman Build Agent
de8a1fe220 auto: increment master version to 15.0.202 2022-02-21 13:02:21 -05:00
Eberhard Beilharz
f22dfe608b
Merge pull request #6241 from keymanapp/fix/linux/6240-man
fix(linux): Fix stray `[-vv]` in man pages
2022-02-21 15:46:20 +07:00
Marc Durdin
757b6a3e09
Merge pull request #6259 from keymanapp/fix/developer/6209-npm-publish-alpha-to-stable
fix(developer): npm publish with correct tier
2022-02-21 06:25:02 +07:00
Keyman Server
5399d9c151
Merge pull request #6266 from keymanapp/auto/version-master-15.0.201
auto: increment master version to 15.0.201
2022-02-21 05:03:27 +11:00
Keyman Build Agent
149fba62b6 auto: increment master version to 15.0.201 2022-02-20 13:02:45 -05:00
Darcy Wong
d62ea401a8
Merge pull request #6263 from keymanapp/chore/common/crowdin-fr-2
chore(common): Update French strings
2022-02-20 05:34:25 +07:00
Keyman Server
f4212c8bfe
Merge pull request #6264 from keymanapp/auto/version-master-15.0.200
auto: increment master version to 15.0.200
2022-02-19 05:13:54 +11:00
Keyman Build Agent
10e7e4a4c4 auto: increment master version to 15.0.200 2022-02-18 13:13:14 -05:00
Eberhard Beilharz
31170e8f94 fix(linux): Fix stray [-vv] in man pages
Additionally, don't print the date in the footer. This often overlaps
with the program name and version.

Also print usage in addition to error if wrong arguments are given.

Fixes #6240.
2022-02-18 14:15:17 +07:00
Darcy Wong
3237a4c6ae chore(common): Update French strings 2022-02-18 10:06:33 +07:00
Marc Durdin
35dc7b89bb
Merge pull request #6248 from keymanapp/fix/web/non-integer-cached-osk-size
fix(web): Non-integer OSK sizes
2022-02-18 11:17:38 +11:00
Marc Durdin
5e2f006da9 chore: CODEOWNERS file 2022-02-18 06:56:04 +07:00
Steven R. Loomis
bdc6e803dc feat(common/resources): echo in macos.sh setup script
- turn on echoing when we start doing stuff
- it is not too noisy, and tells the user what is really happening
- correct ~/.bashrc fix
- also, note the script name which added certain lines to ~/.bashrc

Fixes: #6244
2022-02-16 17:26:04 -06:00
Keyman Server
49d0b18dbe
Merge pull request #6260 from keymanapp/auto/version-master-15.0.199
auto: increment master version to 15.0.199
2022-02-14 05:03:38 +11:00
Keyman Build Agent
93c19d9adb auto: increment master version to 15.0.199 2022-02-13 13:02:58 -05:00
Marc Durdin
3a3736abaa fix(developer): npm publish with correct tier
Fixes #6209.

Regression introduced in #6073. Cleanup of tier information in these
build scripts accidentally also deleted the setup of npm_dist_tag
variable.
2022-02-13 14:18:42 +07:00
Darcy Wong
4af57b2c35
Merge pull request #6234 from keymanapp/chore/android/globe-whatsnew
chore(android/app): Clarify help on switching keyboards
2022-02-13 08:29:43 +07:00
Marc Durdin
ee14b17b12
Merge pull request #6145 from keymanapp/fix/developer/5992-package-fileversion-from-keyboard-fileversion
fix(developer): compile package fileVersion from keyboard FileVersion
2022-02-13 10:48:25 +11:00
Keyman Server
39b095943f
Merge pull request #6251 from keymanapp/auto/version-master-15.0.198
auto: increment master version to 15.0.198
2022-02-13 05:04:08 +11:00
Keyman Build Agent
a1e1ab86c0 auto: increment master version to 15.0.198 2022-02-12 13:03:29 -05:00
Marc Durdin
eb21375553
Merge pull request #6230 from keymanapp/fix/developer/support-km_kbp_it_capslock
fix(developer): support KM_KBP_IT_CAPSLOCK
2022-02-12 23:18:24 +11:00
Marc Durdin
5f81a5625f
Merge pull request #6225 from keymanapp/fix/windows/cherry-pick/6221-system-profile-wow64-patch
fix(windows): create Keyman/Diag folder in redirected profile 🍒
2022-02-12 23:17:43 +11:00
Marc Durdin
da5d00c284 fix(web): Non-integer OSK sizes
If the OSK had a non-integer width or height stored in the OSK cookie,
then the width and height would be parsed incorrectly and the OSK would
fail to be sized correctly on first load; this also caused a script
error and made the OSK impossible to interact with.
2022-02-12 19:06:12 +07:00
Marc Durdin
96277a46a2
Merge pull request #6236 from keymanapp/dependabot/npm_and_yarn/web/testing/regression-tests/karma-6.3.14
chore(deps-dev): bump karma from 6.3.4 to 6.3.14 in /web/testing/regression-tests
2022-02-12 20:41:47 +11:00
Marc Durdin
9e11341d28
Merge pull request #6247 from keymanapp/dependabot/npm_and_yarn/web/testing/regression-tests/follow-redirects-1.14.8
chore(deps): bump follow-redirects from 1.7.0 to 1.14.8 in /web/testing/regression-tests
2022-02-12 20:38:21 +11:00