erabo/spiegel_podman
1
0
Fork 0
mirror of https://github.com/podman-container-tools/podman.git synced 2026-08-13 04:09:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
spiegel_podman/pkg/machine
History
Christophe Fergeau 90f69891d7 applehv: Remove unneeded cmd.ExtraFiles assignment 
`applehv.Start()` has this line of code:
```
cmd.ExtraFiles = []*os.File{ioEater, ioEater, ioEater}
```
whose purpose is not clear.

The intent may have been to redirect stdin/stdout/stderr to /dev/null in
the child process.
This should be done by setting cmd.Stdin/cmd.Stdout/cmd/Stderr to nil,
which is the case by default.

The way it's done could also cause issues as
`Vfkit.VirtualMachine.Cmd()` sometimes adds files it needs to keep open
to `ExtraFiles`, so at the very least this should be an `append()`

This commit removes this code.

[NO NEW TESTS NEEDED]

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2024-01-16 17:06:10 +01:00
..
applehv applehv: Remove unneeded cmd.ExtraFiles assignment 2024-01-16 17:06:10 +01:00
compression Refactor key machine objects 2023-11-07 08:30:44 -06:00
define Use single persistent ssh key for all machines 2024-01-04 23:47:49 -05:00
e2e Assign separate ports for each appleHV machine 2024-01-11 12:19:04 -05:00
hyperv Merge pull request #20878 from ashley-cui/winapiforwarding 2024-01-08 20:07:23 +00:00
ignition Merge pull request #21161 from cgwalters/machine-autologin-console 2024-01-13 03:45:38 +00:00
ocipull podman machine image from oci updates 2023-11-22 13:21:24 -06:00
os chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
provider Create pkg/machine/ignition package 2024-01-04 08:51:35 -05:00
qemu Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
sockets Podman 5 machine config file - Step 1 2023-12-11 16:26:15 -06:00
vmconfigs Podman 5 machine config file - Step 1 2023-12-11 16:26:15 -06:00
wsl Merge pull request #20878 from ashley-cui/winapiforwarding 2024-01-08 20:07:23 +00:00
cleanup.go Machine: Teardown on init failure 2023-10-12 09:26:06 -04:00
config.go machine: use GlobalDataDir helper 2024-01-05 10:29:36 -05:00
config_test.go machine: use GlobalDataDir helper 2024-01-05 10:29:36 -05:00
connection.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
errors.go Various updates for hyperv and machine e2e tests 2023-09-21 08:52:02 -05:00
fcos.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
fcos_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
fedora_unix.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
fedora_windows.go WSL refactoring 2023-01-23 10:48:32 -06:00
gvproxy.go Refactor key machine objects 2023-11-07 08:30:44 -06:00
keys.go Use single persistent ssh key for all machines 2024-01-04 23:47:49 -05:00
machine_common.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
machine_unix.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
machine_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
machine_windows.go Add API forwarding support for HyperV 2024-01-05 11:45:28 -05:00
ports.go Implement automatic port reassignment on Windows 2023-08-21 07:23:31 -05:00
ports_unix.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
ports_windows.go Implement automatic port reassignment on Windows 2023-08-21 07:23:31 -05:00
pull.go Create pkg/machine/ignition package 2024-01-04 08:51:35 -05:00
ssh.go fix(ssh): start machine failed to start with exit status 255 2023-06-16 19:39:38 +08:00
update.go Create pkg/machine/ignition package 2024-01-04 08:51:35 -05:00
volumes.go Podman 5 machine config file - Step 1 2023-12-11 16:26:15 -06:00