erabo/spiegel_podman
1
0
Fork 0
mirror of https://github.com/podman-container-tools/podman.git synced 2026-08-13 12:19:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
spiegel_podman/pkg
History
Christophe Fergeau 90f69891d7 applehv: Remove unneeded cmd.ExtraFiles assignment 
`applehv.Start()` has this line of code:
```
cmd.ExtraFiles = []*os.File{ioEater, ioEater, ioEater}
```
whose purpose is not clear.

The intent may have been to redirect stdin/stdout/stderr to /dev/null in
the child process.
This should be done by setting cmd.Stdin/cmd.Stdout/cmd/Stderr to nil,
which is the case by default.

The way it's done could also cause issues as
`Vfkit.VirtualMachine.Cmd()` sometimes adds files it needs to keep open
to `ExtraFiles`, so at the very least this should be an `append()`

This commit removes this code.

[NO NEW TESTS NEEDED]

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2024-01-16 17:06:10 +01:00
..
annotations Remove ReservedAnnotations from kube generate specification 2023-01-18 08:46:24 -05:00
api Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
auth Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
autoupdate chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
bindings Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
channel bump golangci-lint to v1.50.1 2022-12-15 13:39:56 +01:00
checkpoint chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
copy Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
criu chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
ctime chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
domain Merge pull request #21069 from umohnani8/new-farmbuild-2 2024-01-15 18:41:29 +00:00
emulation chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
env Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
errorhandling Fix typos 2023-02-11 18:23:24 +01:00
farm farm build: push built images to registry 2024-01-15 11:31:17 -05:00
fileserver chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
inspect pkg/inspect: remove unused ImageResult type 2022-05-24 16:07:39 +02:00
k8s.io chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
lookup source code comments and docs: fix typos, language, Markdown layout 2023-05-22 07:52:16 +02:00
machine applehv: Remove unneeded cmd.ExtraFiles assignment 2024-01-16 17:06:10 +01:00
namespaces Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
parallel chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
ps chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
rctl Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
rootless chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
seccomp pkg: switch to golang native error wrapping 2022-07-08 08:54:47 +02:00
selinux Fix SELinux functions names to not be repetitive 2020-04-23 15:57:34 -04:00
signal chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
specgen Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
specgenutil Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
specgenutilexternal Quadlet container mount - support non key=val options 2023-09-27 16:20:00 +03:00
strongunits introduce pkg/strongunits 2023-09-20 11:19:41 -05:00
systemd Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
terminal chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
timetype Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
trust Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
util Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00