7979 commits

Author	SHA1	Message	Date
Paul Holzinger	53a9bcbe13	run golangci-lint --fix ... In order to fix the new formatting issues reported. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 16:30:10 +02:00
Paul Holzinger	afe45cccb6	Merge pull request #29714 from Luap99/go-1.26 ... Update to Go 1.26	2026-09-04 15:48:09 +02:00
Paul Holzinger	8b216d16c4	Merge pull request #29656 from hkwi/fix-compat-stats-http-status ... api: reflect container stats errors in HTTP status codes	2026-09-04 15:17:42 +02:00
Paul Holzinger	258001db67	Merge pull request #29496 from simek-m/RUN-3319-info-runtimes-status ... compat: Add status for runtimes to GET /info	2026-09-04 13:54:34 +02:00
Hiroaki KAWAI	d56f52c8a7	api: reflect container stats errors in HTTP status codes ... Existing KillContainer handling uses HTTP status code 409 when the request cannot be performed because of the current container state. HTTP status code 404 is also used when the target container does not exist. In contrast, errors from the stats handler are not reflected in the HTTP status code. The HTTP status code is always 200, and the errors are recorded only as generic errors in the server log. To maintain compatibility with both streaming enabled and disabled, this change treats obtaining at least one complete unit of response content as the response contract. It then keeps the response content consistent with the HTTP status code. Signed-off-by: Hiroaki KAWAI <hiroaki.kawai@gmail.com>	2026-09-04 20:42:55 +09:00
Paul Holzinger	6c6eac3a5c	run modernize -fix ./... ... Since I use go 1.26 the go fix does not have all the rules built in, there are newer ones in modernize so run the explicitly to fix more code for go 1.26. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 11:53:04 +02:00
Paul Holzinger	eb96a9d5b8	run go fix ./... ... Plus manually deleting the left over inline functions because go fix doesn't do that even though they are private functions. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 11:53:04 +02:00
Jan Rodák	ec30171911	Merge pull request #29660 from simek-m/RUN-3316-compat-until-filter ... compat: Document and test GET /images/json until filter	2026-09-04 11:45:24 +02:00
Marek Simek	81ec75c4ec	compat: Add status for runtimes to GET /info ... Docker API v1.44 now includes status properties in Runtimes for the GET /info endpoint. Read output of {oci_runtime_cmd} features command lazily and expose the JSON output as-is (with removed new lines and whitespace) as the status field in GET /info for v1.44+. Add status to libpod GET /info in ociRuntime.features and `podman info` (shared). Add API tests for both endpoints. Fixes: https://redhat.atlassian.net/browse/RUN-3319 Signed-off-by: Marek Simek <msimek@redhat.com>	2026-09-04 11:37:47 +02:00
Paul Holzinger	f6487b7546	Merge pull request #29669 from CodeWithAK28/manifest-annotate-subject-remote ... pkg/bindings, pkg/api: send the manifest index subject to the server	2026-09-03 18:21:01 +02:00
Danish Prakash	f9d0a4dff5	Merge pull request #29694 from Luap99/pasta-flake ... Revert "test/system: skip one new pasta flake"	2026-09-02 12:58:03 +05:30
Anisha Khairnar	b760306614	pkg/bindings, pkg/api: send the manifest index subject to the server ... Two commands can set a subject on a manifest list, podman manifest annotate --index --subject and podman manifest add --artifact-subject. Both work locally, but they do nothing at all when podman runs with --remote. The value never leaves the client. Before sending the request the remote client copies everything into manifests.ModifyOptions and manifests.AddArtifactOptions, and neither struct had a field to hold the subject, so it was quietly thrown away. The server had a second problem of its own, ManifestModify rebuilds ManifestAddArtifactOptions by hand and left out the embedded ManifestAnnotateOptions, so --os, --arch and --annotation were being dropped there as well. Add the missing field to both structs, fill it in from the tunnel ImageEngine, and let the handler pass the annotate options along. Also add two system tests that run both flags for real so the remote path stays covered. Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-09-02 11:57:43 +05:30
Paul Holzinger	c2a7d573e0	Revert "test/system: skip one new pasta flake" ... This reverts commit 0dbe00d272. The linked bug[1] has been fixed for a while now, remove the skip to test the port forwarding range properly again with pasta. The CI images all have a new enough pasta. [1] https://bugs.passt.top/show_bug.cgi?id=202 Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-01 19:19:23 +02:00
Ashley Cui	af579ec299	Add --platform to podman push ... When pushing a manifest list, --platform=OS[/Arch[/Variant]] selects and pushes a single platform-specific manifest instead of the entire list. Also, update compat POST /images/{name}/push to support the platform param (Compat v1.46) Signed-off-by: Ashley Cui <acui@redhat.com>	2026-09-01 11:30:48 -04:00
Jan Rodák	0b2d7729c5	Merge pull request #29654 from Atishyy27/fix/subpath-equals-truncation ... fix(libpod): keep '=' in a volume subpath	2026-09-01 13:55:17 +02:00
Danish Prakash	7efd442600	Merge pull request #29690 from ricardobranco777/410_selinux ... test/system: Update test to handle new error message from runc 1.5.0	2026-09-01 16:38:13 +05:30
Paul Holzinger	9242ecc42f	Merge pull request #29673 from Xiaowen-Yang/codex/fix-29664-attach-exited ... api: avoid reinitializing exited containers on logs-only attach	2026-09-01 12:36:00 +02:00
Ricardo Branco	7e8002dd08	test/system: Update test to handle new error message from runc 1.5.0 ... runc 1.5.0 switched to a safe procfs API for setting SELinux labels, so reopened handles no longer carry a /proc/self path in error messages, e.g. "write /1/attr/keycreate: invalid argument" instead of "write /proc/self/attr/keycreate: invalid argument". Relax the regex to match on "attr/keycreate" without requiring the proc/self prefix. Signed-off-by: Ricardo Branco <rbranco@suse.de>	2026-09-01 11:01:36 +02:00
Giuseppe Scrivano	58489b82b4	libpod: fix :O overlay volumes in a userns ... When the user owning the storage is not mapped into the container user namespace (e.g. root with --userns=auto), the runtime cannot mount an overlay volume from inside the user namespace. Mount the overlay in podman instead and pass the runtime a bind mount. Closes: https://github.com/podman-container-tools/podman/issues/28758 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>	2026-09-01 09:50:51 +02:00
Xiaowen-Yang	1c8f2963a1	Preserve exited state for logs-only HTTP attach ... Fixes: #29664 Signed-off-by: Xiaowen-Yang <xiaowenyang52@gmail.com>	2026-08-31 20:31:24 +02:00
Marek Simek	d6c2cf29dd	compat: Document and test GET /images/json until filter ... The `until` filter was missing from the documentation. Document it for both GET /libpod/images/json and the compat GET /images/json. Add tests for the until filter exercising both endpoints. Fixes: https://redhat.atlassian.net/browse/RUN-3316 Signed-off-by: Marek Simek <msimek@redhat.com>	2026-08-31 12:11:36 +02:00
Jan Rodák	c30add3f1c	Merge pull request #29667 from CodeWithAK28/remote-push-signing-error ... pkg/domain/infra/tunnel: error when signing a remote push	2026-08-31 11:32:46 +02:00
Anisha Khairnar	ee1d224bad	test/e2e: skip the save signature test on remote ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-29 14:19:26 +05:30
Anisha Khairnar	123b9024d5	pkg/domain/infra/tunnel: error when signing a remote push ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-28 12:17:51 +05:30
Jan Rodák	7a6c0a0504	Merge pull request #28100 from parmisean/parmisean/implement-ssh-session-type ... pkg/bindings: add dial-stdio fallback for SSH connections	2026-08-28 05:02:14 +02:00
Matt Heon	f542424eab	Merge pull request #29603 from gerryd/feature/create-passwd ... Add support for --passwd to the create command	2026-08-27 22:03:01 -04:00
Gerry Demaret	bd8de9f7aa	Add support for --passwd to the create command ... Give create the same --passwd flag as run currently has. Signed-off-by: Gerry Demaret <gerry@x-net.be>	2026-08-27 15:46:30 +02:00
Atishyy27	44f7900e0d	fix(libpod): keep '=' in a volume subpath ... The subpath mount option is parsed with strings.Split(o, "=")[1], so it keeps only the text between the first and second '='. A subpath that contains '=' gets cut short and the container mounts a different directory than the one that was asked for. --mount type=volume,src=v,dst=/mnt,subpath=/opt/a=b/c mounts /opt/a Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>	2026-08-27 18:20:55 +05:30
Jan Rodák	5eab541350	Merge pull request #29651 from vtushar06/fix-bevalidjson ... test/utils: fix BeValidJSON and remove IsJSONOutputValid	2026-08-27 12:47:08 +02:00
Tushar Verma	d153f4750b	test/e2e: remove IsJSONOutputValid ... Asserting a bool against an expected bool says nothing about the output when it fails. BeValidJSON() prints it, and now that the matcher handles a non match properly the negative rows in the info and version table tests can use it too. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Tushar Verma	d685b5a87b	test/utils: BeValidJSON should not error on invalid json ... Match() returned the unmarshal error for input that is simply not json. Gomega treats a non nil error as a failure to evaluate, so it fails the assertion either way and ToNot(BeValidJSON()) fails on exactly the input it is meant to accept: Expect("{not json").ToNot(BeValidJSON()) --> invalid character 'n' looking for beginning of object key string A non match is (false, nil), the error return is for input the matcher cannot evaluate, which is the wrong type case above it. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Sean Prouty	ee681f80e9	pkg/bindings: add dial-stdio fallback for SSH connections ... Fixes: #27814 Signed-off-by: Sean Prouty <parmisean@proton.me>	2026-08-26 09:05:12 -07:00
Matt Heon	a1c4f9c0e6	Merge pull request #29634 from hihry/fix/Overriding ... specgen: ensure keep-id overrides image USER	2026-08-26 11:57:00 -04:00
Tushar Verma	cf4cb4184c	test/e2e: do not use os.Exit for error handling ... os.Exit(1) kills the process without ginkgo getting a chance to report anything, so a failure here shows up as a suite that just stopped with no output. All six sites run inside ginkgo, three in a SynchronizedBefore Suite and a helper and three inside It blocks, so Expect works and prints the error and the location. The os.Exit(m.Run()) in TestMain stays, that one is correct. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 22:50:18 +05:30
Himanshu Ravindra Iwanati	b8f7129a1a	specgen: ensure keep-id overrides image USER ... Fixes: #29600 Signed-off-by: Himanshu Ravindra Iwanati <work.himanshu.r.v@gmail.com>	2026-08-25 22:26:31 +05:30
Paul Holzinger	5474d7daaa	Merge pull request #29640 from vtushar06/remove-line-matching-helpers ... test/e2e: remove line matching helpers	2026-08-25 17:39:12 +02:00
Tushar Verma	9f691c8a65	test/e2e: remove LineInOutputContainsTag ... A bool assert on the parsed repo/tag map says nothing about the actual images output when it fails. Match the line with a regex instead, the failure then prints every line and the pattern. This also removes tagOutputToMap which had no other user. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 19:19:39 +05:30
Jan Rodák	53da1b8f7b	Merge pull request #29528 from vtushar06/fix-apiv2-exit-status ... hack/ci: do not swallow apiv2 failures	2026-08-25 13:21:27 +02:00
Paul Holzinger	88023665ae	Merge pull request #29611 from vtushar06/fix-build-tmpdir-leak ... build: do not leak context tmpdir	2026-08-25 12:44:52 +02:00
Tushar Verma	33d02631b6	test/apiv2: reset the service before wait tests ... The wait and events tests 500 with a dlopen error on the journald reads when they run against the server the previous file left behind. Paul tracked down what puts that server in this state, restarting it here keeps the suite honest until that is fixed. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 12:03:48 +05:30
Tushar Verma	88b173cbde	test/e2e: remove LineInOutputContains ... Both users are plain if conditions, strings.Contains on the output does the same without a helper. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:41:59 +05:30
Tushar Verma	e4699c1b37	test/e2e: remove GrepString ... Matching a bool and then indexing into the returned lines gives no useful output when it fails. Use gomega matchers on the output array instead, they print the array and the expected match on failure. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:40:30 +05:30
Matt Heon	5aba1efe16	Merge pull request #29614 from jiwahn/fix-volume-import-permission ... libpod: adjust permissions for imported volumes	2026-08-24 14:36:13 -04:00
Paul Holzinger	d092919e55	Merge pull request #29631 from vtushar06/fix-healthcheck-inherit-test ... test/apiv2: build healthcheck image as docker	2026-08-24 18:45:37 +02:00
Miloslav Trmač	ca42cbff0a	Merge pull request #29628 from mehrdadbn9/fix/29627-stats-nil-pointer ... fix(api): nil check Memory.Limit before dereference in stats handler	2026-08-24 15:43:09 +02:00
Jan Rodák	37efeff76f	Merge pull request #29622 from mtrmac/dd-1G ... Don't allocate 1 GB of memory to create a file	2026-08-24 14:32:30 +02:00
Tushar Verma	e78fdb7c3c	test/apiv2: build healthcheck image as docker ... The healthcheck inherit tests build their image with the default oci format, which drops HEALTHCHECK. The build only warns about it and the test sends that to /dev/null, so the image has no health config, there is nothing to inherit and all 21 assertions come back null. Fixes: 16a1d3fbe9 ("support healthcheck: {} inherits healthcheck from image") Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-24 15:31:02 +05:30
Mehrdad Biukian Naeini	14506421f9	fix(api): nil check Memory.Limit before dereference in stats handler ... When a container has --memory-reservation set without --memory-limit, resources.Memory is non-nil but resources.Memory.Limit is nil. The compat stats handler dereferences the nil Limit pointer, causing a panic that returns a 500 to the client. Fix: add resources.Memory.Limit != nil guard before the dereference. Regression test added in test/apiv2/19-stats.at. Fixes #29627 Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>	2026-08-23 18:20:37 +04:00
Matt Heon	8efac905d6	Merge pull request #29530 from umar11b/artifact-ls-quiet ... Add --quiet to podman artifact ls	2026-08-21 18:35:20 -04:00
Matt Heon	fbb90e15b0	Merge pull request #29541 from The-indigo/no-heading ... Added implementation for --noheading option for podman farm list	2026-08-21 17:35:21 -04:00