Merge pull request #29654 from Atishyy27/fix/subpath-equals-truncation

fix(libpod): keep '=' in a volume subpath
2026-10-31 10:17:43 +00:00 · 2026-09-01 13:55:17 +02:00 · 2026-09-01 13:55:17 +02:00 · 0b2d7729c5
commit 0b2d7729c5
parent 7efd442600 44f7900e0d
2 changed files with 2 additions and 3 deletions
--- a/libpod/container_internal_common.go
+++ b/libpod/container_internal_common.go
@ -416,8 +416,7 @@ func (c *Container) generateSpec(ctx context.Context) (s *spec.Spec, cleanupFunc
 		m := &g.Config.Mounts[i]
 		var options []string
 		for _, o := range m.Options {
-			if strings.HasPrefix(o, "subpath=") {
-				subpath := strings.Split(o, "=")[1]
+			if subpath, ok := strings.CutPrefix(o, "subpath="); ok {
 				safeMount, err := c.safeMountSubPath(m.Source, subpath)
 				if err != nil {
 					return nil, nil, err
--- a/test/e2e/run_volume_test.go
+++ b/test/e2e/run_volume_test.go
@ -1113,7 +1113,7 @@ RUN chmod 755 /test1 /test2 /test3`, ALPINE)
 		mkvol.WaitWithDefaultTimeout()
 		Expect(mkvol).Should(ExitCleanly())

-		subvol := "/test/test2/"
+		subvol := "/test/a=b/"
 		pathInCtr := "/mnt"
 		pathToCreate := filepath.Join(pathInCtr, subvol)
 		popvol := podmanTest.Podman([]string{"run", "-v", fmt.Sprintf("%s:/mnt", volName), ALPINE, "sh", "-c", fmt.Sprintf("mkdir -p %s; touch %s; touch %s", pathToCreate, filepath.Join(pathToCreate, "foo"), filepath.Join(pathToCreate, "bar"))})