Paul Holzinger
ee7d3c534c
pkg/machine/e2e: combine build context test
...
Instead of creating a fresh machine which is slow reuse an existing
test for this test.
Also fix the test to actually check the file content properly, it was
using the wrong build output. And then just use one cat for both files
to make it a tiny bit faster.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:24:17 +02:00
Paul Holzinger
66a1bee8d5
pkg/machine/e2e: inline one remove test
...
Avoid another init/start cycle by reusing an existing test which has a
VM running already.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:24:17 +02:00
Paul Holzinger
f1f52763cb
pkg/machine/e2e: combine api test cases
...
Only start a machine once, not three times to safe time.
Also include stdout/err as part of the curl command so errors are
visible. And lastly the latest moby client code should support unix
sockets on windows so we can test it there as well.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:45 +02:00
Paul Holzinger
49aec99596
pkg/machine/e2e: inline stop running machine
...
Instead of having to start a new machine again here just drop the test
and do the stop check as part of another test which already has a
machine running.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:45 +02:00
Paul Holzinger
9002dce687
pkg/machine/e2e: use withFakeImage for excessive cpus test
...
The test should fail before booting a real VM so we can use the fake
image which should make the test a few seconds faster.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:45 +02:00
Paul Holzinger
1b6d77299e
pkg/machine/e2e: remove simple init with start
...
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:44 +02:00
Paul Holzinger
ccd3778087
pkg/machine/e2e: remove start simple machine
...
The test starts a machine 3 times taking almost 180 seconds in linux CI.
We have a lot of machine starts elsewhere already so we really do not
need a basic start and for the quiet/noinfo checks we can just add them
to another existing start command.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:44 +02:00
Paul Holzinger
d99f1d5564
pkg/machine/e2e: rename toQemuInspectInfo to toInspectInfo
...
There is nothing qemu specifc about this for a long time. Just drop it
from the name.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:44 +02:00
Paul Holzinger
3ffe582563
pkg/machine/e2e: combine machine set rootful tests
...
Each machine start/stop adds up in CI, combine several related tests to
reduce the machine init/start/stops cycles.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:44 +02:00
Paul Holzinger
d3f30f698e
pkg/machine/e2e: correctly handle set --rootful=false
...
On podman machine set we have three modes, not set (keep user),
--rootful (set user to root), --rootful=false (set to rootless user).
The later could not be passed at all before this.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:44 +02:00
Paul Holzinger
f4df65a859
pkg/machine/e2e: combine two restart machine tests
...
The restart tests are rather slow. On the linux CI 60 seconds for the
stopped case and almost 120 seconds for the restart running case.
Combine both cases into one so we only have to start a machine twice,
not three times and only need to init it once.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-08 12:16:43 +02:00
Paul Holzinger
7d39ce8fe4
Merge pull request #29728 from podman-container-tools/renovate/dawidd6-action-send-mail-19.x
...
ci / int local rootless fedora-prior (push) Blocked by required conditions
ci / sys local rootless fedora-prior (push) Blocked by required conditions
ci / int remote root fedora-prior (push) Blocked by required conditions
ci / sys remote root fedora-prior (push) Blocked by required conditions
ci / int local root fedora-rawhide (push) Blocked by required conditions
ci / sys local root fedora-rawhide (push) Blocked by required conditions
ci / int local rootless fedora-rawhide (push) Blocked by required conditions
ci / sys local rootless fedora-rawhide (push) Blocked by required conditions
ci / int remote root fedora-rawhide (push) Blocked by required conditions
ci / sys remote root fedora-rawhide (push) Blocked by required conditions
ci / apiv2 root fedora-current (push) Blocked by required conditions
ci / bindings root fedora-current (push) Blocked by required conditions
ci / compose_v2 root fedora-current (push) Blocked by required conditions
ci / docker_py root fedora-current (push) Blocked by required conditions
ci / unit root fedora-current (push) Blocked by required conditions
ci / apiv2 rootless fedora-current (push) Blocked by required conditions
ci / compose_v2 rootless fedora-current (push) Blocked by required conditions
ci / farm rootless fedora-current (push) Blocked by required conditions
ci / unit rootless fedora-current (push) Blocked by required conditions
ci / upgrade v5.3.1 root fedora-current (push) Blocked by required conditions
ci / upgrade v5.6.2 root fedora-current (push) Blocked by required conditions
ci / machine linux amd64 (push) Blocked by required conditions
ci / windows unit (push) Blocked by required conditions
ci / windows e2e (push) Blocked by required conditions
ci / windows machine hyperv (push) Blocked by required conditions
ci / windows machine wsl (push) Blocked by required conditions
ci / macos machine applehv (push) Blocked by required conditions
ci / macos machine libkrun (push) Blocked by required conditions
ci / Total Success (push) Blocked by required conditions
zizmor: GitHub Actions Security Analysis / Zizmor (push) Waiting to run
Update dawidd6/action-send-mail action to v19
2026-09-07 19:06:56 +02:00
Paul Holzinger
5c3cb35a0c
Merge pull request #29718 from podman-container-tools/renovate/github.com-moby-moby-client-0.x
...
ci / int local rootless fedora-prior (push) Blocked by required conditions
ci / sys local rootless fedora-prior (push) Blocked by required conditions
ci / int remote root fedora-prior (push) Blocked by required conditions
ci / sys remote root fedora-prior (push) Blocked by required conditions
ci / int local root fedora-rawhide (push) Blocked by required conditions
ci / sys local root fedora-rawhide (push) Blocked by required conditions
ci / int local rootless fedora-rawhide (push) Blocked by required conditions
ci / sys local rootless fedora-rawhide (push) Blocked by required conditions
ci / int remote root fedora-rawhide (push) Blocked by required conditions
ci / sys remote root fedora-rawhide (push) Blocked by required conditions
ci / apiv2 root fedora-current (push) Blocked by required conditions
ci / bindings root fedora-current (push) Blocked by required conditions
ci / compose_v2 root fedora-current (push) Blocked by required conditions
ci / docker_py root fedora-current (push) Blocked by required conditions
ci / unit root fedora-current (push) Blocked by required conditions
ci / apiv2 rootless fedora-current (push) Blocked by required conditions
ci / compose_v2 rootless fedora-current (push) Blocked by required conditions
ci / farm rootless fedora-current (push) Blocked by required conditions
ci / unit rootless fedora-current (push) Blocked by required conditions
ci / upgrade v5.3.1 root fedora-current (push) Blocked by required conditions
ci / upgrade v5.6.2 root fedora-current (push) Blocked by required conditions
ci / machine linux amd64 (push) Blocked by required conditions
ci / windows unit (push) Blocked by required conditions
ci / windows e2e (push) Blocked by required conditions
ci / windows machine hyperv (push) Blocked by required conditions
ci / windows machine wsl (push) Blocked by required conditions
ci / macos machine applehv (push) Blocked by required conditions
ci / macos machine libkrun (push) Blocked by required conditions
ci / Total Success (push) Blocked by required conditions
zizmor: GitHub Actions Security Analysis / Zizmor (push) Waiting to run
Update module github.com/moby/moby/client to v0.6.0
2026-09-07 17:01:35 +02:00
Lokesh Mandvekar
10b487f229
Merge pull request #29722 from Luap99/lint
...
Update golangci/golangci-lint to v2.13.2
2026-09-07 09:33:26 -04:00
Paul Holzinger
03e177e763
Merge pull request #29725 from podman-container-tools/renovate/github.com-mattn-go-sqlite3-1.x
...
Update module github.com/mattn/go-sqlite3 to v1.14.52
2026-09-07 15:29:16 +02:00
renovate[bot]
1fded364fd
Update dawidd6/action-send-mail action to v19
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-07 11:14:08 +00:00
renovate[bot]
73ac4d256d
Update module github.com/moby/moby/client to v0.6.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-07 11:14:01 +00:00
Paul Holzinger
0a186663dd
Merge pull request #29708 from podman-container-tools/renovate/golang.org-x-crypto-0.x
...
Update module golang.org/x/crypto to v0.56.0
2026-09-07 13:12:04 +02:00
renovate[bot]
9a60f6e67b
Update module github.com/mattn/go-sqlite3 to v1.14.52
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-05 04:46:29 +00:00
Paul Holzinger
89425c337a
Merge pull request #29719 from podman-container-tools/renovate/tags.cncf.io-container-device-interface-1.x
...
ci / sys local root fedora-prior (push) Has been cancelled
ci / int local rootless fedora-prior (push) Has been cancelled
ci / sys local rootless fedora-prior (push) Has been cancelled
ci / int remote root fedora-prior (push) Has been cancelled
ci / sys remote root fedora-prior (push) Has been cancelled
ci / int local root fedora-rawhide (push) Has been cancelled
ci / sys local root fedora-rawhide (push) Has been cancelled
ci / int local rootless fedora-rawhide (push) Has been cancelled
ci / sys local rootless fedora-rawhide (push) Has been cancelled
ci / int remote root fedora-rawhide (push) Has been cancelled
ci / sys remote root fedora-rawhide (push) Has been cancelled
ci / apiv2 root fedora-current (push) Has been cancelled
ci / bindings root fedora-current (push) Has been cancelled
ci / compose_v2 root fedora-current (push) Has been cancelled
ci / docker_py root fedora-current (push) Has been cancelled
ci / unit root fedora-current (push) Has been cancelled
ci / apiv2 rootless fedora-current (push) Has been cancelled
ci / compose_v2 rootless fedora-current (push) Has been cancelled
ci / farm rootless fedora-current (push) Has been cancelled
ci / unit rootless fedora-current (push) Has been cancelled
ci / upgrade v5.3.1 root fedora-current (push) Has been cancelled
ci / upgrade v5.6.2 root fedora-current (push) Has been cancelled
ci / machine linux amd64 (push) Has been cancelled
ci / windows unit (push) Has been cancelled
ci / windows e2e (push) Has been cancelled
ci / windows machine hyperv (push) Has been cancelled
ci / windows machine wsl (push) Has been cancelled
ci / macos machine applehv (push) Has been cancelled
ci / macos machine libkrun (push) Has been cancelled
ci / Total Success (push) Has been cancelled
Update module tags.cncf.io/container-device-interface to v1.1.1
2026-09-04 19:25:48 +02:00
Danish Prakash
764021086d
Merge pull request #29606 from vishnukothakapu/perf-slices-sort
...
Performance: Upgrade sort.Slice to slices.SortFunc across codebase
2026-09-04 21:19:24 +05:30
renovate[bot]
6cccb30dd0
Update module golang.org/x/crypto to v0.56.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-04 15:30:22 +00:00
Paul Holzinger
eea3fa25da
silence new platform specific staticcheck issues
...
These errors only happen on windows or freebsd. They happen when a
function always returns a hard error there so it assumes the condition
is always true which is not the case on another platform.
We then also need to use nolintlint so it does not trigger on linux
where the nolint is not needed otherwise.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 17:21:15 +02:00
Paul Holzinger
7968e61e09
Merge pull request #29717 from podman-container-tools/renovate/github.com-moby-moby-api-1.x
...
ci / int local rootless fedora-prior (push) Blocked by required conditions
ci / sys local rootless fedora-prior (push) Blocked by required conditions
ci / int remote root fedora-prior (push) Blocked by required conditions
ci / sys remote root fedora-prior (push) Blocked by required conditions
ci / int local root fedora-rawhide (push) Blocked by required conditions
ci / sys local root fedora-rawhide (push) Blocked by required conditions
ci / int local rootless fedora-rawhide (push) Blocked by required conditions
ci / sys local rootless fedora-rawhide (push) Blocked by required conditions
ci / int remote root fedora-rawhide (push) Blocked by required conditions
ci / sys remote root fedora-rawhide (push) Blocked by required conditions
ci / apiv2 root fedora-current (push) Blocked by required conditions
ci / bindings root fedora-current (push) Blocked by required conditions
ci / compose_v2 root fedora-current (push) Blocked by required conditions
ci / docker_py root fedora-current (push) Blocked by required conditions
ci / unit root fedora-current (push) Blocked by required conditions
ci / apiv2 rootless fedora-current (push) Blocked by required conditions
ci / compose_v2 rootless fedora-current (push) Blocked by required conditions
ci / farm rootless fedora-current (push) Blocked by required conditions
ci / unit rootless fedora-current (push) Blocked by required conditions
ci / upgrade v5.3.1 root fedora-current (push) Blocked by required conditions
ci / upgrade v5.6.2 root fedora-current (push) Blocked by required conditions
ci / machine linux amd64 (push) Blocked by required conditions
ci / windows unit (push) Blocked by required conditions
ci / windows e2e (push) Blocked by required conditions
ci / windows machine hyperv (push) Blocked by required conditions
ci / windows machine wsl (push) Blocked by required conditions
ci / macos machine applehv (push) Blocked by required conditions
ci / macos machine libkrun (push) Blocked by required conditions
ci / Total Success (push) Blocked by required conditions
zizmor: GitHub Actions Security Analysis / Zizmor (push) Waiting to run
Update module github.com/moby/moby/api to v1.56.0
2026-09-04 16:42:41 +02:00
Paul Holzinger
3222b4bc25
fix new golangci-lint staticcheck warnings
...
Looks like it picked up new deprecated matches so we need some more
nolint to silence them where we still need them for backwards compat in
the API.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 16:40:03 +02:00
Paul Holzinger
53a9bcbe13
run golangci-lint --fix
...
In order to fix the new formatting issues reported.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 16:30:10 +02:00
Paul Holzinger
62d5f150cf
Update golangci/golangci-lint to v2.13.2
...
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 16:29:09 +02:00
Paul Holzinger
68180a8db2
Merge pull request #29613 from ROKUMATE/test-systemd-parser-escape
...
pkg/systemd/parser: add tests for escapeWords and escapeString
2026-09-04 16:14:28 +02:00
Paul Holzinger
afe45cccb6
Merge pull request #29714 from Luap99/go-1.26
...
Update to Go 1.26
2026-09-04 15:48:09 +02:00
Paul Holzinger
8b216d16c4
Merge pull request #29656 from hkwi/fix-compat-stats-http-status
...
api: reflect container stats errors in HTTP status codes
2026-09-04 15:17:42 +02:00
Paul Holzinger
258001db67
Merge pull request #29496 from simek-m/RUN-3319-info-runtimes-status
...
compat: Add status for runtimes to GET /info
2026-09-04 13:54:34 +02:00
Hiroaki KAWAI
d56f52c8a7
api: reflect container stats errors in HTTP status codes
...
Existing KillContainer handling uses HTTP status code 409 when the request cannot be performed because of the current container state. HTTP status code 404 is also used when the target container does not exist.
In contrast, errors from the stats handler are not reflected in the HTTP status code. The HTTP status code is always 200, and the errors are recorded only as generic errors in the server log.
To maintain compatibility with both streaming enabled and disabled, this change treats obtaining at least one complete unit of response content as the response contract. It then keeps the response content consistent with the HTTP status code.
Signed-off-by: Hiroaki KAWAI <hiroaki.kawai@gmail.com>
2026-09-04 20:42:55 +09:00
Paul Holzinger
6c6eac3a5c
run modernize -fix ./...
...
Since I use go 1.26 the go fix does not have all the rules built in,
there are newer ones in modernize so run the explicitly to fix more code
for go 1.26.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 11:53:04 +02:00
Paul Holzinger
526fbee8cc
pkg/systemd/notifyproxy: fix govet lint error
...
This is getting flagged with go.126 now. We need to use %d to log an
integer.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 11:53:04 +02:00
Paul Holzinger
03ee16f5b4
pkg/domain/filters: fix exit code parsing error
...
The function logged the wrong error, logging ec which is the return
value from ParseInt makes no sense since the error tells us the function
failed so ec is invalid/undefined. Also ParseInt already includes the
string input in the error so just drop it.
This was flagged by govet now that we use go 1.26 because %q was wrong
for integers.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 11:53:04 +02:00
Paul Holzinger
eb96a9d5b8
run go fix ./...
...
Plus manually deleting the left over inline functions because go fix
doesn't do that even though they are private functions.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 11:53:04 +02:00
Paul Holzinger
2e49c22bc2
bump go to 1.26
...
Set the minimum supported go version to go 1.26. container-libs requires
it now and some other deps will need it as well.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-09-04 11:53:03 +02:00
renovate[bot]
419c161c10
Update module tags.cncf.io/container-device-interface to v1.1.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-04 09:50:33 +00:00
Jan Rodák
ec30171911
Merge pull request #29660 from simek-m/RUN-3316-compat-until-filter
...
compat: Document and test GET /images/json until filter
2026-09-04 11:45:24 +02:00
Marek Simek
81ec75c4ec
compat: Add status for runtimes to GET /info
...
Docker API v1.44 now includes status properties
in Runtimes for the GET /info endpoint.
Read output of {oci_runtime_cmd} features command
lazily and expose the JSON
output as-is (with removed new lines and
whitespace) as the status field in GET
/info for v1.44+.
Add status to libpod GET /info in ociRuntime.features
and `podman info` (shared).
Add API tests for both endpoints.
Fixes: https://redhat.atlassian.net/browse/RUN-3319
Signed-off-by: Marek Simek <msimek@redhat.com>
2026-09-04 11:37:47 +02:00
Jan Rodák
a8fa4893d8
Merge pull request #29715 from Xiaowen-Yang/docs/29213-container-prune-pods
...
docs: clarify container prune behavior for pods
2026-09-04 10:38:42 +02:00
renovate[bot]
50791266b4
Update module github.com/moby/moby/api to v1.56.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-04 01:45:18 +00:00
Xiaowen-Yang
830c672adf
docs: clarify that container prune excludes containers associated with pods
...
Fixes : #29213
Signed-off-by: Xiaowen-Yang <xiaowenyang52@gmail.com>
2026-09-03 20:58:57 +02:00
Paul Holzinger
b6fb44a48a
Merge pull request #29702 from podman-container-tools/renovate/major-ci-vm-image
...
ci / int local rootless fedora-prior (push) Blocked by required conditions
ci / sys local rootless fedora-prior (push) Blocked by required conditions
ci / int remote root fedora-prior (push) Blocked by required conditions
ci / sys remote root fedora-prior (push) Blocked by required conditions
ci / int local root fedora-rawhide (push) Blocked by required conditions
ci / sys local root fedora-rawhide (push) Blocked by required conditions
ci / int local rootless fedora-rawhide (push) Blocked by required conditions
ci / sys local rootless fedora-rawhide (push) Blocked by required conditions
ci / int remote root fedora-rawhide (push) Blocked by required conditions
ci / sys remote root fedora-rawhide (push) Blocked by required conditions
ci / apiv2 root fedora-current (push) Blocked by required conditions
ci / bindings root fedora-current (push) Blocked by required conditions
ci / compose_v2 root fedora-current (push) Blocked by required conditions
ci / docker_py root fedora-current (push) Blocked by required conditions
ci / unit root fedora-current (push) Blocked by required conditions
ci / apiv2 rootless fedora-current (push) Blocked by required conditions
ci / compose_v2 rootless fedora-current (push) Blocked by required conditions
ci / farm rootless fedora-current (push) Blocked by required conditions
ci / unit rootless fedora-current (push) Blocked by required conditions
ci / upgrade v5.3.1 root fedora-current (push) Blocked by required conditions
ci / upgrade v5.6.2 root fedora-current (push) Blocked by required conditions
ci / machine linux amd64 (push) Blocked by required conditions
ci / windows unit (push) Blocked by required conditions
ci / windows e2e (push) Blocked by required conditions
ci / windows machine hyperv (push) Blocked by required conditions
ci / windows machine wsl (push) Blocked by required conditions
ci / macos machine applehv (push) Blocked by required conditions
ci / macos machine libkrun (push) Blocked by required conditions
ci / Total Success (push) Blocked by required conditions
zizmor: GitHub Actions Security Analysis / Zizmor (push) Waiting to run
Update dependency podman-container-tools/automation to v20260902
2026-09-03 19:55:27 +02:00
Paul Holzinger
bc5f89c78f
Merge pull request #29707 from ajoshua2004/hook-annotations
...
Vendor: Update go.podman.io/common
2026-09-03 19:36:05 +02:00
Paul Holzinger
92a3a02313
Merge pull request #29712 from WhyNotHugo/test-arches
...
Restrict tests to the same architectures as non-test code
2026-09-03 19:32:50 +02:00
Paul Holzinger
f6487b7546
Merge pull request #29669 from CodeWithAK28/manifest-annotate-subject-remote
...
pkg/bindings, pkg/api: send the manifest index subject to the server
2026-09-03 18:21:01 +02:00
Joshua Arrevillaga
8356820264
Update go.podman.io/common vendor
...
update podman common vendor to get access to precreate
hooks, stdout and stderr. Vendor bump also includes mpb
vendor,image, and storage.
Signed-off-by: Joshua Arrevillaga <2004jarrevillaga@gmail.com>
2026-09-03 11:01:33 -04:00
Hugo Osvaldo Barrera
1f1c233202
Restrict tests to the same architectures as non-test code
...
ostree.go is limited to only amd64 and arm64, but its tests run on all
architectures and fail because all their symbols are missing.
Don't run tests on an architecture where the non-test code doesn't
exist.
References: https://github.com/podman-container-tools/podman/issues/29711
Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
2026-09-03 14:19:47 +02:00
renovate[bot]
3ef0845fb5
Update dependency podman-container-tools/automation to v20260902
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-09-02 16:20:56 +00:00
