Commit graph

3550 commits

Author SHA1 Message Date
OpenShift Merge Robot
e7a2eecf5f
Merge pull request #2760 from mheon/misc_small_changes
Remove ulele/deepcopier in favor of JSON deep copy
2019-03-28 07:06:31 -07:00
OpenShift Merge Robot
850326cc19
Merge pull request #2777 from edsantiago/system_df_invalid_arg
system df: reject invalid arguments
2019-03-27 17:03:51 -07:00
Matthew Heon
179a66f1a0 Use spaces instead of tab for JSON marshal indent
The jsoniterator library believes that panic() is a reasonable
response to being told to indent JSON with a tab. So use spaces
instead.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 20:00:31 -04:00
Matthew Heon
589486e3e5 Fix gofmt
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 20:00:31 -04:00
Matthew Heon
5ed62991dc Remove ulele/deepcopier in favor of JSON deep copy
We have a very high performance JSON library that doesn't need to
perform code generation. Let's use it instead of our questionably
performant, reflection-dependent deep copy library.

Most changes because some functions can now return errors.

Also converts cmd/podman to use jsoniter, instead of pkg/json,
for increased performance.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 20:00:31 -04:00
OpenShift Merge Robot
340eeec1b6
Merge pull request #2747 from mheon/dns_none
Add --dns=none
2019-03-27 10:49:42 -07:00
OpenShift Merge Robot
1ff03ee9f5
Merge pull request #2779 from jcpunk/pod-static-publish
doc: add note that pod publish ports are static once defined
2019-03-27 10:36:43 -07:00
Pat Riehecky
1a9252e25c doc: add note that pod publish ports are static once defined
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
2019-03-27 12:08:47 -05:00
OpenShift Merge Robot
fbabe5538f
Merge pull request #2781 from edsantiago/bats
Sigh; disable pod-top test, it's unreliable (#2780)
2019-03-27 09:47:41 -07:00
Ed Santiago
67444db3b1 Sigh; disable pod-top test, it's unreliable (#2780)
Signed-off-by: Ed Santiago <santiago@redhat.com>
2019-03-27 10:14:00 -06:00
OpenShift Merge Robot
c600014643
Merge pull request #2762 from giuseppe/rootless-exec-old-containers-uidmap
rootless: fix regression when using exec on old containers
2019-03-27 08:37:37 -07:00
Matthew Heon
0cd92eae65 Resolve review comments
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Matthew Heon
86f03e0e52 Add a test that --add-host conflicts with --no-hosts
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Matthew Heon
323dc526ce Add manpages and completions for dns=none and no-hosts
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Matthew Heon
236300d028 Add --no-hosts flag to disable management of /etc/hosts
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Matthew Heon
16a7c7ff82 Add for --dns=none to disable creation of resolv.conf
Support in libpod was added in the previous commit. Wire it into
the frontend here.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Matthew Heon
72f03f0c25 Add support to disable creation of network config files
Specifically, we want to be able to specify whether resolv.conf
and /etc/hosts will be create and bind-mounted into the
container.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-27 10:12:18 -04:00
Ed Santiago
bf75ecd4d1 system df: reject invalid arguments
Signed-off-by: Ed Santiago <santiago@redhat.com>
2019-03-27 07:58:42 -06:00
OpenShift Merge Robot
b20594ea51
Merge pull request #2433 from cevich/hack_around_home
[ci skip] get_ci_vm.sh: Fix conflicting homedir files
2019-03-27 06:53:17 -07:00
OpenShift Merge Robot
aba3a84236
Merge pull request #2648 from cevich/check_manpages
Cirrus: Verify manpages for all subcommands exist
2019-03-27 06:45:07 -07:00
Giuseppe Scrivano
aacc5a8632
rootless: fix regression when using exec on old containers
fallback to the previous behavior of joining only the user namespace,
when we cannot join the conmon userns+mount namespaces.

Closes: https://github.com/containers/libpod/issues/2673

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-03-27 14:04:35 +01:00
OpenShift Merge Robot
fcbca91dca
Merge pull request #2749 from jcpunk/doc
docs/podman-pod-create.1.md: add example with port mapping
2019-03-27 02:17:02 -07:00
OpenShift Merge Robot
fc546d4470
Merge pull request #2772 from TomSweeneyRedHat/dev/tsweeney/commandstouch
Touchup commands.md
2019-03-26 17:47:52 -07:00
TomSweeneyRedHat
c108ed5b8d Touchup commands.md
Remove the runlabel command as it's now covered by the
containers-runlabel command.  Add the play command and remove
all of the video links that don't have a video attached to them.

Plus a little bit of table definition changes.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-03-26 19:22:40 -04:00
OpenShift Merge Robot
aa079016bd
Merge pull request #2771 from baude/issue2765
size is optional for container inspection
2019-03-26 09:55:54 -07:00
baude
7f2221d48f size is optional for container inspection
on the remote client, if a user wants to know the rootfs size of a
container, a -s should be passed.  this corrects a behavior where size
was shown by default.

Fixes #2765

Signed-off-by: baude <bbaude@redhat.com>
2019-03-26 10:14:58 -05:00
OpenShift Merge Robot
60b009af4e
Merge pull request #2758 from baude/eventsDied
Add "died" event
2019-03-26 07:09:17 -07:00
OpenShift Merge Robot
94406bcce9
Merge pull request #2769 from ypu/attach_test
Add three test cases for podman attach test
2019-03-26 06:56:26 -07:00
Yiqiao Pu
dc5043ae2d Add three test cases for podman attach test
Add following test cases for podman attach test:
1. podman attach to a running container
2. podman attach to the latest container
3. podman attach to a container with --sig-proxy set to false

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
2019-03-26 20:09:27 +08:00
OpenShift Merge Robot
9e556530d2
Merge pull request #2498 from QiWang19/sysdf
podman system df- show podman disk usage
2019-03-26 04:51:06 -07:00
Qi Wang
25e0f87069 system df to show podman disk usage
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-03-25 15:05:26 -04:00
baude
e730fc6093 Add "died" event
We have a new event for container 'Exited' which has been renamed to
'died'.

also removed the stream bool from the varlink endpoint for events
because it can be determined by the varlink more value.

Signed-off-by: baude <bbaude@redhat.com>
2019-03-25 10:28:50 -05:00
Pat Riehecky
fc19720218 docs/podman-pod-create.1.md: add example with port mapping
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
2019-03-25 08:09:14 -05:00
OpenShift Merge Robot
d0c6a35c05
Merge pull request #2697 from baude/healtcheckphase3
podman health check phase3
2019-03-24 04:16:43 -07:00
baude
bb69004b8c podman health check phase3
podman will not start a transient service and timer for healthchecks.
this handles the tracking of the timing for health checks.

added the 'started' status which represents the time that a container is
in its start-period.

the systemd timing can be disabled with an env variable of
DISABLE_HC_SYSTEMD="true".

added filter for ps where --filter health=[starting, healthy, unhealthy]
can now be used.

Signed-off-by: baude <bbaude@redhat.com>
2019-03-22 14:58:44 -05:00
OpenShift Merge Robot
0458daf13d
Merge pull request #2731 from giuseppe/rootless-wrong-user
troubleshooting: explain setup user: invalid argument
2019-03-22 10:23:05 -07:00
OpenShift Merge Robot
54b901fdda
Merge pull request #2716 from giuseppe/fix-volumes-userns
userns: mount the volumes from the intermediate namespace
2019-03-22 02:02:34 -07:00
Giuseppe Scrivano
7f6f2f3f4a
userns: use the intermediate mountns for volumes
when --uidmap is used, the user won't be able to access
/var/lib/containers/storage/volumes.  Use the intermediate mount
namespace, that is accessible to root in the container, for mounting
the volumes inside the container.

Closes: https://github.com/containers/libpod/issues/2713

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-03-21 21:18:13 +01:00
Giuseppe Scrivano
bf10fac193
volume: create new volumes with right ownership
when we create a new volume we must be sure it is owned by root in the
container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-03-21 20:14:41 +01:00
Giuseppe Scrivano
e31a3d3841
utils: drop dead function
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-03-21 20:14:40 +01:00
Giuseppe Scrivano
927b13dfa5
troubleshooting: explain setup user: invalid argument
replace an old issue that is not valid anymore, since we support
single UIDs mapped into the namespace.

Closes: https://github.com/containers/libpod/issues/2714

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-03-21 18:53:27 +01:00
OpenShift Merge Robot
68e3df3724
Merge pull request #2732 from mheon/closed_is_exited
Make "stopped" a valid state that maps to "exited"
2019-03-21 07:47:54 -07:00
Chris Evich
bb068e46f0
Cirrus: Verify manpages for all subcommands exist
fixes #2630

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-03-21 10:47:27 -04:00
OpenShift Merge Robot
f611f382d1
Merge pull request #2541 from TomSweeneyRedHat/dev/tsweeney/docpull
Update pull and pull-always in bud man page
2019-03-21 07:36:56 -07:00
OpenShift Merge Robot
eeda995e78
Merge pull request #2719 from rhatdan/man
Fix man page to mention race condition
2019-03-21 07:15:55 -07:00
Matthew Heon
9516f28808 Make "stopped" a valid state that maps to "exited"
Fixes #2526

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-03-21 10:00:25 -04:00
OpenShift Merge Robot
b83d05722f
Merge pull request #2727 from clebergnu/podman_run_1_readonly
docs/podman-run.1.md: remove extra whitespace in --read-only
2019-03-21 07:00:06 -07:00
OpenShift Merge Robot
97b966b851
Merge pull request #2720 from QiWang19/save
fix Bug 1688041-podman image save removes existing image
2019-03-21 04:59:01 -07:00
OpenShift Merge Robot
78244aa6d4
Merge pull request #2717 from giuseppe/fix-env-parse
podman: do not split --env on comma
2019-03-21 04:49:03 -07:00
Qi Wang
a6af746a94 fix Bug 1688041-podman image save removes existing image
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-03-20 22:37:58 -04:00