Commit graph

14202 commits

Author SHA1 Message Date
Chris Evich
e5644bbf13
Cirrus: Expand netavark testing to include rootless
The list of netavark/aardvark-dns tasks is likely to be
ever-growing for the near-term.  Consolidate them into a single task
entry with a matrix attribute to make future expansions less
YAML-duplicative.  Also, re-arrange it to fall in-between the CNI
integration and system task sections.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:49:44 -05:00
Chris Evich
1656a23359
Cirrus: Minor - limit release task applicability
This task/test is guaranteed to fail on non-release PRs.  Upon
reviewing actual practice and the release docs, this task should be
limited to PRs with a title containing `release` or `bump` keywords.
Also fix a minor comment typo.

Ref:
https://github.com/containers/podman/pull/13106#pullrequestreview-869855449

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:49:44 -05:00
Chris Evich
afb39f2e47
Cirrus: Add [CI:BUILD] magic that only builds
This is intended for cases where no code changes were made in this repo.
but something did change which could affect the toolchain.  For example,
`Makefile` or packaging changes.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:49:44 -05:00
Lokesh Mandvekar
926c3b08ae
CI: fix nightly builds
Nightly builds were failing on CI ever since the Makefile change to have
install target independent of build targets.
See: e4636ebdc8

This commit ensures everything is built before installation.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-02-11 14:49:44 -05:00
Chris Evich
1e3115cf42
Cirrus: Log netavark/aardvark binary build info.
Enabled by:
* https://github.com/containers/netavark/pull/191
* https://github.com/containers/aardvark-dns/pull/36

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:49:43 -05:00
Chris Evich
66a3be3709
Cirrus: Add netavark/aardvark system test task
Also add a system-test that verifies netavark driver is in use when
magic env. var. is set.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:49:40 -05:00
Chris Evich
6b0d4d9158
Cirrus: Also download aardvark-dns binary
This involves a minor code-change so the download/install can run in a
loop for the two different repositories and binaries.  Given everything
is exactly the same except the URLs and names.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:47:57 -05:00
Chris Evich
b63f61f5cd
Cirrus: Add e2e task w/ upstream netavark
This PR adds the CI mechanisms to obtain the latest upstream netavark
binary, and set a magic env-var to indicate e2e tests should execute
podman with `--network-driver=netavark`.  A future commit implement
this functionality within the e2e tests.

Due to the way the new environment is enabled, the standard task name
is too long for github to display without adding ellipsis.  Force the
custom task name `Netavark Integration` to workaround this.  At some
future point, when netavark is more mainstream/widely supported, this
custom task and upstream binary install can simply be removed - i.e.
netavark will simply be used by default in the normal e2e tasks.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-11 14:44:16 -05:00
Brent Baude
9688a462e9
netavark e2e tests
enabled e2e tests for netavark

Signed-off-by: Brent Baude <bbaude@redhat.com>
2022-02-11 11:23:24 -05:00
OpenShift Merge Robot
c4a9aa7c73
Merge pull request #13195 from jwhonce/wip/network_version_4.0
[4.0] Add version guard to libpod API endpoints
2022-02-10 10:17:57 -05:00
Daniel J Walsh
ec889c819a
Merge pull request #13193 from TomSweeneyRedHat/dev/tsweeney/bumpcommon4
[v4.0] Bump c/common to v0.47.4
2022-02-10 09:39:56 -05:00
Jhon Honce
71d1514490 Add version guard to libpod API endpoints
* Ensure meaningful behaviour when called with /v3.x.x semantics
* Change return code to 409 from 500 when client attempts to use an
  existing network name
* Update API bats test runner to support /v4.0.0 endpoints by default

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2022-02-09 14:38:51 -07:00
tomsweeneyredhat
345413540a [v4.0] Bump c/common to v0.47.4
As the title says.  Bumping c/common in preparation of the
v4.0 release.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2022-02-09 15:54:55 -05:00
OpenShift Merge Robot
5b2d96fc29
Merge pull request #13177 from rhatdan/v4.0
[4.0] idmap should be able to be specified along with other options
2022-02-09 14:53:52 -05:00
Daniel J Walsh
7499496f3d
idmap should be able to be specified along with other options
[NO NEW TESTS NEEDED] crun is not available everywhere to test idmap.
Kernel might not be recent enough and not all file systems support
idmap option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-09 07:14:53 -05:00
OpenShift Merge Robot
2dca7b25d8
Merge pull request #13137 from rhatdan/v4.0
Update containers/buildah v1.24.1
2022-02-04 12:11:12 -05:00
Daniel J Walsh
e47a3bec91
Vendor in containers/buildah v1.24.1
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-04 09:44:39 -05:00
OpenShift Merge Robot
4ad9e0030b
Merge pull request #13133 from mheon/bump_400_rc4
Bump to v4.0.0-RC4
2022-02-04 09:14:15 -05:00
Matthew Heon
cad3eb78b4 Bump to v4.0.0-dev
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-02-03 16:21:26 -05:00
Matthew Heon
0c9648136f Bump to v4.0.0-RC4
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-02-03 16:21:26 -05:00
Matthew Heon
c1618042fd Disable failing E2E test
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-02-03 16:21:26 -05:00
Paul Holzinger
70623790d0 Revert "Move each search dns to its own line"
This reverts commit a1bc8cb52c.
Please see resolv.conf(5) search domains must be on the same line. If
you use multiple seach key words only the last one is used. I tested this
with alpine and it works correctly when they are on the same line so I
am not sure what issues Dan had with it but this is not correct.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-03 16:21:26 -05:00
Daniel J Walsh
48f10e1d0d Move each search dns to its own line
Alpine does not seem to use search correctly when there are multiple
search domains on the same line. It only uses the first with the advent.
When podman runs within a separate network we are appending on
dns.podman as a search, if you add a search domain, then this causes the
local search on network to fail.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 16:21:26 -05:00
Matthew Heon
938d5152ca Update release notes for v4.0.0-RC4
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-02-03 16:21:26 -05:00
Nalin Dahyabhai
99968002fb Document schema values in the --url flag
Document the recognized `schema` types that can be used in a value
passed to the `--url` command line flag.

[CI:DOCS]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2022-02-03 15:02:53 -05:00
cdoern
6d747dca22 podman image scp syntax correction
[NO NEW TESTS NEEDED] image scp was reading the localhost syntax too loosely causing some errors with domains or hosts containing the word
localhost. Fixed that and added a few lines to make sure the pure localhost connections do not touch sshd

resolves #13021

Signed-off-by: cdoern <cdoern@redhat.com>
2022-02-03 15:02:39 -05:00
Paul Holzinger
e0cbcdc335 system prune: remove all networks
podman system prune should also remove all networks. When we want to
users to migrate to the new network stack we recommend to run podman
system reset. However this did not remove networks and if there were
still networks around we would continue to use cni since this was
considered an old system.

There is one exception for the default network. It should not be removed
since this could cause other issues when it no longer exists. The
network backend detection logic ignores the default network so this is
fine.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-03 15:01:29 -05:00
Daniel J Walsh
8f3f0710ff Only change network fields if they were actually changed by the user
Fixes: https://github.com/containers/podman/issues/13065

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 14:59:27 -05:00
Giuseppe Scrivano
fb6fca806d docs: clarify rootless net stats
follow-up for https://github.com/containers/podman/pull/13101

[CI:DOCS]

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-02-03 14:58:34 -05:00
Daniel J Walsh
cad6459b68 Fix size to match Docker selection
Fixes: https://github.com/containers/podman/issues/13096

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 14:54:29 -05:00
Giuseppe Scrivano
06821627fb libpod: enforce noexec,nosuid,nodev for /dev/shm
these mount flags are already used for the /dev/shm mount on the host,
but they are not set for the bind mount itself.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-02-03 14:50:04 -05:00
Daniel J Walsh
44cd232bef Clarify remote client means Mac and Windows
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 14:49:32 -05:00
Giuseppe Scrivano
9d3bcb5875 libpod: report slirp4netns network stats
by default slirp4netns uses the tap0 device.  When slirp4netns is
used, use that device by default instead of eth0.

Closes: https://github.com/containers/podman/issues/11695

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-02-03 14:46:01 -05:00
Tsubasa Watanabe
f65b62c987 Add notes to "--oom-kill-disable" not supported on cgroups V2
Clarify "--oom-kill-disable" is not supported on cgroups V2 in
documentation.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2022-02-03 14:45:45 -05:00
Daniel J Walsh
178cccbf9e Fix use of infra image to clarify default
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 14:45:29 -05:00
Patrycja Guzik
97c8bdfebe Adapt podman images ls filters docs to be aligned with prune filters docs
Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
2022-02-03 14:45:02 -05:00
Aditya R
49076ba871 ignition, machine: delegate cpu,io cgroup controllers to machine's default users
Makes sure that ignition setups up systemd config so cgroup controllers
like `cpu, io` are also delegated to `non-root` along with `memory,
pid`.

This allows general users of `podman` on `macOS` and `podman-remote` to
do operations which are dependent on `cpu, io` cgroup controllers.

[NO TESTS NEEDED]
[NO NEW TESTS NEEDED]
We don't have a CI infra to test this, please pull the tree and run
`podman info` inside the machine to confirm.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-02-03 14:43:28 -05:00
OpenShift Merge Robot
337f706f61
Merge pull request #13130 from nalind/slashify-dockerfile-4.0
[v4.0] pkg/bindings/images.Build(): slashify "dockerfile" values, too
2022-02-03 13:15:17 -05:00
Nalin Dahyabhai
0c9a8ac073 pkg/bindings/images.Build(): slashify "dockerfile" values, too
When the Dockerfile isn't in the root directory of the build context,
the client supplies its pathname to the server, but it needs to do so
using "/" as the path separator, not the client OS's path separator.

CI can't test Windows clients, so
[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2022-02-03 11:36:15 -05:00
OpenShift Merge Robot
18348c0b69
Merge pull request #13068 from mheon/bump_400_rc3
[CI:DOCS] Bump to v4.0.0-RC3
2022-01-28 14:10:09 -05:00
Matthew Heon
3b565bacf1 Remove mention of IPv6 portfwd from release notes
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-28 12:30:08 -05:00
Matthew Heon
10a966a2a0 Bump to v4.0.0-dev
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-28 10:45:59 -05:00
Matthew Heon
9b441c0dda Bump to v4.0.0-RC3
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-28 10:45:32 -05:00
Matthew Heon
f5dfe026d1 Update release notes for v4.0.0-RC3
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-28 10:45:03 -05:00
OpenShift Merge Robot
7781dd7316
Merge pull request #13067 from mheon/fix_ci_40
Fix Cirrus destination branch
2022-01-28 10:44:09 -05:00
Matthew Heon
ebf5ad50eb Fix Cirrus destination branch
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-28 09:23:29 -05:00
OpenShift Merge Robot
1b544b7424
Merge pull request #12712 from flouthoc/volume_overlay_advanced
volume: add support for non-volatile `upperdir`,`workdir` for overlay volumes
2022-01-28 07:06:02 -05:00
OpenShift Merge Robot
f9d2f99653
Merge pull request #13048 from cevich/fix_get_ci_vm
[CI:DOCS] Cirrus: Fix get_ci_vm.sh initial setup
2022-01-28 06:44:04 -05:00
OpenShift Merge Robot
935ae1bfd0
Merge pull request #13052 from Luap99/issues2
[CI:DOCS] github: label issues based on os fix regex
2022-01-28 03:16:04 -05:00
Aditya Rajan
e64e6500d3
volume: add support for non-volatile upperdir,workdir for overlay volumes
Often users want their overlayed volumes to be `non-volatile` in nature
that means that same `upper` dir can be re-used by one or more
containers but overall of nature of volumes still have to be `overlay`
so work done is still on a overlay not on the actual volume.

Following PR adds support for more advanced options i.e custom `workdir`
and `upperdir` for overlayed volumes. So that users can re-use `workdir`
and `upperdir` across new containers as well.

Usage
```console

$ podman run -it -v myvol:/data:O,upperdir=/path/persistant/upper,workdir=/path/persistant/work alpine sh

```

Signed-off-by: Aditya R <arajan@redhat.com>
2022-01-28 13:10:15 +05:30