Commit graph

4900 commits

Author SHA1 Message Date
OpenShift Merge Robot
d05798e5e8
Merge pull request #3771 from TomSweeneyRedHat/dev/tsweeney/manpagetouches
Touch up build man page
2019-08-09 21:10:04 +02:00
OpenShift Merge Robot
492b4f65f6
Merge pull request #3737 from QiWang19/create_auth
fix create&run getting --authfile from cli
2019-08-09 21:09:50 +02:00
OpenShift Merge Robot
4b91f60e89
Merge pull request #3762 from jwhonce/issue/3426
Improve dns-search validation, empty domains now return an error
2019-08-09 20:09:12 +02:00
Jhon Honce
f070913c6a Improve dns-search validation, empty domains now return an error
Fixes #3426

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2019-08-09 09:58:39 -07:00
Qi Wang
cfdf891552 fix create&run getting --authfile from cli
Add flag `--authfile` to create and run so Podman can read authfile path from not only environemnt variable REGISTRY_AUTH_FILE but also CLI

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-08-09 12:27:32 -04:00
OpenShift Merge Robot
dc3816819d
Merge pull request #3713 from mheon/release_notes_1.5.1
Add release notes for v1.5.0
2019-08-09 18:09:41 +02:00
Matthew Heon
82898da77d Add release notes for v1.5.0
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-09 11:10:37 -04:00
OpenShift Merge Robot
00a20f78f0
Merge pull request #3721 from baude/rmifunsies
make rmi messages more compatible with docker
2019-08-09 16:28:36 +02:00
TomSweeneyRedHat
35b7935177 Touch up build man page
Touchup the build man page with a few options
and extra verbiage from Buildah's variant.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-08-09 10:06:24 -04:00
OpenShift Merge Robot
2a190365f2
Merge pull request #3766 from haircommander/probe-conmon
Add conmon probe to runtime construction
2019-08-09 16:05:57 +02:00
OpenShift Merge Robot
66ae8ec037
Merge pull request #3725 from vrothberg/update-docs
podman-container-runlabel(1): drop note
2019-08-09 15:43:19 +02:00
Valentin Rothberg
7b3a15aaff podman-container-runlabel(1): drop note
Drop the note that Podman ensures to always be the first command.
Runlabels allows for executing any command on the host - which is
something we don't necessarily need to advertise or encourage.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-08-09 10:46:01 +02:00
OpenShift Merge Robot
76840f2d99
Merge pull request #3764 from rhatdan/dnssearch
Allow the passing of '.' to --dns-search
2019-08-09 04:03:17 +02:00
baude
e27ee5c840 make rmi messages more compatible with docker
in the case where we rmi an image that has only one reponame, we print
out an untagged reponame message.

$ sudo podman rmi busybox
Untagged: docker.io/library/busybox:latest
Deleted: db8ee88ad75f6bdc74663f4992a185e2722fa29573abcc1a19186cc5ec09dceb

Signed-off-by: baude <bbaude@redhat.com>
2019-08-08 20:05:55 -05:00
Peter Hunt
e2e41a7003 Add conmon probe to runtime construction
Now, when a user's conmon is out of date, podman will tell them

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-08 20:24:19 -04:00
OpenShift Merge Robot
4349f42d66
Merge pull request #3767 from QiWang19/cp_chown
fix copy change file owner if cp from container
2019-08-09 00:44:30 +02:00
OpenShift Merge Robot
202eadef2c
Merge pull request #3765 from TomSweeneyRedHat/dev/tsweeney/buildahvendor
Vendor Buildah 1.10.1
2019-08-08 23:17:16 +02:00
Qi Wang
a2561ec58a fix copy change file owner if cp from container
If copies file from container to local machine, change the file owner to the cp command caller.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-08-08 17:14:47 -04:00
OpenShift Merge Robot
e74957234a
Merge pull request #3699 from fiws/patch-1
add godoc link to readme
2019-08-08 22:52:03 +02:00
TomSweeneyRedHat
711474d92e Vendor Buildah 1.10.1
As the title says, vendor Buildah v1.10.1

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-08-08 16:06:40 -04:00
Daniel J Walsh
5270cd89d3
Allow the passing of '.' to --dns-search
--dns-search is defined to remove all search domains from a container.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-08-08 15:25:50 -04:00
OpenShift Merge Robot
09cedd152d
Merge pull request #3750 from baude/portreporting
fix port early return
2019-08-08 20:34:49 +02:00
OpenShift Merge Robot
3959a357f7
Merge pull request #3739 from TomSweeneyRedHat/dev/tsweeney/badauthnote2
Add invalid credentials fix to docs
2019-08-08 15:08:26 +02:00
OpenShift Merge Robot
5701fe6689
Merge pull request #3744 from mheon/fix_command
When populating CMD, do not include Entrypoint
2019-08-08 14:32:27 +02:00
OpenShift Merge Robot
8776a577bf
Merge pull request #3738 from mheon/mount_opts_bools
Allow --ro=[true|false] with mount flag
2019-08-08 14:20:29 +02:00
OpenShift Merge Robot
31bfb12aec
Merge pull request #3757 from lsm5/makeinstall
add make to make installs
2019-08-08 13:08:27 +02:00
OpenShift Merge Robot
41de7b14e0
Merge pull request #3745 from baude/eventsjournaldremovematch
systemd library conflict with seektail and addmatch
2019-08-08 02:25:08 +02:00
OpenShift Merge Robot
35ecf498dc
Merge pull request #3741 from haircommander/uts-fix
Properly share UTS namespaces in a pod
2019-08-07 23:38:23 +02:00
baude
096af85278 add make to make installs
as issue #2702 describes, we want to make podman and podman-remote as
part of make install.

Fixes: #2702

Signed-off-by: baude <bbaude@redhat.com>

avoid `make` in `make install` in the rpmbuild process.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2019-08-07 14:52:49 -04:00
Peter Hunt
dc750df802 namespaces: fix Container() call
If we call Container(), we expect the namespace to be prefixed with "container:".
Add this check, and refactor to use named const strings instead of string literals

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-07 13:11:08 -04:00
Matthew Heon
8d44c61f27 Add a test for verifying ENTRYPOINT and CMD
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-07 11:49:34 -04:00
baude
b7b86bda2d fix port early return
when listing multiple ports on a container with podman port, an early
return was limiting results.

Fixes: #3747

Signed-off-by: baude <bbaude@redhat.com>
2019-08-07 09:10:47 -05:00
Matthew Heon
c0a124ea89 Allow --ro=[true|false] with mount flag
The 'podman run --mount' flag previously allowed the 'ro' option
to be specified, but was missing the ability to set it to a bool
(as is allowed by docker). Add that. While we're at it, allow
setting 'rw' explicitly as well.

Fixes #2980

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-07 10:03:01 -04:00
Peter Hunt
a602e44e74 refer to container whose namespace we share
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-07 09:53:39 -04:00
Peter Hunt
7c92256103 add test to verify hostname is shared in a pod
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-07 08:44:08 -04:00
Peter Hunt
a87fb78dd1 Properly share UTS namespaces in a pod
Sharing a UTS namespace means sharing the hostname. Fix situations where a container in a pod didn't properly share the hostname of the pod.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-07 08:44:08 -04:00
OpenShift Merge Robot
66ea32cbaf
Merge pull request #3731 from giuseppe/fix-systemd-in-a-container
cgroup: fix regression when running systemd
2019-08-07 04:50:13 +02:00
Matthew Heon
28b545d04c When populating CMD, do not include Entrypoint
Previously, we use CreateConfig's Command to populate container
Command (which is used as CMD for Inspect and Commit).
Unfortunately, CreateConfig's Command is the container's full
command, including a prepend of Entrypoint - so we duplicate
Entrypoint for images that include it.

Maintain a separate UserCommand in CreateConfig that does not
include the entrypoint, and use that instead.

Fixes #3708

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-06 16:11:42 -04:00
baude
62a04f2b03 systemd library conflict with seektail and addmatch
it looks like the core-os systemd library has some issue when using
seektail and add match.  this patch works around that shortcoming for
the time being.

Fixes: #3616
Signed-off-by: baude <bbaude@redhat.com>
2019-08-06 14:58:26 -05:00
OpenShift Merge Robot
f0a5b7ff99
Merge pull request #3733 from edsantiago/bats
pod top test: reenable
2019-08-06 21:07:20 +02:00
Ed Santiago
8922dfcc76 pod top test: reenable
It looks like #2780 is fixed: an overnight run yielded no
instances of 'pod top' returning incomplete output.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2019-08-06 11:46:51 -06:00
Giuseppe Scrivano
69727abdf6
cgroup: fix regression when running systemd
commit 223fe64dc0 introduced the
regression.

When running on cgroups v1, bind mount only /sys/fs/cgroup/systemd as
rw, as the code did earlier.

Also, simplify the rootless code as it doesn't require any special
handling when using --systemd.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1737554

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-06 19:46:34 +02:00
TomSweeneyRedHat
6c3b4572a1 Add invalid credentials fix to docs
Add an entry to the troubleshooting guide detailing how to
get around the problem of invalid credentials when pulling
an image that shouldn't require credentials.

Fixes: #1963

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-08-06 13:34:30 -04:00
OpenShift Merge Robot
b5618d9e35
Merge pull request #3736 from baude/revert
Revert "rootless: Rearrange setup of rootless containers"
2019-08-06 18:17:55 +02:00
OpenShift Merge Robot
37b40e9acd
Merge pull request #3466 from TomSweeneyRedHat/dev/tsweeney/myhome
Touch up XDG, add rootless links
2019-08-06 17:42:54 +02:00
baude
97b84dedf3 Revert "rootless: Rearrange setup of rootless containers"
This reverts commit 80dcd4bebc.

Signed-off-by: baude <bbaude@redhat.com>
2019-08-06 09:51:38 -05:00
OpenShift Merge Robot
3bffe77f82
Merge pull request #3716 from baude/varlinkfixes2
various fixes for varlink endpoints
2019-08-05 16:58:43 +02:00
OpenShift Merge Robot
1c6d7eb954
Merge pull request #3698 from adrianreber/StartedTime
restore: correctly set StartedTime
2019-08-05 16:47:08 +02:00
OpenShift Merge Robot
a15432afe6
Merge pull request #3718 from QiWang19/df_imgindex
fix system df crashes on unnamed images
2019-08-05 16:37:01 +02:00
OpenShift Merge Robot
6997dc1488
Merge pull request #3701 from vrothberg/fix-3696
container stop: kill conmon
2019-08-05 16:36:49 +02:00