4362 commits

Author	SHA1	Message	Date
Kir Kolyshkin	9a2c84b130	test/e2e: fix podman run with noexec for ubuntu 26.04 ... Test case bind mounts host's /bin to /hostbin and tries to exec /hostbin/ls, and expects a particular exit code. It does not work on Ubuntu 26.04 because it ships with coreutils-rs by default, in which: /bin/ls -> ../lib/cargo/bin/coreutils/ls and so we get ENOENT instead of EPERM. Fix by replacing ls with true. The funny thing is, it's also a symlink on Ubuntu 26.04: /bin/true -> gnutrue but it works since the destination is in the same directory. (NOTE the whole test relies on the fact that the kernel checks permissions first -- a dynamic binary from a different distro won't be able to run anyway.) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>	2026-10-01 11:29:30 -07:00
Paul Holzinger	a91da8a402	Merge pull request #29789 from nalind/update-buildah ... Bump buildah to main	2026-09-30 17:50:07 +02:00
Jan Rodák	ac12be994e	Merge pull request #29844 from Garvity/fix/ps-label-table-headings ... ps: fix label lookup in container and pod table headings	2026-09-30 09:18:32 +02:00
Matt Heon	c2f2b19ec8	Merge pull request #29852 from Luap99/multiple-pods-flake ... test/e2e: fix flake in "multiple Pod replicas"	2026-09-29 18:01:02 -04:00
Garv Changrani	d2b8502869	ps: fix label lookup in container and pod table headings ... Table headings for `podman ps` and `podman pod ps` use a plain `map[string]string`. A table template that calls `.Label` with an argument fails while rendering the headings, before listing rows are printed. For example: `podman ps --format 'table {{.Label "app"}}'` Add a shared `PsHeader` type in `cmd/podman/common` with a `Label` method that returns the requested label name as the column heading. Use this type for both container and pod listings. Add container unit tests and extend the existing container and pod e2e tests to check label headings, label values, missing labels, unlabeled objects, and `--noheading` output. Fixes: #29831 Signed-off-by: Garv Changrani <154041471+Garvity@users.noreply.github.com>	2026-09-29 11:29:57 +00:00
Paul Holzinger	b2262db560	test/e2e: fix flake in "multiple Pod replicas" ... GetPort() may return the same port twice, ensure we avoid the case to not make the startup fail on a port conflict. I saw this fail in CI once: $ podman [options] kube play -q --multiple-pods --publish 5811:80,5811:80 /tmp/podman-e2e-759165132/subtest-4128675097/p/ptemp/kube.yaml starting container b0aea9c7e396: rootlessport listen tcp :5811: bind: address already in use Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-29 13:12:32 +02:00
Paul Holzinger	b71273be85	test/e2e: remove duplicated test logic ... The kube down test does the exact same thing already so there is really no need to duplicate this in the interest of test runtime. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-29 13:03:28 +02:00
Nalin Dahyabhai	61195895f3	Pass context.Context values down to newer buildah APIs ... Buildah added some variants of APIs that should improve support for cancellation, so let's use them. Remove the import alias for its copier package in cmd/podman/containers/cp.go and libpod/container_copy_common.go to be more friendly to grep. Update the "prune leftover build containers" test to intentionally leave some behind during its setup instead of SIGKILLing a build process. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>	2026-09-29 06:05:20 -04:00
Matt Heon	fa6cef22c2	Rework podman run checkpoint test ... Needs to properly handle the error now that we've removed the functionality. Signed-off-by: Matt Heon <matthew.heon@pm.me>	2026-09-28 10:28:29 -04:00
Giuseppe Scrivano	a1ce95d761	Merge pull request #29825 from Maniii97/fix/rootless-quadlet ... quadlet: resolve symlinks to find drop-ins in target unit directory	2026-09-25 16:59:59 +02:00
Mani Shankar Jha	44e7c93c37	quadlet: search target directory of symlinked unit files for drop-ins ... Fixes: #29821 Signed-off-by: Mani Shankar Jha <mani.jha@btr.group>	2026-09-24 19:17:48 +05:30
Matt Heon	0fff70d9a0	Merge pull request #29827 from Honny1/fix-pids-max ... Map pids-limit 0 to unlimited for runc	2026-09-23 17:38:09 -04:00
Jan Rodák	5fa0cb1090	Map pids-limit 0 to unlimited for runc ... Docker documents HostConfig.PidsLimit 0 as unlimited, but runc sets pids.max=1 for OCI pids.limit 0. Normalize 0 to -1 when building the OCI spec so native CLI, compat API, and kube play behave consistently. Fixes: https://github.com/podman-container-tools/podman/issues/29826 Signed-off-by: Jan Rodák <hony.com@seznam.cz>	2026-09-23 20:45:45 +02:00
THARUN	14243b7675	inspect: add IsInitCtr and InitContainerType fields ... Add IsInitCtr and InitContainerType fields to container inspect output to distinguish init containers from regular containers. Fixes: #29811 Signed-off-by: THARUN <tharunpoongavanam@gmail.com>	2026-09-23 22:32:45 +05:30
Oleksandr Krutko	ff2eb1b0ca	The feature which allows multiple Pods creation ... Fixes: #26769 Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>	2026-09-20 15:41:06 +03:00
Jan Rodák	6ba4ab29fc	Merge pull request #29587 from haneul-24/fix/kube-play-nested-image-path ... Fix/kube play nested image path	2026-09-17 17:16:38 +02:00
Jan Rodák	fda861989d	Merge pull request #29395 from scallaway/image-scp-compression ... image scp: add --compression-format and --compression-level	2026-09-17 17:09:06 +02:00
Paul Holzinger	91238111ba	Merge pull request #27857 from arsenalzp/podman60_27724 ... Fix startup health check command behavior	2026-09-17 16:32:42 +02:00
seonghun lee	655b8cee14	Hide --cpu-rt-period/--cpu-rt-runtime and mark them as NOP ... Podman 6 dropped cgroups v1 support, and the kernel real-time scheduler cgroup settings only exist on cgroups v1. That means the --cpu-rt-period and --cpu-rt-runtime options can never take effect anymore: on cgroups v2 the values only produce a warning and are discarded. As agreed in the linked issue, the full removal of the options is deferred to the next major release (7.0) to avoid a breaking change for anyone still setting them. For 6.x this commit implements the agreed interim step: - remove the option documentation (docs/source/markdown/options/ cpu-rt-period.md and cpu-rt-runtime.md) and drop the @@option references from the podman-create, podman-run, podman-update and podman-container-clone man pages - hide both flags from --help output - change the existing warning to state that the option is a NOP, that the value is ignored, and that the option will be removed in the next major release The e2e tests are updated to match the new warning text. Actual removal of the flags and the spec fields is left for Podman 7.0. Part of #29750 Signed-off-by: seonghun lee <harrisleesh@gmail.com>	2026-09-17 01:15:52 +09:00
Oleksandr Krutko	91c3d1d8ec	Fix health-startup-cmd behaviour when the value is not set ... Fixes: #27724 Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>	2026-09-15 22:09:57 +03:00
Sejal	469bd43654	fix: support nested image paths in kube play build ... Fixes: #28418 Signed-off-by: Sejal <sej1306kook@gmail.com>	2026-09-14 20:46:29 +00:00
Matt Heon	6e10d5ac76	Merge pull request #29375 from Mahajan-Sachin/quadlet-volume-remainafterexit ... quadlet: do not set RemainAfterExit=yes for volume units by default	2026-09-14 08:52:48 -04:00
Danish Prakash	7417ed0613	Merge pull request #29388 from AftAb-25/fix/events-network-filter ... events: add missing support for NETWORK filter	2026-09-11 16:39:41 +05:30
Aftab Ali	ff12dabebb	events: add missing NETWORK filter to generateEventFilter ... podman events --filter network=<name> was unconditionally returning 'NETWORK is an invalid filter' because the NETWORK case was absent from the generateEventFilter switch statement in filters.go. All other first-class event types (container, image, pod, volume) had corresponding filter cases, but the Network type - despite being fully defined in config.go along with NetworkConnect/NetworkDisconnect statuses and the Event.Network field - had no handler. Add the NETWORK case to filter by network name (e.Network), consistent with Docker's --filter network= behaviour. ID-prefix matching is intentionally omitted: for network connect/disconnect events e.ID holds the container ID, not the network ID, so prefix matching would only work for create/remove events and silently miss join/leave events. Also add unit tests (filters_test.go), integration tests (test/e2e/events_test.go, test/system/090-events.bats), shell completion support for --filter network= (completion.go), and document the new filter key in the man page. Fixes: https://github.com/podman-container-tools/podman/issues/29387 Signed-off-by: Aftab Ali <aftab123215@gmail.com>	2026-09-11 14:31:30 +05:30
Danish Prakash	6b8f0d7b73	Merge pull request #29180 from Honny1/vendor-test-pr-845-container-libs ... [Tests] Add blob-level mirror fallback integration tests	2026-09-11 09:34:56 +05:30
Paul Holzinger	0b62a84304	Merge pull request #29653 from Atishyy27/fix/remote-prune-filter-equals-v2 ... fix(remote): keep '=' in a prune filter value	2026-09-10 18:20:31 +02:00
Scott Callaway	79b35ad0d9	image scp: accept --compression-format=none ... Until now the default could only be expressed by leaving the option off, which reads as an omission rather than a choice and gives a script no way to say it wants the archive transferred as podman save wrote it. Accept none as a format meaning exactly that. It is taken on the API path too, so both interfaces share one vocabulary, and it is treated as the absence of a format throughout: nothing is compressed, a level attached to it is rejected the same way a level with no format is, and the local user to user transfer has nothing to warn about ignoring. The remote client still leaves it off the request, so naming the default does not make a transfer fail against a service that predates these options. Signed-off-by: Scott Callaway <github@scottcallaway.co.uk>	2026-09-10 16:45:30 +01:00
Lokesh Mandvekar	820b7bec17	test/e2e: drop dead network_cmd_options config key ... The network_cmd_options engine setting was backed by the slirp4netns network stack, which has been removed. The key is now a no-op (unknown TOML keys are only debug-logged), so drop it from the e2e test config. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>	2026-09-09 10:30:47 -04:00
Scott Callaway	8cec428401	image scp: add --compression-format and --compression-level ... Expose the compression the transfer already knows how to do, and document what each option means on each path. --compression-format takes gzip or zstd, matching the vocabulary --compression-format already uses on podman push, minus the algorithms this cannot produce or detect. --compression-level takes the level, and is rejected without a format to apply it to rather than being silently ignored. The level needs one caveat spelling out in the man page. A remote source passes it to the command line compressor, where every value is distinct. A local source compresses through c/image, which groups zstd levels into four bands, so 10 and above are the same there. The accepted zstd range also stops at 19 rather than podman push's 20, because the command line compressor needs --ultra past that. The flags are validated before the engine is reached, so podman --remote reports a bad combination without a round trip; the transfer validates again for callers arriving over the API. Fixes: #23192 Signed-off-by: Scott Callaway <github@scottcallaway.co.uk>	2026-09-07 16:03:54 +01:00
Lokesh Mandvekar	10b487f229	Merge pull request #29722 from Luap99/lint ... Update golangci/golangci-lint to v2.13.2	2026-09-07 09:33:26 -04:00
Sachin Mahajan	e822e89e5d	quadlet: do not set RemainAfterExit=yes for volume units by default ... Do not set RemainAfterExit=yes by default when converting Quadlet .volume files to systemd oneshot services. Setting RemainAfterExit=yes causes systemd to consider the volume service active even after the volume is deleted manually, preventing systemd from re-executing volume creation when dependent container services restart. Fixes #27862 Signed-off-by: Sachin Mahajan <sachinmahajan903@gmail.com>	2026-09-07 16:26:10 +05:30
Danish Prakash	764021086d	Merge pull request #29606 from vishnukothakapu/perf-slices-sort ... Performance: Upgrade sort.Slice to slices.SortFunc across codebase	2026-09-04 21:19:24 +05:30
Paul Holzinger	53a9bcbe13	run golangci-lint --fix ... In order to fix the new formatting issues reported. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 16:30:10 +02:00
Paul Holzinger	6c6eac3a5c	run modernize -fix ./... ... Since I use go 1.26 the go fix does not have all the rules built in, there are newer ones in modernize so run the explicitly to fix more code for go 1.26. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 11:53:04 +02:00
Paul Holzinger	eb96a9d5b8	run go fix ./... ... Plus manually deleting the left over inline functions because go fix doesn't do that even though they are private functions. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-09-04 11:53:04 +02:00
Jan Rodák	77bbf5fa79	Add blob-level mirror fallback integration tests ... Integration tests to verify podman-container-tools/container-libs#845 Signed-off-by: Jan Rodák <hony.com@seznam.cz>	2026-09-02 14:19:55 +02:00
Ashley Cui	af579ec299	Add --platform to podman push ... When pushing a manifest list, --platform=OS[/Arch[/Variant]] selects and pushes a single platform-specific manifest instead of the entire list. Also, update compat POST /images/{name}/push to support the platform param (Compat v1.46) Signed-off-by: Ashley Cui <acui@redhat.com>	2026-09-01 11:30:48 -04:00
Jan Rodák	0b2d7729c5	Merge pull request #29654 from Atishyy27/fix/subpath-equals-truncation ... fix(libpod): keep '=' in a volume subpath	2026-09-01 13:55:17 +02:00
Jan Rodák	c30add3f1c	Merge pull request #29667 from CodeWithAK28/remote-push-signing-error ... pkg/domain/infra/tunnel: error when signing a remote push	2026-08-31 11:32:46 +02:00
Anisha Khairnar	ee1d224bad	test/e2e: skip the save signature test on remote ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-29 14:19:26 +05:30
Anisha Khairnar	123b9024d5	pkg/domain/infra/tunnel: error when signing a remote push ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-28 12:17:51 +05:30
Jan Rodák	7a6c0a0504	Merge pull request #28100 from parmisean/parmisean/implement-ssh-session-type ... pkg/bindings: add dial-stdio fallback for SSH connections	2026-08-28 05:02:14 +02:00
Matt Heon	f542424eab	Merge pull request #29603 from gerryd/feature/create-passwd ... Add support for --passwd to the create command	2026-08-27 22:03:01 -04:00
Gerry Demaret	bd8de9f7aa	Add support for --passwd to the create command ... Give create the same --passwd flag as run currently has. Signed-off-by: Gerry Demaret <gerry@x-net.be>	2026-08-27 15:46:30 +02:00
Atishyy27	44f7900e0d	fix(libpod): keep '=' in a volume subpath ... The subpath mount option is parsed with strings.Split(o, "=")[1], so it keeps only the text between the first and second '='. A subpath that contains '=' gets cut short and the container mounts a different directory than the one that was asked for. --mount type=volume,src=v,dst=/mnt,subpath=/opt/a=b/c mounts /opt/a Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>	2026-08-27 18:20:55 +05:30
Jan Rodák	5eab541350	Merge pull request #29651 from vtushar06/fix-bevalidjson ... test/utils: fix BeValidJSON and remove IsJSONOutputValid	2026-08-27 12:47:08 +02:00
Tushar Verma	d153f4750b	test/e2e: remove IsJSONOutputValid ... Asserting a bool against an expected bool says nothing about the output when it fails. BeValidJSON() prints it, and now that the matcher handles a non match properly the negative rows in the info and version table tests can use it too. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Atishyy27	648f91e9c6	fix(remote): keep '=' in a prune filter value ... ImageEngine.Prune split each --filter on every '=' and kept everything after the first as separate values, so a filter whose value itself contains '=' was torn apart. podman-image-prune.1.md documents label=key=value and gives '--filter label=version=1.0' as an example, which produced filters["label"] = ["version", "1.0"] instead of ["version=1.0"]. libimage turns every element into its own label filter and MatchLabelFilters cuts each one on '=' itself, so the request became 'has a label key version' AND 'has a label key 1.0'. Nothing carries a key named 1.0, so the prune matched no images and silently removed nothing. Local podman is unaffected: the abi path passes opts.Filter through untouched. This is remote-only, and it diverges from both siblings -- List uses SplitN(filter, "=", 2) and Events validates then rejoins with strings.Join. Prune now mirrors List. The existing e2e case only used 'label=abc', a bare key, which survives the old split by accident; added one that uses a key=value label and checks the non-matching image is still there afterwards. Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>	2026-08-26 22:21:58 +05:30
Sean Prouty	ee681f80e9	pkg/bindings: add dial-stdio fallback for SSH connections ... Fixes: #27814 Signed-off-by: Sean Prouty <parmisean@proton.me>	2026-08-26 09:05:12 -07:00
Matt Heon	a1c4f9c0e6	Merge pull request #29634 from hihry/fix/Overriding ... specgen: ensure keep-id overrides image USER	2026-08-26 11:57:00 -04:00