install.tools target broke a few weeks ago because it was fetching
something @latest.
We can't use 'go install' nor 'got get ...@version' on this branch,
so just delete the .gitvalidation steps entirely.
Signed-off-by: Ed Santiago <santiago@redhat.com>
On this branch, /usr/local/bin/swagger is fetched on each run
(vs, on current 2022-08 main, installed at VM-setup time).
Something changed, and the new binary is very strict about
bugs in our swagger comments, of which there seem to be many.
Possible solution: fix our code. Doesn't seem worth the bother
for an old branch like this one.
Possible solution: re-fetch an old version of swagger tool.
Ditto.
This solution: just skip the swagger test. It seems unlikely
that anyone will make significant API changes on this branch.
Signed-off-by: Ed Santiago <santiago@redhat.com>
The key used in the tests has expired. Remove the expiration date to
turn CI happy and green.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
(cherry picked from commit de3d34b701)
Pulling the K8s pause image seems unnecessarily expensive to me. Let's
use the testgitest_v2s2 one which is under our control and weighs only a
couple of KB.
This cut the execution time in less than half on my machine. Since it's
network bound and I am running on fibre, I expect more significant speed
ups in slower networks.
Also fixes CI since the K8s pause image changed and broke the test.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
(cherry picked from commit 09ce748ee8)
Podman fails to build with go 1.13 with:
```
vendor/golang.org/x/net/http2/transport.go:417:45: undefined: os.ErrDeadlineExceeded
```
Updating go to 1.15 fixes this issue.
[NO NEW TESTS NEEDED]
Signed-off-by: Dan Čermák <dcermak@suse.com>
This test has a sorted history on `main` to cope with behavior changes
in both podman and results from the registry. Since this is a long-term
release branch, the benefit of having this test (against a modern
registry) outweighs the cost of flakes and maintenance. Simply disable
it.
Signed-off-by: Chris Evich <cevich@redhat.com>
avoid this warn:
```
golangci/golangci-lint info installed ./bin/golangci-lint
golangci/golangci-lint err this script is deprecated, please do not use it anymore. check https://github.com/goreleaser/godownloader/issues/207
```
Signed-off-by: Pascal Bourdier <pascal.bourdier@gmail.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
As release branches age, it becomes less valuable to execute
comprehensive CI testing. Further given occasional flakes, it becomes
more burdensome to maintain. Trim back some non-essential testing tasks
for improved long-term reliability and reduced maintenance.
Signed-off-by: Chris Evich <cevich@redhat.com>
Vendor in the backports for psgo. Note that we cannot use psgo v1.7.1+
as v1.7.2 bumped too many dependencies.
Hence psgo has a v1.7.1-fedora branch that will be used for Podman v3.4.x
for Fedora. The v3.4.2-rhel branch uses c/storage v1.36.x so we need a
separate branches in psgo for Fedora and RHEL.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Resolves: GHSA-8c26-wmh5-6g9v - CVE-2022-27191
Podman doesn't seem to be directly affected as the logic in question
is not called.
golang.org/x/crypto@1baeb1ce contains the actual CVE fix. Using the
latest upstream commit to also include support for SHA-2.
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
The kernel never sets the inheritable capabilities for a process, they
are only set by userspace. Emulate the same behavior.
Closes: CVE-2022-27649
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
(cherry picked from commit aafa80918a)
Backports for github.com/containers/podman/issues/11997
to fix a performance regression when listing images.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Found images being returned which do have "Alpine" in the description.
However, test fails because podman truncates the field. Disabling test
since this is a long-term maintenance branch.
Signed-off-by: Chris Evich <cevich@redhat.com>
We've got some python tests running in CI, and they're really hard
to troubleshoot. This PR:
1) colorizes python unittest lines (ok / skipped / fail), and
2) links to source files
The color is nice for skimming, but it's the linking that might
make it much easier to diagnose future failures.
(Context: failure today in test/python/docker/compat/test_images.py)
Signed-off-by: Ed Santiago <santiago@redhat.com>
It looks like some descriptions have changed on the docker registry
where we had been searching for images that include 'alpine'. We are
now seeing an image in the initial list that has 'alpine' in its
description.
Signed-off-by: Brent Baude <bbaude@redhat.com>
For the since and after imagve filter tests, instead of using the
read-only cache of images, we just use the empty r/w store. We then
build three images that are strictly predictable.
Signed-off-by: Brent Baude <bbaude@redhat.com>
NATIVE_GOOS does not exist in the 3.4 branch, only on main.
Fixes my backport #12327. Verified to fix#12975 (again) for me.
Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
