28229 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Giuseppe Scrivano	58489b82b4	libpod: fix :O overlay volumes in a userns ... When the user owning the storage is not mapped into the container user namespace (e.g. root with --userns=auto), the runtime cannot mount an overlay volume from inside the user namespace. Mount the overlay in podman instead and pass the runtime a bind mount. Closes: https://github.com/podman-container-tools/podman/issues/28758 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>	2026-09-01 09:50:51 +02:00
Jan Rodák	c30add3f1c	Merge pull request #29667 from CodeWithAK28/remote-push-signing-error ... pkg/domain/infra/tunnel: error when signing a remote push	2026-08-31 11:32:46 +02:00
Anisha Khairnar	ee1d224bad	test/e2e: skip the save signature test on remote ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-29 14:19:26 +05:30
Anisha Khairnar	123b9024d5	pkg/domain/infra/tunnel: error when signing a remote push ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-28 12:17:51 +05:30
Jan Rodák	7a6c0a0504	Merge pull request #28100 from parmisean/parmisean/implement-ssh-session-type ... pkg/bindings: add dial-stdio fallback for SSH connections	2026-08-28 05:02:14 +02:00
Matt Heon	f542424eab	Merge pull request #29603 from gerryd/feature/create-passwd ... Add support for --passwd to the create command	2026-08-27 22:03:01 -04:00
Gerry Demaret	bd8de9f7aa	Add support for --passwd to the create command ... Give create the same --passwd flag as run currently has. Signed-off-by: Gerry Demaret <gerry@x-net.be>	2026-08-27 15:46:30 +02:00
Paul Holzinger	21326bf274	Merge pull request #29642 from vtushar06/bindings-parallel ... bindings: use a per-test network config dir, allow parallel	2026-08-27 12:52:39 +02:00
Jan Rodák	5eab541350	Merge pull request #29651 from vtushar06/fix-bevalidjson ... test/utils: fix BeValidJSON and remove IsJSONOutputValid	2026-08-27 12:47:08 +02:00
Paul Holzinger	cb3ff063fd	Merge pull request #29655 from podman-container-tools/renovate/github.com-openshift-imagebuilder-1.x ... Update module github.com/openshift/imagebuilder to v1.2.22	2026-08-27 12:44:50 +02:00
Paul Holzinger	a57c6b15d3	Merge pull request #29649 from jiwahn/optimize-dir-empty-check ... libpod(refactor): optimize directory empty check	2026-08-27 12:26:03 +02:00
renovate[bot]	3e18881a4a	Update module github.com/openshift/imagebuilder to v1.2.22 ... Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-08-26 23:47:21 +00:00
Tushar Verma	d153f4750b	test/e2e: remove IsJSONOutputValid ... Asserting a bool against an expected bool says nothing about the output when it fails. BeValidJSON() prints it, and now that the matcher handles a non match properly the negative rows in the info and version table tests can use it too. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Tushar Verma	d685b5a87b	test/utils: BeValidJSON should not error on invalid json ... Match() returned the unmarshal error for input that is simply not json. Gomega treats a non nil error as a failure to evaluate, so it fails the assertion either way and ToNot(BeValidJSON()) fails on exactly the input it is meant to accept: Expect("{not json").ToNot(BeValidJSON()) --> invalid character 'n' looking for beginning of object key string A non match is (false, nil), the error return is for input the matcher cannot evaluate, which is the wrong type case above it. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Tushar Verma	272f6e1321	bindings: wait for the exec session to finish ... ExecStart returning only means the session was started, so inspecting it straight after can still catch it running. It passed serially because echo is quick, but it failed the first time the suite ran under -p: [FAILED] session should not be running Expected <bool>: true to be false Wait for Running to go false before checking the exit code. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:03:04 +05:30
Tushar Verma	77e8fdb783	bindings: allow running the tests in parallel ... Gate -p on GINKGO_PARALLEL the same way ginkgo-run does, so the suite can be put back to serial with GINKGO_PARALLEL=n like pkg/machine/e2e already does. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:03:04 +05:30
Tushar Verma	a6c9e0954f	bindings: mark the network tests serial ... The network config dir is shared between all the services these tests start, on purpose, so podman can keep subnet allocation consistent. That means the unfiltered prune in the networks BeforeEach, and system.Prune which also prunes networks, would take out networks belonging to another test once the suite runs in parallel. Mark both describes serial like test/e2e does for its own network prune test rather than trying to give each test its own config dir. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:03:04 +05:30
Sean Prouty	ee681f80e9	pkg/bindings: add dial-stdio fallback for SSH connections ... Fixes: #27814 Signed-off-by: Sean Prouty <parmisean@proton.me>	2026-08-26 09:05:12 -07:00
Matt Heon	a1c4f9c0e6	Merge pull request #29634 from hihry/fix/Overriding ... specgen: ensure keep-id overrides image USER	2026-08-26 11:57:00 -04:00
Brent Baude	fb1cb4fa6e	Merge pull request #29643 from vtushar06/remove-os-exit ... test/e2e: do not use os.Exit for error handling	2026-08-26 03:33:57 -05:00
Jiwoo Ahn	63ab237222	libpod(refactor): optimize directory empty check ... No need to read the entire directory for empty check. Extract redundant check into helper Signed-off-by: Jiwoo Ahn <ikwydls1314@gmail.com>	2026-08-26 16:40:12 +09:00
Danish Prakash	9dc5707a3d	Merge pull request #29638 from CodeWithAK28/bindings-no-serialize-auth-fields ... pkg/bindings: keep auth fields out of the query string	2026-08-26 12:49:50 +05:30
Tushar Verma	cf4cb4184c	test/e2e: do not use os.Exit for error handling ... os.Exit(1) kills the process without ginkgo getting a chance to report anything, so a failure here shows up as a suite that just stopped with no output. All six sites run inside ginkgo, three in a SynchronizedBefore Suite and a helper and three inside It blocks, so Expect works and prints the error and the location. The os.Exit(m.Run()) in TestMain stays, that one is correct. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 22:50:18 +05:30
Himanshu Ravindra Iwanati	b8f7129a1a	specgen: ensure keep-id overrides image USER ... Fixes: #29600 Signed-off-by: Himanshu Ravindra Iwanati <work.himanshu.r.v@gmail.com>	2026-08-25 22:26:31 +05:30
Paul Holzinger	5474d7daaa	Merge pull request #29640 from vtushar06/remove-line-matching-helpers ... test/e2e: remove line matching helpers	2026-08-25 17:39:12 +02:00
Matt Heon	610c31d0d0	Merge pull request #29602 from jmtd/patch-2 ... Update podman-manifest-add.1.md.in to correct `manifest add` examples	2026-08-25 10:31:39 -04:00
Tushar Verma	9f691c8a65	test/e2e: remove LineInOutputContainsTag ... A bool assert on the parsed repo/tag map says nothing about the actual images output when it fails. Match the line with a regex instead, the failure then prints every line and the pattern. This also removes tagOutputToMap which had no other user. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 19:19:39 +05:30
Jan Rodák	53da1b8f7b	Merge pull request #29528 from vtushar06/fix-apiv2-exit-status ... hack/ci: do not swallow apiv2 failures	2026-08-25 13:21:27 +02:00
Paul Holzinger	88023665ae	Merge pull request #29611 from vtushar06/fix-build-tmpdir-leak ... build: do not leak context tmpdir	2026-08-25 12:44:52 +02:00
Tushar Verma	33d02631b6	test/apiv2: reset the service before wait tests ... The wait and events tests 500 with a dlopen error on the journald reads when they run against the server the previous file left behind. Paul tracked down what puts that server in this state, restarting it here keeps the suite honest until that is fixed. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 12:03:48 +05:30
Tushar Verma	827f891883	hack/ci: do not swallow apiv2 failures ... Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 12:02:01 +05:30
Tushar Verma	88b173cbde	test/e2e: remove LineInOutputContains ... Both users are plain if conditions, strings.Contains on the output does the same without a helper. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:41:59 +05:30
Tushar Verma	e4699c1b37	test/e2e: remove GrepString ... Matching a bool and then indexing into the returned lines gives no useful output when it fails. Use gomega matchers on the output array instead, they print the array and the expected match on failure. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:40:30 +05:30
Matt Heon	de350af4b1	Merge pull request #28447 from jude-ruben/fix/machine-image-permissions ... machine: ensure disk image is writable before resize (fix read-only image init failure)	2026-08-24 15:07:36 -04:00
Matt Heon	5aba1efe16	Merge pull request #29614 from jiwahn/fix-volume-import-permission ... libpod: adjust permissions for imported volumes	2026-08-24 14:36:13 -04:00
Anisha Khairnar	b142e2e823	pkg/bindings: keep auth fields out of the query string ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-24 23:43:27 +05:30
Paul Holzinger	d092919e55	Merge pull request #29631 from vtushar06/fix-healthcheck-inherit-test ... test/apiv2: build healthcheck image as docker	2026-08-24 18:45:37 +02:00
Jude Ruben Fernando	73657e9267	Fix machine init failure with read-only disk image ... Fixes: #2756 Signed-off-by: Jude Ruben Fernando <rubenfdo@gmail.com> machine: fix stdpull internal imports Signed-off-by: Jude Ruben Fernando <rubenfdo@gmail.com>	2026-08-24 14:35:33 +00:00
Matt Heon	ee442ecc47	Merge pull request #29623 from ROKUMATE/test-machine-splitvolume ... pkg/machine/vmconfigs: add tests for SplitVolume	2026-08-24 09:54:26 -04:00
Miloslav Trmač	ca42cbff0a	Merge pull request #29628 from mehrdadbn9/fix/29627-stats-nil-pointer ... fix(api): nil check Memory.Limit before dereference in stats handler	2026-08-24 15:43:09 +02:00
Jan Rodák	28fce42daa	Merge pull request #29621 from mheon/update_release_notes_main ... Update release notes, pulling in missing releases	2026-08-24 14:33:42 +02:00
Jan Rodák	37efeff76f	Merge pull request #29622 from mtrmac/dd-1G ... Don't allocate 1 GB of memory to create a file	2026-08-24 14:32:30 +02:00
Tushar Verma	e78fdb7c3c	test/apiv2: build healthcheck image as docker ... The healthcheck inherit tests build their image with the default oci format, which drops HEALTHCHECK. The build only warns about it and the test sends that to /dev/null, so the image has no health config, there is nothing to inherit and all 21 assertions come back null. Fixes: 16a1d3fbe9 ("support healthcheck: {} inherits healthcheck from image") Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-24 15:31:02 +05:30
ROKUMATE	724325b709	pkg/machine/vmconfigs: add tests for SplitVolume ... Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>	2026-08-24 15:15:20 +05:30
Jan Rodák	e14fafc21e	Merge pull request #29592 from CodeWithAK28/docs-dedup-generate-kube ... pkg/api/server: drop duplicate generate/kube swagger operation	2026-08-24 09:21:59 +02:00
Danish Prakash	b297a50a05	Merge pull request #29601 from Lfan-ke/fix/exec-detach-keys-help ... podman exec: align --detach-keys help text with run, start, and attach	2026-08-24 12:22:23 +05:30
Mehrdad Biukian Naeini	14506421f9	fix(api): nil check Memory.Limit before dereference in stats handler ... When a container has --memory-reservation set without --memory-limit, resources.Memory is non-nil but resources.Memory.Limit is nil. The compat stats handler dereferences the nil Limit pointer, causing a panic that returns a 500 to the client. Fix: add resources.Memory.Limit != nil guard before the dereference. Regression test added in test/apiv2/19-stats.at. Fixes #29627 Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>	2026-08-23 18:20:37 +04:00
Matt Heon	8efac905d6	Merge pull request #29530 from umar11b/artifact-ls-quiet ... Add --quiet to podman artifact ls	2026-08-21 18:35:20 -04:00
Matt Heon	fbb90e15b0	Merge pull request #29541 from The-indigo/no-heading ... Added implementation for --noheading option for podman farm list	2026-08-21 17:35:21 -04:00
Miloslav Trmač	e5d2869e41	Don't allocate 1 GB of memory to create a file ... bs=1G means "read 1GB into memory at a time"; we really don't need that. On a system with 6GB physical memory (while our test VM is configured to have 8 GB of virtual RAM), this seems to result in trashing and exceeding the 30s timeout, while with a smaller block size, the copy happens in <13 seconds. (dd itself reports 11 s vs. 27 s). Signed-off-by: Miloslav Trmač <mitr@redhat.com>	2026-08-21 22:30:38 +02:00