7964 commits

Author	SHA1	Message	Date
Jan Rodák	0b2d7729c5	Merge pull request #29654 from Atishyy27/fix/subpath-equals-truncation ... fix(libpod): keep '=' in a volume subpath	2026-09-01 13:55:17 +02:00
Danish Prakash	7efd442600	Merge pull request #29690 from ricardobranco777/410_selinux ... test/system: Update test to handle new error message from runc 1.5.0	2026-09-01 16:38:13 +05:30
Paul Holzinger	9242ecc42f	Merge pull request #29673 from Xiaowen-Yang/codex/fix-29664-attach-exited ... api: avoid reinitializing exited containers on logs-only attach	2026-09-01 12:36:00 +02:00
Ricardo Branco	7e8002dd08	test/system: Update test to handle new error message from runc 1.5.0 ... runc 1.5.0 switched to a safe procfs API for setting SELinux labels, so reopened handles no longer carry a /proc/self path in error messages, e.g. "write /1/attr/keycreate: invalid argument" instead of "write /proc/self/attr/keycreate: invalid argument". Relax the regex to match on "attr/keycreate" without requiring the proc/self prefix. Signed-off-by: Ricardo Branco <rbranco@suse.de>	2026-09-01 11:01:36 +02:00
Giuseppe Scrivano	58489b82b4	libpod: fix :O overlay volumes in a userns ... When the user owning the storage is not mapped into the container user namespace (e.g. root with --userns=auto), the runtime cannot mount an overlay volume from inside the user namespace. Mount the overlay in podman instead and pass the runtime a bind mount. Closes: https://github.com/podman-container-tools/podman/issues/28758 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>	2026-09-01 09:50:51 +02:00
Xiaowen-Yang	1c8f2963a1	Preserve exited state for logs-only HTTP attach ... Fixes: #29664 Signed-off-by: Xiaowen-Yang <xiaowenyang52@gmail.com>	2026-08-31 20:31:24 +02:00
Jan Rodák	c30add3f1c	Merge pull request #29667 from CodeWithAK28/remote-push-signing-error ... pkg/domain/infra/tunnel: error when signing a remote push	2026-08-31 11:32:46 +02:00
Anisha Khairnar	ee1d224bad	test/e2e: skip the save signature test on remote ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-29 14:19:26 +05:30
Anisha Khairnar	123b9024d5	pkg/domain/infra/tunnel: error when signing a remote push ... Signed-off-by: Anisha Khairnar <anishakhairnar284@gmail.com>	2026-08-28 12:17:51 +05:30
Jan Rodák	7a6c0a0504	Merge pull request #28100 from parmisean/parmisean/implement-ssh-session-type ... pkg/bindings: add dial-stdio fallback for SSH connections	2026-08-28 05:02:14 +02:00
Matt Heon	f542424eab	Merge pull request #29603 from gerryd/feature/create-passwd ... Add support for --passwd to the create command	2026-08-27 22:03:01 -04:00
Gerry Demaret	bd8de9f7aa	Add support for --passwd to the create command ... Give create the same --passwd flag as run currently has. Signed-off-by: Gerry Demaret <gerry@x-net.be>	2026-08-27 15:46:30 +02:00
Atishyy27	44f7900e0d	fix(libpod): keep '=' in a volume subpath ... The subpath mount option is parsed with strings.Split(o, "=")[1], so it keeps only the text between the first and second '='. A subpath that contains '=' gets cut short and the container mounts a different directory than the one that was asked for. --mount type=volume,src=v,dst=/mnt,subpath=/opt/a=b/c mounts /opt/a Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>	2026-08-27 18:20:55 +05:30
Jan Rodák	5eab541350	Merge pull request #29651 from vtushar06/fix-bevalidjson ... test/utils: fix BeValidJSON and remove IsJSONOutputValid	2026-08-27 12:47:08 +02:00
Tushar Verma	d153f4750b	test/e2e: remove IsJSONOutputValid ... Asserting a bool against an expected bool says nothing about the output when it fails. BeValidJSON() prints it, and now that the matcher handles a non match properly the negative rows in the info and version table tests can use it too. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Tushar Verma	d685b5a87b	test/utils: BeValidJSON should not error on invalid json ... Match() returned the unmarshal error for input that is simply not json. Gomega treats a non nil error as a failure to evaluate, so it fails the assertion either way and ToNot(BeValidJSON()) fails on exactly the input it is meant to accept: Expect("{not json").ToNot(BeValidJSON()) --> invalid character 'n' looking for beginning of object key string A non match is (false, nil), the error return is for input the matcher cannot evaluate, which is the wrong type case above it. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-26 22:51:51 +05:30
Sean Prouty	ee681f80e9	pkg/bindings: add dial-stdio fallback for SSH connections ... Fixes: #27814 Signed-off-by: Sean Prouty <parmisean@proton.me>	2026-08-26 09:05:12 -07:00
Matt Heon	a1c4f9c0e6	Merge pull request #29634 from hihry/fix/Overriding ... specgen: ensure keep-id overrides image USER	2026-08-26 11:57:00 -04:00
Tushar Verma	cf4cb4184c	test/e2e: do not use os.Exit for error handling ... os.Exit(1) kills the process without ginkgo getting a chance to report anything, so a failure here shows up as a suite that just stopped with no output. All six sites run inside ginkgo, three in a SynchronizedBefore Suite and a helper and three inside It blocks, so Expect works and prints the error and the location. The os.Exit(m.Run()) in TestMain stays, that one is correct. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 22:50:18 +05:30
Himanshu Ravindra Iwanati	b8f7129a1a	specgen: ensure keep-id overrides image USER ... Fixes: #29600 Signed-off-by: Himanshu Ravindra Iwanati <work.himanshu.r.v@gmail.com>	2026-08-25 22:26:31 +05:30
Paul Holzinger	5474d7daaa	Merge pull request #29640 from vtushar06/remove-line-matching-helpers ... test/e2e: remove line matching helpers	2026-08-25 17:39:12 +02:00
Tushar Verma	9f691c8a65	test/e2e: remove LineInOutputContainsTag ... A bool assert on the parsed repo/tag map says nothing about the actual images output when it fails. Match the line with a regex instead, the failure then prints every line and the pattern. This also removes tagOutputToMap which had no other user. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 19:19:39 +05:30
Jan Rodák	53da1b8f7b	Merge pull request #29528 from vtushar06/fix-apiv2-exit-status ... hack/ci: do not swallow apiv2 failures	2026-08-25 13:21:27 +02:00
Paul Holzinger	88023665ae	Merge pull request #29611 from vtushar06/fix-build-tmpdir-leak ... build: do not leak context tmpdir	2026-08-25 12:44:52 +02:00
Tushar Verma	33d02631b6	test/apiv2: reset the service before wait tests ... The wait and events tests 500 with a dlopen error on the journald reads when they run against the server the previous file left behind. Paul tracked down what puts that server in this state, restarting it here keeps the suite honest until that is fixed. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 12:03:48 +05:30
Tushar Verma	88b173cbde	test/e2e: remove LineInOutputContains ... Both users are plain if conditions, strings.Contains on the output does the same without a helper. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:41:59 +05:30
Tushar Verma	e4699c1b37	test/e2e: remove GrepString ... Matching a bool and then indexing into the returned lines gives no useful output when it fails. Use gomega matchers on the output array instead, they print the array and the expected match on failure. Part of #18540. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-25 10:40:30 +05:30
Matt Heon	5aba1efe16	Merge pull request #29614 from jiwahn/fix-volume-import-permission ... libpod: adjust permissions for imported volumes	2026-08-24 14:36:13 -04:00
Paul Holzinger	d092919e55	Merge pull request #29631 from vtushar06/fix-healthcheck-inherit-test ... test/apiv2: build healthcheck image as docker	2026-08-24 18:45:37 +02:00
Miloslav Trmač	ca42cbff0a	Merge pull request #29628 from mehrdadbn9/fix/29627-stats-nil-pointer ... fix(api): nil check Memory.Limit before dereference in stats handler	2026-08-24 15:43:09 +02:00
Jan Rodák	37efeff76f	Merge pull request #29622 from mtrmac/dd-1G ... Don't allocate 1 GB of memory to create a file	2026-08-24 14:32:30 +02:00
Tushar Verma	e78fdb7c3c	test/apiv2: build healthcheck image as docker ... The healthcheck inherit tests build their image with the default oci format, which drops HEALTHCHECK. The build only warns about it and the test sends that to /dev/null, so the image has no health config, there is nothing to inherit and all 21 assertions come back null. Fixes: 16a1d3fbe9 ("support healthcheck: {} inherits healthcheck from image") Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-24 15:31:02 +05:30
Mehrdad Biukian Naeini	14506421f9	fix(api): nil check Memory.Limit before dereference in stats handler ... When a container has --memory-reservation set without --memory-limit, resources.Memory is non-nil but resources.Memory.Limit is nil. The compat stats handler dereferences the nil Limit pointer, causing a panic that returns a 500 to the client. Fix: add resources.Memory.Limit != nil guard before the dereference. Regression test added in test/apiv2/19-stats.at. Fixes #29627 Signed-off-by: Mehrdad Biukian Naeini <mehrdadbiukian@gmail.com>	2026-08-23 18:20:37 +04:00
Matt Heon	8efac905d6	Merge pull request #29530 from umar11b/artifact-ls-quiet ... Add --quiet to podman artifact ls	2026-08-21 18:35:20 -04:00
Matt Heon	fbb90e15b0	Merge pull request #29541 from The-indigo/no-heading ... Added implementation for --noheading option for podman farm list	2026-08-21 17:35:21 -04:00
Miloslav Trmač	e5d2869e41	Don't allocate 1 GB of memory to create a file ... bs=1G means "read 1GB into memory at a time"; we really don't need that. On a system with 6GB physical memory (while our test VM is configured to have 8 GB of virtual RAM), this seems to result in trashing and exceeding the 30s timeout, while with a smaller block size, the copy happens in <13 seconds. (dd itself reports 11 s vs. 27 s). Signed-off-by: Miloslav Trmač <mitr@redhat.com>	2026-08-21 22:30:38 +02:00
Jiwoo Ahn	de4333ce06	libpod: fix permissions for imported volumes ... Imported volumes now get ownership and permissions matching the container's mount tareget. Previously, permission adjustment was skipped for imported volumes as they were already non-empty when mounted. Fixes: #25442 Signed-off-by: Jiwoo Ahn <ikwydls1314@gmail.com>	2026-08-21 17:35:23 +09:00
Tushar Verma	fd3937cf62	build: do not leak context tmpdir ... ParseBuildOpts downloads a URL or stdin context into a temp dir and stores it in TmpDirToClose, but the caller only removes that when ParseBuildOpts returns successfully. Every error return after the download leaks it, including the authfile check reproduced in #22642 and a plain build of a git URL with no Containerfile, which leaves the whole clone behind. Use the same succeeded guard TempDirForURL itself uses, one level up so it covers both tmpdir call sites and the logfile next to them. Fixes: #22642 Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>	2026-08-21 08:17:58 +05:30
umar11b	a46392e486	Add --quiet to podman artifact ls ... Problem: podman artifact ls has no way to print just artifact identifiers. Scripts that want to act on artifacts (e.g. remove them) have to parse table output or use --format {{.Digest}}. Every other listing command in podman (images, ps, artifact push/pull) already supports -q/--quiet for this. Impact: users can now run `podman artifact ls --quiet` to get one digest per line, no header, suitable for piping into other podman commands. Change: adds a --quiet/-q bool flag to the list command. When set (and --format is not also given), output.Digest is printed for each artifact instead of the table. Signed-off-by: umar11b <uzaman2018@gmail.com>	2026-08-20 16:31:13 -04:00
Matt Heon	cf156a8ee3	Merge pull request #29468 from JamesBalazs/healthcheck-fix ... support healthcheck: {} inherits healthcheck from image	2026-08-20 15:42:15 -04:00
Matt Heon	f00ce00663	Merge pull request #29565 from magic-peach/fix-29555-kube-memory-emptydir-shared ... kube: share memory backed emptyDir between containers in a pod	2026-08-20 15:28:15 -04:00
Matt Heon	aba4a234e9	Merge pull request #29568 from Luap99/rootlessport ... cmd/rootlessport: handle dual stack sockets right	2026-08-20 14:41:14 -04:00
Adeyemi Adepoju	c7f04d0692	Added implementation for --noheading option for podman farm list ... Signed-off-by: Adeyemi Adepoju <adepojuadeyemi11@gmail.com>	2026-08-20 13:02:58 -04:00
Atishyy27	ef171ba1b9	Fix ErrorToStringArray handling of empty stderr output ... strings.Split(output, "\n") on empty output returns [""], not []. so ErrorToStringArray() reported empty stderr as one line of empty output instead of no output, and any caller checking len() got a wrong count. volume_ls_test.go had to carry HaveLen(1) just to tolerate that on empty stderr, updated to BeEmpty() now that the length is actually correct. filter out empty lines when building the result. Signed-off-by: Atishyy27 <142108881+Atishyy27@users.noreply.github.com>	2026-08-20 16:24:26 +05:30
Paul Holzinger	f6527ece2b	cmd/rootlessport: handle dual stack sockets right ... With podman 6 we switch the main libpod port bind logic used as rootful over to bind dual stack sockets correctly and no longer default the host ip to 0.0.0.0. So -p 8080:8080 should create one dual stack socket that binds all addresses. While -p 0.0.0.0:8080:8080 -p [::]:8080:8080 should create two sockets binding v4 and v6 respectively. Because the go std lib always defaults to dual stack the second case currently fails with EADDRINUSE which is wrong, so fix that to pass the right protocol. This is also how pasta works already so this makes everything consistent now. Signed-off-by: Paul Holzinger <pholzing@redhat.com>	2026-08-20 12:36:51 +02:00
renovate[bot]	ce62cc93c9	Update docker.io/library/golang Docker tag to v1.27 ... Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-08-20 01:49:54 +00:00
Jan Rodák	4edc8d68e3	Merge pull request #29484 from ellieayla/artifact-list-json-output ... feat: Add output format: podman artifact ls --format=json	2026-08-19 17:41:01 +02:00
ellieayla	f596bb7a73	feat: Add output format: podman artifact ls --format=json ... The 'podman artifact ls' command supports a --format flag accepting a go template string. Some commands (eg 'podman image ls') accept a --format=json parameter, and export pure json object to stdout. This change adds a --format=json output mode to artifact lists too. Includes simple documentation mention of --format=json option alongside go template description. Signed-off-by: ellieayla <1447600+me@users.noreply.github.com>	2026-08-19 10:18:10 -04:00
Paul Holzinger	768072c6a8	Merge pull request #29572 from dexp007/main ... compat/secrets: do not expose secret data on inspect endpoint	2026-08-19 15:55:51 +02:00
Lokesh Mandvekar	4451a3f7b9	Merge pull request #29569 from vtushar06/fix-skip-aarch64-msg ... test/system: pass skip_if_aarch64 its message	2026-08-19 08:48:09 -04:00