Commit graph

743 commits

Author SHA1 Message Date
Darcy Wong
36f8edb875 Remove unneeded enable
Remove setting `modelManager.enable = true;`
2019-03-27 08:33:30 +07:00
Darcy Wong
67a43243b7 Start integrating lexical model installs to KMW 2019-03-26 16:22:03 +07:00
Darcy Wong
e46c53da3c Remove enable property
* Not needed for banner
2019-03-25 13:27:40 +07:00
Darcy Wong
cd902e0a2b Fix formatting
* Fix header comment
* Adjust documentation to columns ~80
2019-03-25 11:37:14 +07:00
Darcy Wong
ba06d8209c Set banner height to 0 if undefined 2019-03-25 10:41:52 +07:00
Darcy Wong
d26796d814 Merge branch 'master' into web-suggestion-ui 2019-03-25 09:48:21 +07:00
Darcy Wong
29f6095ca2 Update KMW suggestion width 2019-03-25 09:35:07 +07:00
Darcy Wong
01ffff5cf5 Change suggestion width to number 2019-03-25 09:20:32 +07:00
Joshua Horton
01f3de252e
Merge pull request #1683 from keymanapp/web-layout-abstraction
[Web] Layout abstraction
2019-03-25 09:11:36 +07:00
Darcy Wong
3eed08529c
Merge pull request #1688 from keymanapp/web-banner-cleanup
Cleanup banner
2019-03-25 09:01:07 +07:00
Darcy Wong
67cf3fdc00 Clean up height / visible properties
Per review comment, use `height` to determine banner visibility
2019-03-25 08:57:16 +07:00
Darcy Wong
016214a1a2 Fix access when invalidating/updating suggestions 2019-03-23 10:53:32 +07:00
Darcy Wong
55d86a979d Cleanup 2019-03-22 15:23:30 +07:00
Joshua A. Horton
0188c237b7 Adds TSDoc comments to BannerManager's methods. 2019-03-22 14:59:14 +07:00
Joshua A. Horton
a8e69a3a60 Further fixes BannerManager and OSKManager. 2019-03-22 14:30:33 +07:00
Joshua A. Horton
ca647223d4 Removes banner event-handlers on hot-swap. 2019-03-22 14:29:03 +07:00
Joshua A. Horton
61dee9e09a Merge branch 'master' into web-suggestion-ui 2019-03-22 09:32:29 +07:00
Darcy Wong
535fc38917
Merge pull request #1681 from keymanapp/web-suggestion-banner
[Web] Create suggestion elements
2019-03-22 09:26:52 +07:00
Darcy Wong
94781dcaad Revert bannerManager line 2019-03-22 09:13:37 +07:00
Joshua A. Horton
43977b103d Adds PR docs as JS docs for BannerManager. 2019-03-22 08:46:52 +07:00
Darcy Wong
13c82ed539 Add tablet styling 2019-03-21 21:55:42 +07:00
Joshua A. Horton
96cec47531 Removes extraneous comments. 2019-03-21 15:52:59 +07:00
Darcy Wong
61556ede4a More cleanup 2019-03-21 15:25:43 +07:00
Darcy Wong
1e4d06af5b Revert OSK styling 2019-03-21 15:21:23 +07:00
Joshua A. Horton
a30b08d01f Minor documentation tweaks. 2019-03-21 15:10:22 +07:00
Darcy Wong
319a556a67 Address review comments 2019-03-21 14:48:44 +07:00
Joshua A. Horton
7df91d5f17 Splits layout analysis from OSK generation 2019-03-21 13:06:29 +07:00
Joshua A. Horton
05d0a03324 Starts work on layout refactoring. 2019-03-21 09:52:38 +07:00
Darcy Wong
7323a6a110 Adjust suggestion styling
* Use full width
* Remove "extra" blank region
2019-03-21 09:03:12 +07:00
Darcy Wong
0700704048 Put suggestion text in div and apply styling 2019-03-20 21:26:49 +07:00
Darcy Wong
8a5c6144a6 Create suggestion elements 2019-03-20 16:08:17 +07:00
jahorton
3a79768f16 No more paired 'unloaded'+'loaded' as 'changed' in 'modelchange' events 2019-03-20 10:40:33 +07:00
jahorton
ec022372d0 Adds OSKManager resizing on Banner swapping. Probably not robust. 2019-03-20 10:26:25 +07:00
jahorton
7e422acd1e Fixes BannerManager use of ImageBanner. Issue: mobile OSK not resizing 2019-03-20 10:07:16 +07:00
jahorton
775afa0ba4 Merge branch 'web-suggestion-ui' into web-banner-manager 2019-03-20 09:37:03 +07:00
Joshua Horton
79307c925b Starts adding banner selection logic to the BannerManager. 2019-03-20 09:21:25 +07:00
Joshua A. Horton
b00e47fdfe Start of the BannerManager class. 2019-03-19 15:48:41 +07:00
Darcy Wong
639767fbd1 Fix update of ImageBanner height 2019-03-19 14:32:09 +07:00
Darcy Wong
f79cf355d5 More refactoring of banner
* add more getter/setters
* update how ImageBanner can update the image
2019-03-19 13:58:43 +07:00
Darcy Wong
904da4406a Reorder height calculations
Per review comment,  change `getKeyboardHeight` to not use banner height (revert it to original `getHeight` calculation)
2019-03-19 08:53:44 +07:00
Darcy Wong
af0cefb104 Merge remote-tracking branch 'origin/master' into web-suggestion-ui 2019-03-19 08:44:29 +07:00
Darcy Wong
5d3c5504bb Cleanup
* Separate `getBannerHeight`, `getKeyboardHeight`, and `get Height`
* Add typing to banner height
2019-03-19 08:43:50 +07:00
Joshua A. Horton
96ce41bf65 Merge branch 'master' into web-predict-request-gen 2019-03-19 08:27:47 +07:00
Joshua Horton
33e63efc3a
Merge pull request #1668 from keymanapp/web-embed-popup-processing
[Web] Embedded-mode processing refactor
2019-03-19 08:24:48 +07:00
Darcy Wong
25c779e193 Add method to compute the rows height 2019-03-19 08:15:13 +07:00
Darcy Wong
94a9ab4a00 Clean up adjustHeights()
The methods in `kmwnative.ts` and `kmwembedded.ts` are nearly identical.

Also added a few pixels to the Android OSK dimensions.
2019-03-18 15:45:23 +07:00
Darcy Wong
6a6b455e48 Remove unused file 2019-03-18 13:34:30 +07:00
Darcy Wong
b91427394a Factor banner height on mobile view 2019-03-18 13:27:33 +07:00
Joshua A. Horton
7596f53926 Fixes KMW issues with mouse & key-cap interactions on 'master'. 2019-03-18 12:11:15 +07:00
Joshua A. Horton
713d62f86d Addresses review comment. 2019-03-18 10:08:18 +07:00