erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-10 19:05:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 19

Remove enable property

Browse source 
* Not needed for banner
This commit is contained in:
Darcy Wong 2019-03-25 13:27:40 +07:00
parent 5df8d05e42
commit e46c53da3c
1 changed files with 5 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
web/source/osk/banner.ts
View file

@ -3,7 +3,6 @@ namespace com.keyman.osk {
// Base class for a banner above the keyboard in the OSK
export abstract class Banner {
private _enabled: boolean;
private _height: number; // pixels
private div: HTMLDivElement;
@ -32,26 +31,6 @@ namespace com.keyman.osk {
this.update();
}
/**
* Function enable
* Scope Public
* @return {boolean} true if the banner is enabled
* Description Returns whether the banner is enabled or not
*/
public get enable(): boolean {
return this._enabled;
}
/**
* Function enable
* Scope Public
* @param {boolean} enable true if the banner is to be enabled
* Description Sets whether the banner is enabled or not
*/
public set enable(enable: boolean) {
this._enabled = enable;
}
/**
* Function update
* @return {boolean} true if the banner styling changed
@ -74,7 +53,7 @@ namespace com.keyman.osk {
!(currentDisplayStyle === ds.display));
}
public constructor(enabled: boolean, height?: number) {
public constructor(height?: number) {
let keymanweb = com.keyman.singleton;
let util = keymanweb.util;
@ -83,7 +62,6 @@ namespace com.keyman.osk {
d.className = "kmw-banner-bar";
this.div = d;
this.enable = enabled;
this.height = height;
this.update();
}
@ -113,7 +91,7 @@ namespace com.keyman.osk {
export class BlankBanner extends Banner {
constructor() {
super(true, 0);
super(0);
}
}
@ -128,12 +106,12 @@ namespace com.keyman.osk {
constructor(imagePath, height?: number) {
if (imagePath.length > 0) {
super(true);
super();
if (height) {
this.height = height;
}
} else {
super(true, 0);
super(0);
}
this.img = document.createElement('img');
@ -154,9 +132,6 @@ namespace com.keyman.osk {
if (this.img) {
this.img.setAttribute('src', imagePath);
}
if (imagePath.length > 0) {
this.enable = true;
}
}
}
@ -266,7 +241,7 @@ namespace com.keyman.osk {
private suggestionList : BannerSuggestion[];
constructor() {
super(true, SuggestionBanner.DEFAULT_HEIGHT);
super(SuggestionBanner.DEFAULT_HEIGHT);
this.suggestionList = new Array();
for (var i=0; i<SuggestionBanner.SUGGESTION_LIMIT; i++) {
let s = new BannerSuggestionSpec('kmw-suggestion-' + i, 'en', '', 33, ' ');