When we build a PR on TC we use `pull/ID/head` for the build, not
`pull/ID/merge`, i.e. the tip of the feature branch and not a merge
with the base branch. This means that during the build `pull/ID/merge`
is unknown. This change modifies the trigger to use `pull/ID/head` for
GHA builds as well.
It's still a mystery why `pull/ID/merge` was known to builds in most
cases but failed for some PRs.
One reason for the sometimes small text on the spacebar besides the
too small font size on `kmw-spacebar-caption` was that the calculation
of the ideal font size added double padding: it added two pixels of
padding to the height, but also multiplied the height value by 0.9 which
effectively added more padding. This change removes the 2 pixel padding
from the calculation.
The existing calculation varies the text size to fit in the available
width of the spacebar, so calculating with font size of 1em is reasonable
and better than the previous 0.6em. The previous value would lead to even
an smaller font size for long texts, far below the size that would be
sufficient to fit the text.
The caption on the spacebar used to be 60%. This change increases it to
100%, but that might be sometimes too big. On the other hand, 80% still
seemed to be too small.
Fixes#7940.
This change adds `index.html` to all links that point to test index pages.
This will show the index page instead of the directory listing when
opening locally, identical to the behavior on TC.
Fixes#9848.
Root cause of #9848 is unknown, because the cache state file was filled
with nul bytes. It is unclear how that could have happened, but seems
likely to be external interference.
The cascade was that Server failed to start because it would crash when
attempting to load the cache state file. So this fix resolves that by
handling invalid file exceptions.
Fixes#9939.
Uses refactored KeymanSentry.ts in developer-utils and updates the
loader in Server to run from that.
The changes to tray.ts and friends are required to deal with a top-level
await issue with the shutdown call.
The top-level await issue is described in detail at
https://marc.durdin.net/2023/11/dynamic-import-on-node-js-with-circular-dependencies-leads-to-interesting-failure-modes/
tl;dr: shutdown needed to do a proper Sentry shutdown. The shutdown code
was in index.ts. This led to a circular dependency and caused a silent
and abrupt exit code 13 in Node.js. Moved shutdown code into shutdown.ts
to resolve this.
