Commit graph

4628 commits

Author SHA1 Message Date
Darcy Wong
d99bd10a8a Adjust for banner height 2019-04-01 16:08:14 +07:00
Marc Durdin
8f8ee5bd06 [Web] Add clavbur9 to known failures, per #1711 2019-04-01 11:13:39 +11:00
Marc Durdin
24ca12c716 [Web] Increase robustness and improve reporting of errors for failed tests 2019-04-01 10:20:58 +11:00
Marc Durdin
1f5a881870 [Web] Fixup minor infelicities in regression tests -- was only running first chunk of each test 2019-03-31 08:34:23 +11:00
Joshua A. Horton
10810c6543 A bit more Suggestion UI formatting. 2019-03-29 12:55:48 +07:00
Joshua A. Horton
2e14fcecf8 Refactor of SuggestionBanner 2019-03-29 12:30:54 +07:00
Marc Durdin
375757d040
Merge pull request #1706 from keymanapp/developer-kmanalyze-repick
[Developer] kmanalyze repick - to master
2019-03-29 09:13:45 +11:00
Joshua A. Horton
446182862e Adds BannerSuggestion.apply to KMW. 2019-03-28 10:26:22 +07:00
Joshua A. Horton
66bf2856f5 For Suggestion application: OutputTarget.restoreTo 2019-03-28 10:10:10 +07:00
jahorton
6da4c78161 Extremely rough rip-out-and-replace for the banner 2019-03-27 09:17:10 +07:00
Darcy Wong
36f8edb875 Remove unneeded enable
Remove setting `modelManager.enable = true;`
2019-03-27 08:33:30 +07:00
Darcy Wong
67a43243b7 Start integrating lexical model installs to KMW 2019-03-26 16:22:03 +07:00
Marc Durdin
c2b1e01100 [web] Grrr promise notation still trips me up sometimes 2019-03-25 21:47:22 +11:00
Marc Durdin
f1c434ef0d [web] More error robustness 2019-03-25 19:03:11 +11:00
Darcy Wong
e46c53da3c Remove enable property
* Not needed for banner
2019-03-25 13:27:40 +07:00
Marc Durdin
9ca8358a2b [web] Fixup save not waiting on promise; more robustness on errors 2019-03-25 17:24:00 +11:00
Marc Durdin
6f9faa3b6e [web] Typo in error handler 2019-03-25 16:06:58 +11:00
Darcy Wong
cd902e0a2b Fix formatting
* Fix header comment
* Adjust documentation to columns ~80
2019-03-25 11:37:14 +07:00
Marc Durdin
ebf2b266c6 [web] Add regression test suite 2019-03-25 15:10:57 +11:00
Darcy Wong
ba06d8209c Set banner height to 0 if undefined 2019-03-25 10:41:52 +07:00
Darcy Wong
d26796d814 Merge branch 'master' into web-suggestion-ui 2019-03-25 09:48:21 +07:00
Darcy Wong
29f6095ca2 Update KMW suggestion width 2019-03-25 09:35:07 +07:00
Darcy Wong
01ffff5cf5 Change suggestion width to number 2019-03-25 09:20:32 +07:00
Joshua Horton
01f3de252e
Merge pull request #1683 from keymanapp/web-layout-abstraction
[Web] Layout abstraction
2019-03-25 09:11:36 +07:00
Darcy Wong
3eed08529c
Merge pull request #1688 from keymanapp/web-banner-cleanup
Cleanup banner
2019-03-25 09:01:07 +07:00
Darcy Wong
67cf3fdc00 Clean up height / visible properties
Per review comment, use `height` to determine banner visibility
2019-03-25 08:57:16 +07:00
Darcy Wong
016214a1a2 Fix access when invalidating/updating suggestions 2019-03-23 10:53:32 +07:00
Darcy Wong
55d86a979d Cleanup 2019-03-22 15:23:30 +07:00
Joshua A. Horton
0188c237b7 Adds TSDoc comments to BannerManager's methods. 2019-03-22 14:59:14 +07:00
Joshua A. Horton
a8e69a3a60 Further fixes BannerManager and OSKManager. 2019-03-22 14:30:33 +07:00
Joshua A. Horton
ca647223d4 Removes banner event-handlers on hot-swap. 2019-03-22 14:29:03 +07:00
Joshua A. Horton
61dee9e09a Merge branch 'master' into web-suggestion-ui 2019-03-22 09:32:29 +07:00
Darcy Wong
535fc38917
Merge pull request #1681 from keymanapp/web-suggestion-banner
[Web] Create suggestion elements
2019-03-22 09:26:52 +07:00
Darcy Wong
94781dcaad Revert bannerManager line 2019-03-22 09:13:37 +07:00
Joshua A. Horton
43977b103d Adds PR docs as JS docs for BannerManager. 2019-03-22 08:46:52 +07:00
Darcy Wong
13c82ed539 Add tablet styling 2019-03-21 21:55:42 +07:00
Joshua A. Horton
96cec47531 Removes extraneous comments. 2019-03-21 15:52:59 +07:00
Darcy Wong
61556ede4a More cleanup 2019-03-21 15:25:43 +07:00
Darcy Wong
1e4d06af5b Revert OSK styling 2019-03-21 15:21:23 +07:00
Joshua A. Horton
a30b08d01f Minor documentation tweaks. 2019-03-21 15:10:22 +07:00
Darcy Wong
319a556a67 Address review comments 2019-03-21 14:48:44 +07:00
Joshua A. Horton
7df91d5f17 Splits layout analysis from OSK generation 2019-03-21 13:06:29 +07:00
Joshua A. Horton
05d0a03324 Starts work on layout refactoring. 2019-03-21 09:52:38 +07:00
Darcy Wong
7323a6a110 Adjust suggestion styling
* Use full width
* Remove "extra" blank region
2019-03-21 09:03:12 +07:00
Darcy Wong
0700704048 Put suggestion text in div and apply styling 2019-03-20 21:26:49 +07:00
Darcy Wong
8a5c6144a6 Create suggestion elements 2019-03-20 16:08:17 +07:00
jahorton
3a79768f16 No more paired 'unloaded'+'loaded' as 'changed' in 'modelchange' events 2019-03-20 10:40:33 +07:00
jahorton
ec022372d0 Adds OSKManager resizing on Banner swapping. Probably not robust. 2019-03-20 10:26:25 +07:00
jahorton
7e422acd1e Fixes BannerManager use of ImageBanner. Issue: mobile OSK not resizing 2019-03-20 10:07:16 +07:00
jahorton
775afa0ba4 Merge branch 'web-suggestion-ui' into web-banner-manager 2019-03-20 09:37:03 +07:00