Commit graph

902 commits

Author SHA1 Message Date
Steven R. Loomis
548acaaf02
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-11 15:29:17 -05:00
Steven R. Loomis
9f033278d4 feat(core): marker validation 🙀
- validate marker number when going in or out of the context

#9119
2023-08-11 15:09:54 -05:00
Steven R. Loomis
36c5b9d55b
Merge branch 'master' into feat/core/9119-marker-avoid-surrogate-cliff-epic-ldml 2023-08-11 15:02:17 -05:00
Steven R. Loomis
b572f60c9e feat(core): limit max marker to 0xD7FF 🙀
- updates per review, off by one in max count
- updated the spec
2023-08-11 15:01:51 -05:00
Steven R. Loomis
75fcc5f3fe chore(core): regex cleanup 🙀
- cache the icu::RegexPattern
- rename USet to avoid a conflict with the real one!

For: #9121
2023-08-10 18:35:06 -05:00
Steven R. Loomis
36b4022165 chore(core): regex build 🙀
- fix linkage for some scenarios

For: #9121
2023-08-10 17:50:00 -05:00
Steven R. Loomis
4fc15c9175
Merge branch 'feat/core/9119-marker-core-epic-ldml' into feat/core/9121-regex-epic-ldml 2023-08-10 17:28:57 -05:00
Steven R. Loomis
2bf22c440d feat(core): marker fixes per review comments 🙀
- simplify and improve context processing

For: #9119

Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2023-08-10 13:30:29 -05:00
Steven R. Loomis
66ee68d2b3
Apply suggestions from code review
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2023-08-10 09:36:16 -05:00
Steven R. Loomis
aecb7c5f5e feat(core): regex apply-side 🙀
- apply side is working using replaceFirst()
- mapTo is a not-yet, that will be a special case

For: #9121
2023-08-09 18:08:25 -05:00
Steven R. Loomis
1aba900b01 feat(core): regex match-side 🙀
- match side is working
- lots of string 'schlepping!

For: #9121
2023-08-09 17:45:56 -05:00
Steven R. Loomis
022265e1b8 feat(core): regex 🙀
- update more test deps to link with ICU…

For: #9121
2023-08-09 16:27:56 -05:00
Steven R. Loomis
742373b673 feat(core): u32string_to_u16string 🙀
For: #9121
2023-08-09 16:19:38 -05:00
Steven R. Loomis
e010b6a5bc feat(core): limit max marker to 0xD7FF 🙀
- to avoid mismatched surrogate pairs in markers

For: #9119
2023-08-09 14:54:37 -05:00
Steven R. Loomis
c23303ee23
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-09 12:52:28 -05:00
Steven R. Loomis
f0c81687f6 feat(core): marker fixes per review comments 🙀
- move prepend_marker() to inline
- clear the string in context_to_string()

For: #9119
2023-08-09 12:51:35 -05:00
Steven R. Loomis
f21bd8212d
Merge branch 'master' into feat/core/9119-marker-core-epic-ldml 2023-08-09 11:03:53 -05:00
rc-swag
7e8e7be86f
Merge pull request #9353 from keymanapp/feat/windows/5822/notify-core-on-kbd-activation
feat(windows): Use Keyboard Activated event API call to turn off caps lock (if required) 🚏
2023-08-09 14:12:00 +10:00
rc-swag
e79cfc90d2
feat(windows): review comment
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-09 12:59:59 +10:00
Steven R. Loomis
5c38b18395 feat(core): update icu dependencies 🙀
- enable icui18n
- .. without breaking anything else in ldml tests

For: #9121
2023-08-08 18:45:03 -05:00
Steven R. Loomis
1472bc56b1 feat(core): regex test 🙀
For: #9121
2023-08-08 18:44:27 -05:00
Steven R. Loomis
93b1771570
Merge branch 'master' into feat/core/9119-marker-core-epic-ldml 2023-08-07 16:40:07 -05:00
rc-swag
3bcd919922
feat(windows): review suggestions
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-07 12:08:09 +10:00
Marc Durdin
49d471ba17
Merge pull request #8954 from keymanapp/feature-kmc-kmw
epic: kmc-kmw KeymanWeb compiler in Typescript 🗜
2023-08-07 11:37:39 +10:00
Steven R. Loomis
290bcede2f feat(core): improve documentation on transform/marker processing loop 🙀
For: #9119
2023-08-04 16:12:02 -05:00
Steven R. Loomis
1480e4d934 feat(core): improve emit_text() marker processing loop 🙀
For: #9119
2023-08-04 16:03:13 -05:00
Steven R. Loomis
fbb874fbfe feat(core): warning fix 🙀
For: #9119
2023-08-04 15:29:19 -05:00
Steven R. Loomis
a9badff183 feat(core): remove reference to CODE_DEADKEY 🙀
For: #9119
2023-08-04 15:21:38 -05:00
Steven R. Loomis
b80b43e1e9 feat(core): re-refactor transform processing logic 🙀
For: #9119
2023-08-04 15:20:00 -05:00
Steven R. Loomis
d21fd6bbc4 Merge remote-tracking branch 'upstream/master' into feat/core/9119-marker-core-epic-ldml 2023-08-04 14:14:07 -05:00
Marc Durdin
cdf026c2ba chore: Merge branch 'feature-kmc-kmw' into chore/merge-master-into-feature-kmc-kmw-a17s18 2023-08-04 12:54:10 +07:00
Steven R. Loomis
6632aafeec spec(core): update per code review 🙀
- keep 'deadkey' out of the ldml code
- other renames

For: #9119
2023-08-03 19:00:21 -05:00
Steven R. Loomis
d53ae69299
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-03 18:56:05 -05:00
Steven R. Loomis
8f4cf8c24e feat(core): refactor sentinel 🙀
- and break all the things

For: #9119
2023-08-03 18:52:53 -05:00
Steven R. Loomis
20d1aad679 feat(core): refactor char emit 🙀
- and add an assert that UC_SENTINEL doesn't go into the text stream

For: #9119
2023-08-03 17:39:09 -05:00
Steven R. Loomis
cd3116d7cb feat(core): improve processing logic 🙀
- improve the ctxt managing logic a little bit.
- need to handle markers as markers, though.

#9119
2023-08-03 15:20:37 -05:00
Steven R. Loomis
8a59df7fe3
Merge branch 'feat/developer/9119-marker-update-spec-epic-ldml' into feat/core/9119-marker-core-epic-ldml 2023-08-03 14:44:34 -05:00
Steven R. Loomis
3db0220f43 feat(core): steps in marker imp 🙀
- fix a logic err in vars - premature optimization was skipping when we had markers but no other vars
- update marker output in keys, including to and longpress.  TODO-LDML still do not handle markers in lists (longpress, multitap, or flicks). The tests are there but commented out.

For: #9119
2023-08-03 13:26:19 -05:00
Ross
85ad6125bf feat(windows): typos 2023-08-03 13:09:12 +10:00
rc-swag
ba572f1f31
feat(windows): apply suggestions from code review 2023-08-03 13:08:11 +10:00
Ross
792899c124 feat(windows): add ProcessActionsExternalEvent 2023-08-03 12:12:57 +10:00
Steven R. Loomis
22a65711f9 feat(core): starting in on marker implementation 🙀
- with a failing test case, of course
- basic test of markers

For: #9119
2023-08-02 18:56:18 -05:00
Steven R. Loomis
913cb5d18a
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-02 18:55:22 -05:00
Steven R. Loomis
2a818b1ede spec(core,developer): update marker spec 🙀
- use UC_SENTINEL CODE_DEADKEY …
- use U+FFFE for any marker
- add asserts between .ts and C++
- update generation

For: #9119
2023-08-02 18:04:48 -05:00
Marc Durdin
41aac59a4a chore(developer): minor patches to fix compile issues
Fixes #9377.

1. ldml_transforms.cpp used emplace_back with char instead of dword
   values (#9377)
2. import was updated to src/ instead of ../ by vscode in build.ts
   (no related issue)
2023-08-01 13:27:31 +07:00
Ross
a8f2934406 feat(windows): add unit test for external event
Added a unit test for an external event. Also updated
the unit test utility print code for action items to include
KM_KBP_IT_CAPSLOCK.
2023-07-31 09:52:14 +10:00
Steven R. Loomis
0d3ffbbe57 chore(core): marker - pt-abnt2 broken 🙀
- upstream in CLDR is incomplete in marker/transform implementation, disabling for now

#9119
2023-07-29 20:30:59 -05:00
Steven R. Loomis
c15e1f37c2
Merge branch 'feat/developer/9119-marker-epic-ldml' into feat/developer/9119-marker-emit-epic-ldml 2023-07-29 17:02:54 -05:00
Steven R. Loomis
e71e1c10d8
Merge branch 'master' into feat/developer/9119-marker-epic-ldml 2023-07-29 17:02:38 -05:00
Steven R. Loomis
2ec20ae8b4
Merge pull request #9352 from keymanapp/chore/core/7375-reorder-comments-epic-ldml
chore(core): update documentation in transform logic and processor 🙀
2023-07-29 17:01:39 -05:00