Commit graph

6184 commits

Author SHA1 Message Date
Darcy Wong
a3f2ec720d Merge branch 'stable-12.0' into android-fix-left-deletions 2019-11-13 16:45:16 +07:00
Darcy Wong
29b201cd00 fix(android): Still trying to adjust the cursor on Firefox
* Also updated CharSequenceUtilTest to reflect expected rota keyboard output
2019-11-13 15:43:23 +07:00
Darcy Wong
6fde9c1739 chore(android): move utility methods to new class
Refactor charSequence utilities to CharSequenceUtil.java
2019-11-13 08:37:52 +07:00
Marc Durdin
246afc5656
Merge pull request #2317 from keymanapp/ios-cherrypick-2299
fix(ios): System keyboard popup-key positioning confinement 🍒
2019-11-13 07:17:51 +11:00
Marc Durdin
80d292454c
Merge pull request #2318 from keymanapp/ios-cherrypick-2301
fix(ios): Fixes bad initialization of system keyboard width
2019-11-13 07:17:01 +11:00
Marc Durdin
51bd89d0ef
Merge pull request #2324 from keymanapp/fix/windows/cherrypick/2147-exception-closing-keyman
fix(windows): Keyman crash and interop with Metro-style apps 🍒
2019-11-13 07:09:57 +11:00
Marc Durdin
aa3abb2ed7
Merge pull request #2288 from keymanapp/web-2209-cherry-mnemonic-code-handling
cherry(web): Fixes mnemonic code handling issues
2019-11-13 07:09:42 +11:00
Marc Durdin
b8847c79a9
Merge pull request #2283 from keymanapp/web-2267-cherry-detect-ios-spoofs
cherry(web): iOS-Safari user agent spoof detection
2019-11-13 07:09:19 +11:00
Marc Durdin
971003bf2d
Merge pull request #2284 from keymanapp/web-2261-cherry-nul-context-replacement
cherry(web): Bounds-check on context deletion from keyboard rules
2019-11-13 07:08:42 +11:00
Darcy Wong
c4c85af98f chore(android): Add logging and adjust unit test constant 2019-11-12 22:18:52 +07:00
Darcy Wong
002f378a51 fix(android): Add unit test for adjust cursor position
Still wip for adjusting cursor in Firefox
2019-11-12 15:26:38 +07:00
Marc Durdin
cd6a8ddf52 chore(windows): history.md 2019-11-12 16:49:00 +11:00
Marc Durdin
eb13e26b1e fix(windows): Keyman was not working with Skype
Fixes #1680. This issue arose only on some systems where
permissions for Keyman registry keys were not being
set correctly.
2019-11-12 16:44:26 +11:00
Marc Durdin
e91f29ee03 chore(windows): unreferenced param in release build 2019-11-12 16:42:01 +11:00
Marc Durdin
35584b669b chore(developer): tidy up from review comments 2019-11-12 16:42:01 +11:00
Marc Durdin
a8dcf173e1 fix(windows): tweak preprocessor conditional 2019-11-12 16:42:01 +11:00
Marc Durdin
805c640802 fix(windows): Keyman was crashing sporadically
Fixes #2147.

This potentially addresses the issues reported in #2147 where Keyman
would crash due to a race condition as a critical section was not
deleted before attempting to recreate it.

Some logging has been added for debugging these issues.

Also fixes memory leaks and another race on startup relating to loading
the taskbar icon.

There are still some known memory leaks because DLL_THREAD_DETACH is
not called for all threads before keyman32.dll is unloaded, so those
threads don't get the opportunity to clean themsselves up. However, the
key danger with the csGlobals critical section has been addressed.
2019-11-12 16:42:00 +11:00
Darcy Wong
d66d029406 fix(android): change adjustCursorPosition to use CharSequence
Changed signature in preparation for unit testing
2019-11-11 23:16:27 +07:00
Darcy Wong
f25633fe24 chore(ios): Update history.md 2019-11-11 13:09:09 +07:00
Darcy Wong
1847f761e4 fix(ios): Cherry-pick #2301 for stable-12.0
Fixes #2260 for stable-12.0

These changes ensure that the Swift side of the keyboard can provided the KMW side with an initial width, bypassing the need for the failing `window.orientation` check (which was used to produce said initial width).
2019-11-11 12:02:07 +07:00
Darcy Wong
5728c410fb fix(ios): Cherry-pick #2306 to stable-12.0
Fixes #2299 for 12.0 stable
2019-11-11 11:54:34 +07:00
Marc Durdin
65deb74455
Merge pull request #2282 from keymanapp/ios-cherry-toolchain-update
cherry(iOS):  Toolchain update
2019-11-11 15:34:34 +11:00
Darcy Wong
1d521913e4 fix(android): Add unit test RestoreCharsTest 2019-11-09 08:03:57 +07:00
Darcy Wong
cb7a87986a fix(android): refactor restoreChars()
Split out method `restoreChars()` so it can be run in unit test

* also adjust CountSurrogatePairsTest
2019-11-08 21:51:48 +07:00
Darcy Wong
8daa93a8e4 fix(android): Start refactoring to add unit tests 2019-11-08 15:49:12 +07:00
Sandra Forberger
87178b0640 fix[android]: fix cursor after insert 2019-11-07 10:05:48 +07:00
Darcy Wong
8a74b8aa90 fix(android): Skip if there's no left context to delete 2019-11-06 13:11:45 +07:00
Darcy Wong
95c0206309 chore: cleanup
* Make performLeftDeletions private
* Add try catch block to guard against out of bounds errors
2019-11-06 10:24:19 +07:00
Darcy Wong
2bfb3142d4 fix(android): Use commitText instead of setComposingText
This does a better job of updating the cursor so the next character gets correctly inserted
2019-11-06 09:26:43 +07:00
jahorton
e49e6ab11a fix(web): fixes mnemonic code handling issues 2019-11-04 14:47:02 +07:00
jahorton
32a96ee260 fix(ios): disables dark mode b/c incompatibilities 2019-11-04 09:06:47 +07:00
jahorton
b4cf5de51d change(ios): launch splash uses storyboard, includes 'dark' version 2019-11-04 09:06:47 +07:00
jahorton
83f8e82415 fix(ios): build.sh -no-codesign for new build sys 2019-11-04 09:06:47 +07:00
jahorton
7405638b9c fix(ios): popover alignments, cancellation 2019-11-04 09:06:46 +07:00
jahorton
bf39c854ed fix(ios): most of the new Swift 5 deprecations 2019-11-04 09:06:46 +07:00
jahorton
854fc6d3ba change(ios): disables Mac Catalyst build target 2019-11-04 09:06:46 +07:00
jahorton
7d9c687094 change(ios): updates build; drops legacy build sys 2019-11-04 09:06:46 +07:00
jahorton
21bb483add change(ios): Swift 4 -> Swift 5 base conversion 2019-11-04 09:06:45 +07:00
jahorton
2a9171b8f5 fix(web): Almost broke Chrome debug on macOS 2019-11-04 08:40:18 +07:00
jahorton
581b66f228 fix(web): Fixes #2267 - iOS-Safari user agent spoof detection 2019-11-04 08:40:18 +07:00
Joshua A. Horton
6a16b45b63 feat(web): bounds check unit test 2019-11-04 08:27:35 +07:00
Joshua A. Horton
94b10a0e76 fix(web): Adds bounds-check in output targets 2019-11-04 08:27:35 +07:00
Joshua A. Horton
147e6add43 fix(web): Fixes #2261, filters nul when deleting context 2019-11-04 08:27:35 +07:00
Darcy Wong
ea8a08a1a7 chore(android): cleanup unused code 2019-11-03 22:23:35 +07:00
Darcy Wong
f18ba4d533 fix(android): advance cursor when re-inserting chars 2019-11-02 22:59:52 +07:00
Darcy Wong
ab37dea089 fix(android): Continue to implement algorithm 2019-11-01 23:14:56 +07:00
Darcy Wong
750bd6b860 fix(android): Start implementing algorithm to compensate for deletes 2019-11-01 15:04:36 +07:00
Darcy Wong
deb6b6f4b0 fix(android): Also increment when deleting SMP 2019-10-31 23:16:44 +07:00
Darcy Wong
f60b47a65b fix(android): Adjust for Android left deletions 2019-10-30 23:41:47 +07:00
Darcy Wong
466b68e83a
Merge pull request #2255 from keymanapp/android-disable-dictionary-on-password
fix: Temporarily disable dictionary when entering password field
2019-10-30 09:59:00 +07:00