Eberhard Beilharz
93eabd96ab
refactor(web): use substring instead of slice
...
This addresses code review comments which recommended to use `substring`
as this makes it more consistent with the rest of our code base.
2024-06-03 12:20:02 +02:00
Eberhard Beilharz
3ee8359f8f
refactor(web): Replace deprecated substr with slice
...
Also add a comment to `SourcemappedWorker` explaining the difference
to `DefaultWorker`.
2024-05-31 11:27:55 +02:00
Eberhard Beilharz
6cb76ca6a8
Merge pull request #11592 from keymanapp/fix/linux/apiverification
...
fix(linux): Don't clean workdir after checkout in API verification
2024-05-29 08:24:39 +02:00
Eberhard Beilharz
4d4b10fc95
fix(linux): Don't clean workdir after checkout in API verification
...
Set the option for the Checkout step to not run `git clean` after checkout
because that gets rid of the artifacts we previously restored.
2024-05-28 16:32:05 +02:00
Eberhard Beilharz
c8d8e4187a
Merge pull request #11571 from keymanapp/fix/linux/apiverification
...
fix(linux): Restore artifacts for API verification in the correct job
2024-05-28 15:02:36 +02:00
Eberhard Beilharz
32bc9e7833
fix(linux): Restore artifacts for API verification in the correct job
...
Previously we had an extra job where we setup the environment and
restored the artifacts. However, the artifacts then were no longer
available in the next job, `api_verification`. Instead of restoring
the artifacts a second time this change squashes the two jobs. This will
hopefully fix the API verification.
2024-05-27 19:18:11 +02:00
Steven R. Loomis
7d9b1a1ed1
Merge pull request #11520 from keymanapp/feat/core/9467-devolve-norm-to-js2-epic-ldml
...
feat(core): change normalize_nfd() to use JS native call instead of ICU on wasm 🙀
2024-05-27 10:26:32 -05:00
Steven R. Loomis
ab7fd5ee37
Merge pull request #11519 from keymanapp/feat/core/9467-devolve-regex-to-js-epic-ldml
...
refactor(core): prepare normalization code to call into JS under WASM 🙀
2024-05-27 10:25:50 -05:00
Eberhard Beilharz
710567590f
Merge pull request #11536 from keymanapp/fix/linux/apiverification
...
chore(linux): Debugging API verification
2024-05-27 15:31:57 +02:00
Steven R. Loomis
948f979b88
Merge branch 'feat/core/9467-devolve-regex-to-js-epic-ldml' into feat/core/9467-devolve-norm-to-js2-epic-ldml
2024-05-27 08:30:19 -05:00
Steven R. Loomis
88af4f588c
Merge branch 'master' into feat/core/9467-devolve-regex-to-js-epic-ldml
2024-05-27 08:30:08 -05:00
Steven R. Loomis
1700953351
Merge pull request #11418 from keymanapp/chore/common/10183-unicode-version
...
test(core): verify Unicode and ICU versions cross-platform 🙀
2024-05-27 08:25:20 -05:00
Marc Durdin
b1643bd6cd
Merge pull request #11565 from keymanapp/chore/run-sourcepackage-job-on-24.04
...
chore(linux): run deb-package sourcepackage job on Ubuntu 24.04
2024-05-27 20:25:06 +07:00
Eberhard Beilharz
8ae5090e6c
fix(linux): Ignore API verification check until it is working
...
This temporary change will always set the result to SUCCESS so as not
to block PRs. Once we get the API verification working we should undo
these changes again.
2024-05-27 15:06:40 +02:00
Marc Durdin
1c5d0c58e6
chore(linux): run deb-package sourcepackage job on Ubuntu 24.04
...
Ubuntu 22.04 has meson 0.61; 24.04 has meson 1.3, so updated the
sourcepackage step in deb-packaging to 24.04 to meet min reqs.
2024-05-27 15:10:08 +07:00
Marc Durdin
79ac9208cf
Merge pull request #11527 from keymanapp/chore/common/labels
...
chore(common): update labels to include change, style
2024-05-27 10:59:27 +07:00
Shawn Schantz
b068f94537
Merge pull request #11515 from keymanapp/fix/mac/10997-adopt-unified-logging
...
change(mac): adopt unified logging APIs
2024-05-27 09:11:45 +07:00
sgschantz
1d5ef914ce
fix(mac): adopt unified logging
...
address review comments
2024-05-27 08:58:25 +07:00
Marc Durdin
8f81fd17e7
Merge branch 'master' into chore/common/labels
2024-05-25 05:41:18 +07:00
Marc Durdin
6abf577f21
Merge branch 'feat/core/9467-devolve-regex-to-js-epic-ldml' into feat/core/9467-devolve-norm-to-js2-epic-ldml
2024-05-25 05:41:01 +07:00
Marc Durdin
d37b64be5e
Merge branch 'chore/common/10183-unicode-version' into feat/core/9467-devolve-regex-to-js-epic-ldml
2024-05-25 05:40:42 +07:00
Marc Durdin
554c27dfeb
Merge branch 'master' into chore/common/10183-unicode-version
2024-05-25 05:39:58 +07:00
Keyman Server
440297199f
Merge pull request #11537 from keymanapp/auto/version-master-18.0.45
...
auto: increment master version to 18.0.45
2024-05-24 11:06:04 -07:00
Keyman Build Agent
d87460c22d
auto: increment master version to 18.0.45
2024-05-24 14:05:27 -04:00
Eberhard Beilharz
7b753241b1
chore(linux): Debugging API verification
...
Something is still not right. It looks like it can't find the files it
is expecting. This change lists the files we have.
2024-05-24 19:12:08 +02:00
Eberhard Beilharz
071b178d20
Merge pull request #11533 from keymanapp/fix/linux/apiverification
...
fix(linux): Properly use and pass run_id
2024-05-24 16:19:53 +02:00
Eberhard Beilharz
6b2437e8a3
fix(linux): Properly use and pass run_id
...
The previous attempt where we set a environment variable for the
artifacts key resulted in a chicken/egg problem: we needed the environment
variable to be able to restore the cached artifacts, but we needed
the cached artifacts in order to be able to read the variables...
This change now properly uses run_id: in `deb-packaging.yml` we can
directly use `run_id` from the context. In `api-verification.yml` we get
it from the payload context.
Cf https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run
2024-05-24 16:14:52 +02:00
Marc Durdin
989c769204
Merge pull request #11530 from keymanapp/docs/common/11369-emscripten-3.1.46
...
docs(common): update min emscripten version in docs to 3.1.46
2024-05-24 16:03:06 +07:00
Marc Durdin
0bd085880a
docs(common): update min emscripten version in docs to 3.1.46
...
The minimum version for Windows and macOS should be 3.1.46 because that
is known to work. See issue #9529 for reasons to avoid 3.1.45. Note:
Ubuntu still requires 3.1.44 for now.
Fixes : #11369
2024-05-24 14:52:31 +07:00
Marc Durdin
688d59f149
Merge pull request #11510 from keymanapp/fix/android/substring-index-length
...
fix(android/engine): Ignore updating invalid selections
2024-05-24 13:52:41 +07:00
Marc Durdin
84888c2390
Merge pull request #11512 from Nnyny/developer/contexthelp
...
chore(developer): add context/key-test
2024-05-24 13:51:59 +07:00
Marc Durdin
9813a823e4
Merge pull request #11509 from keymanapp/fix/web/wtr-flag-passing
...
fix(web): properly pass test-runner verbose-logging flag
2024-05-24 13:47:49 +07:00
Eberhard Beilharz
556b0ce368
Merge pull request #11517 from keymanapp/fix/linux/apiverification
...
fix(linux): Pass artifacts key to API verification GHA
2024-05-24 08:27:30 +02:00
Keyman Server
fad47b1f57
Merge pull request #11528 from keymanapp/auto/version-master-18.0.44
...
auto: increment master version to 18.0.44
2024-05-23 22:59:04 -07:00
Keyman Build Agent
36cbe0b81b
auto: increment master version to 18.0.44
2024-05-24 01:58:20 -04:00
Marc Durdin
1df620b577
Merge pull request #11524 from keymanapp/fix/windows/oem-build-sh
...
fix(windows): add FirstVoices Keyboards build to Windows release build
2024-05-24 12:22:11 +07:00
Steven R. Loomis
c39040fcbe
Merge branch 'master' into chore/common/10183-unicode-version
2024-05-23 22:20:11 -05:00
Steven R. Loomis
e48f6c39e1
test(core): update per review comments
...
Fixes : #10183
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-05-23 22:19:36 -05:00
rc-swag
b558c2b57c
Merge pull request #11521 from keymanapp/chore/windows/4038/clean-up-alpa-task
...
chore(windows): remove schedule task clean up introduced in 15.0 Alpha
2024-05-24 13:05:15 +10:00
Darcy Wong
1e2507b21a
Merge pull request #11522 from keymanapp/fix/oem/fv/revert-gradle
...
fix(android): Revert Sentry version for FV Android
2024-05-24 10:02:56 +07:00
Marc Durdin
0404aa5db2
chore(common): update labels to include change, style
...
* Updates supported labels and documentation relating to `change` and
`style` commit types
* Adds `core/` label
* Reorders various lists alphabetically
2024-05-24 09:43:10 +07:00
Marc Durdin
3d43959cd7
fix(windows): add FV build to Windows release build
...
Relates to #11461 .
The FV build is now a part of the Windows publish build. At the same
time, addresses a number of typos in the build script, which had not
been tested because it was not linked to the Windows build.
2024-05-24 09:16:02 +07:00
Darcy Wong
aeac9377b5
fix(oem/firstvoices/android): Revert Sentry version
2024-05-24 07:43:33 +07:00
rc-swag
080f265f84
chore(windows): remove cleanup-alpha-tasks
...
Remove the CleanupAlphaTasks that was specific to task
schedules created it for 15.0 alpha. Scheduled tasks naming
was changed to include a user name in the task. The clean up
function was to make sure the previous named tasks were removed.
Now there should be no 15.0 alpha users it can be removed.
2024-05-24 09:55:01 +10:00
Steven R. Loomis
43cd828e9d
feat(core): change normalize_nfd() to use JS native call instead of ICU
...
- does not hit all ICU usage yet
#9467
2024-05-23 17:09:00 -05:00
Steven R. Loomis
d8b5c25954
chore(core): refactor to move most normalization calls into util_normalize.cpp
...
- fold ldml_utils.hpp into core_icu.h
- refactor to use km::core::util::normalize_nfd() functions where simple to do so
For #9467
2024-05-23 14:47:38 -05:00
Steven R. Loomis
f3a80f50a6
test(core): build fix for test_unicode
...
- incorporate change from #11483
Fixes : #10183
2024-05-23 11:26:16 -05:00
Steven R. Loomis
e5ee26aaea
fix(core): add a test to verify ICU and Unicode version
...
- load version data from node.js, Blocks.txt, and ICU4C
- support wasm: copy package.json, nodeversions.json and Blocks.txt into the keyboard area so that they can be mounted under wasm
also:
- rename 'fallback' macro to KMN_FALLBACK to not conflict with hedley in utfcodec.hpp
- fix ambiguous path type in tests
Fixes : #10183
2024-05-23 09:31:15 -05:00
Eberhard Beilharz
f95ee27288
fix(linux): Pass artifacts key to API verification GHA
2024-05-23 16:21:55 +02:00
sgschantz
ab98086003
fix(mac): adopt unified logging APIs
...
remove all references to NSLog
adjust log level for some calls to os_log
Fixes #10997
2024-05-23 15:50:50 +07:00