Commit graph

9951 commits

Author SHA1 Message Date
jahorton
8d5b70cd77 feat(common/models): transformToSuggestion unit test 2020-10-06 10:39:32 +07:00
jahorton
95e5ce47bf feat(common/models): quote behavior unit tests 2020-10-06 10:08:16 +07:00
jahorton
07067227bd refactor(common/models): centralizes quotation logic, defs 2020-10-06 09:06:00 +07:00
jahorton
b8f286a736 chore(common/models): Merge branch 'master' into refactor/common/models/suggestion-and-keep-init 2020-10-06 08:13:39 +07:00
Keyman Server
12ad5914c3
Merge pull request #3660 from keymanapp/auto/version-master-14.0.155
auto: increment master version to 14.0.155
2020-10-06 05:01:42 +11:00
Keyman Build Agent
b4a809f7d7 auto: increment master version to 14.0.155 2020-10-05 14:00:56 -04:00
Marc Durdin
c9634d04e1
Merge pull request #3653 from keymanapp/chore/tweak-prepare-commit-msg
chore: exclude parens if no scope in commit msg
2020-10-05 14:09:09 +11:00
Marc Durdin
ee52b40307 chore: exclude parens if no scope in commit msg
If no scope is found in the branch name, then don't include the
parentheses around the scope, as this breaks automatic merge messages
and the parentheses are unnecessary.
2020-10-05 13:59:32 +11:00
Marc Durdin
0275f13e6c
Merge pull request #3649 from keymanapp/fix/engine/coverity-keyman32
fix(windows): coverity reports for keyman32
2020-10-05 13:47:08 +11:00
Marc Durdin
1d4307b2e9
Merge pull request #3642 from keymanapp/fix/engine/coverity-kmtip
fix(windows): coverity reports for kmtip
2020-10-05 13:46:59 +11:00
Marc Durdin
c83eb6f727
Merge pull request #3641 from keymanapp/fix/engine/coverity-mcompile
fix(windows): coverity reports for mcompile
2020-10-05 13:46:49 +11:00
Marc Durdin
69b781561d
Merge pull request #3640 from keymanapp/fix/developer/coverity-compiler.cpp
fix(developer): coverity reports for compiler
2020-10-05 13:46:42 +11:00
Marc Durdin
dc01449aa5
Merge pull request #3638 from keymanapp/fix/windows/3561-upgrading-disabled-keyboards
fix(windows): upgrading disabled keyboards
2020-10-05 13:46:27 +11:00
Marc Durdin
51d5feecc3
Merge pull request #3637 from keymanapp/fix/windows/3561-upgrading-transitional-profiles-2
fix(windows): Upgrading keyboards with transient profiles
2020-10-05 13:46:16 +11:00
Marc Durdin
41fb5296e4
Update windows/src/developer/kmcmpdll/Compiler.cpp
additional braces

Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2020-10-05 13:07:39 +11:00
Marc Durdin
7f70c14b2a fix(windows): Cast HANDLE types using PtrToInt 2020-10-05 09:30:55 +11:00
Keyman Server
1937ac80b4
Merge pull request #3652 from keymanapp/auto/version-master-14.0.154
auto: increment master version to 14.0.154
2020-10-03 04:01:33 +10:00
Keyman Build Agent
3d00a2cbda auto: increment master version to 14.0.154 2020-10-02 14:00:51 -04:00
Marc Durdin
0406cb1381 fix(windows): coverity reports for keyman32 2020-10-02 14:54:43 +10:00
Darcy Wong
08d3360bce
Merge pull request #3648 from keymanapp/fix/android/switch-keyboard-in-search
fix(android/app): Switch system keyboard in KMPBrowserActivity
2020-10-02 11:38:57 +07:00
Darcy Wong
0f9f7ec90d fix(android/app): Switch system keyboard in KMPBrowserActivity 2020-10-02 10:55:58 +07:00
jahorton
cbf56266d5 change(common/core/web): nomenclature shift - accept > apply 2020-10-02 10:17:10 +07:00
Darcy Wong
f512dd557d
Merge pull request #3646 from keymanapp/dependabot/npm_and_yarn/resources/build/version/actions/core-1.2.6
chore(deps): bump @actions/core from 1.2.2 to 1.2.6 in /resources/build/version
2020-10-02 09:04:41 +07:00
Marc Durdin
50ad8335ef
Apply suggestions from code review
Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2020-10-02 09:18:49 +10:00
dependabot[bot]
f63831374f
chore(deps): bump @actions/core in /resources/build/version
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.2 to 1.2.6.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-01 17:29:43 +00:00
jahorton
a8ebdaee1b docs(common/models): adds doc for important assumption 2020-10-01 12:41:55 +07:00
jahorton
b1c44877f6 docs(common/models): restores comment 2020-10-01 12:34:38 +07:00
jahorton
e5c37f7afc refactor(common/models): centralizes suggestion & keep inits 2020-10-01 12:32:10 +07:00
Keyman Server
b4deec3927
Merge pull request #3643 from keymanapp/auto/version-master-14.0.153
auto: increment master version to 14.0.153
2020-10-01 04:02:36 +10:00
Keyman Build Agent
e2d5ae31eb auto: increment master version to 14.0.153 2020-09-30 14:01:54 -04:00
Marc Durdin
f691946f1c fix(windows): coverity reports for kmtip 2020-09-30 17:20:36 +10:00
Marc Durdin
146dd0acc5 fix: coverity reports for mcompile 2020-09-30 14:53:47 +10:00
Marc Durdin
1df49317c9 fix(windows): coverity reports for mcompile 2020-09-30 14:50:22 +10:00
Joshua Horton
14e6bf6cb9
Merge pull request #3623 from keymanapp/feat/ios/engine/mark-preinstalled-resources
fix(ios/engine): package installation language-picker improvements
2020-09-30 11:40:14 +07:00
Marc Durdin
508441ebf4 fix(developer): coverity reports for compiler
Addresses Coverity reports for compiler.cpp and other files.

Note that whitespace was reformatted on this PR. You may want to compare
with ignore-whitespace.
2020-09-30 14:20:41 +10:00
Marc Durdin
dd4ac89468 fix(developer): coverity issues for compiler.cpp
CID 309307 through 309313, 309318, 309321, 309371, 309388.
2020-09-30 11:58:28 +10:00
Keyman Server
a9aaadcde2
Merge pull request #3639 from keymanapp/auto/version-master-14.0.152
auto: increment master version to 14.0.152
2020-09-30 04:01:39 +10:00
Keyman Build Agent
8da7b1943a auto: increment master version to 14.0.152 2020-09-29 14:00:55 -04:00
Darcy Wong
985307e878
Merge pull request #3624 from keymanapp/fix/android/undefined-package-id
fix(android/engine): Fix undetermined lexical model package ID
2020-09-29 19:51:22 +07:00
Marc Durdin
ca103155bf
Merge pull request #3635 from keymanapp/fix/windows/3561-upgrading-transitional-profiles
fix(windows): upgrading transitional profiles
2020-09-29 20:47:41 +10:00
Marc Durdin
4654b5485a
Merge pull request #3634 from keymanapp/fix/windows/3633-invalid-pointer-firstrun
fix(windows): Buffer overrun in firstrun
2020-09-29 20:47:33 +10:00
Marc Durdin
827ea6c386 fix(windows): upgrading disabled keyboards
Fixes #3561.

Resolves issues with upgrading disabled keyboards, and fixes a secondary
issue where Windows was giving us invalid LANGIDs for locales, which was
causing trouble with transient LANGIDs.
2020-09-29 20:25:10 +10:00
Marc Durdin
7ad11ca9d2 fix(windows): Upgrading keyboards with transient profiles
Relates to #3561.

If a keyboard has languages installed under one of the four transient
language profiles, then we need to jump through some additional hoops to
upgrade it to the 14.0 model.

This does not yet handle all scenarios around installed but non-loaded
keyboards.
2020-09-29 14:25:57 +10:00
Marc Durdin
301a76c88a fix(windows): upgrading transitional profiles
Relates to #3561.

If a keyboard is installed for a transitional profile but another
keyboard is already installed for that profile, then Keyman would
crash, expecting the transitional profile to be missing.
2020-09-29 09:08:47 +10:00
Marc Durdin
daa65dcd2e fix(windows): Buffer overrun in firstrun
Fixes #3633.

Memory allocation was half its required size due to missing
`sizeof(Char)` calculation.

Also added extra tags to Sentry events for command line and executable,
which made tracing this issue so much easier.
2020-09-29 09:04:07 +10:00
Keyman Server
aa3b456c5f
Merge pull request #3630 from keymanapp/auto/version-master-14.0.151
auto: increment master version to 14.0.151
2020-09-29 04:01:42 +10:00
Keyman Build Agent
c6265b4301 auto: increment master version to 14.0.151 2020-09-28 14:01:03 -04:00
Darcy Wong
a1e70c0345
Merge pull request #3629 from keymanapp/fix/android/check-copy-kmp-asset
fix(android/app): Only copy asset .kmp file if it doesn't exist
2020-09-28 16:11:50 +07:00
Darcy Wong
c4178b1d26 fix(android/app): Only copy asset .kmp file if it doesn't exist
Fixes #3521

Update `KMManager.copyAssets` so asset kmp files only get copied if they don't exist. This avoids unzipping the packages on every startup.
2020-09-28 14:30:46 +07:00
Joshua Horton
a8fd505a62
Merge pull request #3622 from keymanapp/feat/ios/engine/package-welcome-view
feat(ios/engine): Utilizes packages' welcome pages
2020-09-28 12:44:02 +07:00