Commit graph

33096 commits

Author SHA1 Message Date
Marc Durdin
70f7c1634d fix(developer): kvks file reader needs to handle bitmaps
Fixes #9159.

If a key contains a bitmap, then ignore the text for the key.
2023-07-04 14:46:51 +07:00
Marc Durdin
4d64cb2d38 fix(developer): touch layout was not converting all special keycaps
Fixes #9161.

kmw-compiler was converting only the first key cap with `*special*`
caption, rather than all key caps.
2023-07-04 14:44:42 +07:00
Marc Durdin
d2acfdec5c fix(developer): improve kmcmplib/kmw compiler performance
Fixes #9154.

Improves performance in both kmcmplib and in kmc-kmn/kmw-compiler. After
these changes are applied, vietnamese_telex keyboard builds in around 6
seconds on my machine (down from over 2 minutes). This is certainly only
the surface of performance improvements we could make.

Addresses excessive memory reallocations in kmcmplib, by reallocating
store and key arrays in large chunks of 100 items rather than
reallocating on each new item added. This resulted in a 250x speed-up on
functions such as `AddStore` in WASM build.

Some careful modulus arithmetic was needed for resizing the key array,
which can be grown in larger increments.

Resolved excessive zeroing out of destination buffer in u16ncpy, which
was being called with an 8kb destination buffer on every line of the
file.

In the kmw side, vast majority of the performance cost was in copying of
buffers while loading a .kmx into memory, rather than creating views
into the memory. Essentially replaced this pattern:

```
return this.rString.fromBuffer(source.slice(offset));
```

with:

```
const data = new Uint8Array(source.buffer, source.byteOffset + offset);
return this.rString.fromBuffer(data);
```
2023-07-04 14:36:25 +07:00
Marc Durdin
3a54d9b7f4 fix(developer): kmc-kmn/kmw should strip \r from inline html
Fixes #9157.

Matching kmcomp behaviour once more.
2023-07-04 14:31:01 +07:00
Marc Durdin
9dacaaac4e fix(developer): kmc-kmn/kmw should add/delete certain fields in touch layout when writing
Fixes #9160.

To match the behaviour of kmcomp, kmc should add/delete the following
fields when writing out a kmw touch layout:

* `platform.displayUnderlying` flag is always emitted by kmcomp, so kmc
  should always emit it too.
* `platform.font` and `platform.fontsize` should be eliminated if empty
  string
* `key.id` should be eliminated if empty string
2023-07-04 14:29:19 +07:00
Eberhard Beilharz
038cf98db1
Merge pull request #9155 from keymanapp/fix/linux/packaginggha
fix(linux): Another attempt to fix packaging GHA
2023-07-04 08:36:22 +02:00
Joshua A. Horton
e2b5d69d91 docs(ios): adds script docs to ios/README.md, updates, drops some ancient bits 2023-07-04 12:04:42 +07:00
Joshua A. Horton
6b5228788d fix(ios): sample apps support for parent script option 2023-07-04 08:16:02 +07:00
rc-swag
3565b35b5b
Merge pull request #9149 from keymanapp/fix/windows/9093-resize-change-hot-key-lbl
fix(windows): adds an extra row for Change Hotkey text label
2023-07-04 10:42:52 +10:00
Steven R. Loomis
0f0c1e5e61 feat(common): preflighting on uset 🙀
- allow uset to preflight (calculate # of ranges)

For: #7377
2023-07-03 18:48:48 -05:00
Steven R. Loomis
ebcccbe0ef feat(core): rearrange elem flags 🙀
- per review comments, make the elem flags clearer

For: #7377
2023-07-03 18:20:59 -05:00
Steven R. Loomis
a6dcf4dfce
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-07-03 18:20:20 -05:00
Steven R. Loomis
a25d3819d1 Merge remote-tracking branch 'upstream/master' into feat/developer-7377-reorder-uset 2023-07-03 18:09:22 -05:00
Steven R. Loomis
7cf83d2947
Merge pull request #9141 from keymanapp/feat/common-7377-segment-ordr-epic-ldml
feat(common): add segmenter for element strings 🙀
2023-07-03 18:08:41 -05:00
Steven R. Loomis
3ecf8da917
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-07-03 18:08:25 -05:00
Eberhard Beilharz
32a77eb2c2
fix(linux): Another attempt to fix packaging GHA
This works around the permission problem we got with the previous
commit.
2023-07-03 20:02:22 +02:00
Sabine
d567cbdebd feat(linux): mcompile use remove unneccessary function 2023-07-03 12:49:24 +02:00
Sabine
762827c96d feat(linux): mcompile use #ifdef around main 2023-07-03 12:48:02 +02:00
Marc Durdin
4354cd691a
Merge pull request #9153 from keymanapp/fix/developer/9152-kvk-extension
fix(developer): strip .kvk extension 🗜
2023-07-03 18:50:58 +10:00
Joshua A. Horton
b5d0d7d5f8 change(ios): adds targets to primary build.sh 2023-07-03 15:03:55 +07:00
Marc Durdin
2cc2106bbf
Merge pull request #9151 from keymanapp/fix/developer/kmc-bugs-9112-9140-9145-9146
fix(developer): another omnibus set of bug fixes for kmc 🗜
2023-07-03 17:42:33 +10:00
Marc Durdin
3d86e608f4 fix(developer): strip .kvk extension
Fixes #9152.
2023-07-03 12:47:22 +07:00
Joshua A. Horton
0745407f6c fix(ios): sample build issue 2023-07-03 09:43:55 +07:00
Marc Durdin
92c8c6497e fix(developer): improve warnings around keyboard version matching
Fixes #9145.

* `WARN_KeyboardVersionsDoNotMatch` is now only raised when
  `FollowKeyboardVersion` is set.
* `WARN_KeyboardVersionsDoNotMatchPackageVersion` has been removed,
  because it did not really make sense; if 'FollowKeyboardVersion' is
  set, it could not be raised, and otherwise, the author may wish to
  have separate keyboard + package versions anyway.
* Note that the 0x0013 compiler message allocation for
  `WARN_KeyboardVersionsDoNotMatchPackageVersion` has been left alone;
  as this was only used in pre-release, we can probably re-task it in
  the future.
2023-07-03 09:40:09 +07:00
Marc Durdin
9a1b87824a fix(developer): split keyboard and model language metadata tests
Fixes #9146.

For model packages, 304016 (ERROR_ModelMustHaveAtLeastOneLanguage)
remains as an error (this is a new error for kmc, kmcomp did not
validate model metadata). For keyboard packages, a new warning is
introduced to match the existing kmcomp behaviour, 20401B
(WARN_KeyboardShouldHaveAtLeastOneLanguage).
2023-07-03 09:31:29 +07:00
Marc Durdin
be0b2ae583 fix(developer): allow kmcmplib memory usage to grow
Fixes #9112.

Note that this does not address any performance concerns which are a
much bigger issue; it just avoids the crash.
2023-07-03 09:27:53 +07:00
Marc Durdin
7aede78707 fix(developer): compiler needs to support loading .kvk files
Fixes #9150.

Legacy .kmn keyboards can refer to a binary .kvk file. kmc needs to be
able to load these as well.

Note: there was a short period of time in which .kvk files were either
source or binary format. We moved to .kvk always being binary, and .kvks
always being source (xml), and so IMO we don't need to include support
for mismatched file formats.
2023-07-03 09:25:10 +07:00
Marc Durdin
33affc660f fix(common): legacy .kpj schema
Fixes #9140.
Fixes #9148.

Keyman Developer 9.0 .kpj files included a lot of additional state
metadata. We need a schema which validates these files, as they are
otherwise valid to load (we'll never save them any more). Rather than
add all the extra metadata to what is otherwise a fairly clean schema,
we'll provide a legacy .schema.json.

In the future, we may be able to merge these schemas, as we move towards
the .kpj 2.0 format which doesn't list files. Ideally, all three formats
(Keyman Developer 9.0 schema, call it legacy, 1.0 schema for Keyman
Developer 10.0+ which has Options and Files listed, 2.0 schema for
capturing just project settings for a folder) will be supported by a
single schema file.
2023-07-03 09:06:03 +07:00
Joshua A. Horton
b65a80f6f9 fix(ios): lots more fixes per PR review 2023-07-03 09:01:23 +07:00
Ross
1f0f088f9c fix(windows): a an extra rows for chng key lbl
Add an extra row for change text label to accommodate the
German and Kannada translations
2023-07-03 11:34:46 +10:00
Steven R. Loomis
88650e2085 feat(developer): uset in element string 🙀
- fix uset builder and other missing uset parts
- basic.xml passes
- update to constants

Fixes: #7377
2023-06-30 17:27:04 -05:00
Steven R. Loomis
79082ee3ab
Merge branch 'feat/common-7377-segment-ordr-epic-ldml' into feat/developer-7377-reorder-uset 2023-06-30 15:59:50 -05:00
Steven R. Loomis
e73d059fa9
Merge branch 'master' into feat/common-7377-segment-ordr-epic-ldml 2023-06-30 15:57:47 -05:00
Steven R. Loomis
5d5b61cd0a feat(developer): uset in element string 🙀
- update element string constructors to support UnicodeString and the segmented array from ElementParser
- update compiler machinery to pass USetParser in the DependencySections
- test cases

#7377
2023-06-30 15:56:45 -05:00
Steven R. Loomis
067c0b2f67 feat(common): unescaper / element updates for uset 🙀
- add unescaper for quad string (\u0127)

#7377
2023-06-30 15:50:38 -05:00
Keyman Server
7b71e61b8a
Merge pull request #9143 from keymanapp/auto/version-master-17.0.133
auto: increment master version to 17.0.133
2023-07-01 01:03:16 +07:00
Keyman Build Agent
c4ee4369cc auto: increment master version to 17.0.133 2023-06-30 14:02:37 -04:00
Eberhard Beilharz
8752c3c64d
Merge pull request #9142 from keymanapp/fix/linux/gha
fix(linux): Fix packaging GHA
2023-06-30 18:05:39 +02:00
Eberhard Beilharz
4bd0b40de6
fix(linux): Fix packaging GHA
The previous version of gha-ubuntu-packaging was faulty.
2023-06-30 17:56:28 +02:00
Steven R. Loomis
ceaf13a130
Merge branch 'master' into feat/common-7377-segment-ordr-epic-ldml 2023-06-30 08:52:01 -05:00
Steven R. Loomis
3d6af245de feat(common): add segmenter for element strings 🙀
- detect and reject nested square brackets, for now
- implement segmentation of reorder element strings,
  including type identification (escape, codepoint, uset)
- tests

For #7377
2023-06-30 08:49:07 -05:00
Eberhard Beilharz
f13330702c
Merge pull request #9123 from keymanapp/fix/linux/9024_dependencies
fix(linux): Fix GHA package builds for non-Jammy dists
2023-06-30 10:07:59 +02:00
Joshua A. Horton
3619180720 chore(ios): a bit of suggested trim 2023-06-30 12:58:35 +07:00
Joshua A. Horton
79c4fabf93 fix(ios): should not double-absolute a path (again) 2023-06-30 12:57:25 +07:00
Joshua A. Horton
d9bf6c996b fix(ios): should not double-absolute a path 2023-06-30 12:56:59 +07:00
Joshua A. Horton
30cc48f29e chore(ios): skipped one in a file I meant to complete 2023-06-30 12:56:14 +07:00
Joshua A. Horton
ab237cf3fc chore(ios): addresses some PR review concerns 2023-06-30 12:54:22 +07:00
Joshua Horton
2a62e3cecf
Merge pull request #9128 from keymanapp/chore/web/rework-touchpath-turtle
chore(web): touchpath-turtle rework 🐵
2023-06-30 11:58:21 +07:00
Joshua Horton
8f8d31c265
Merge pull request #9127 from keymanapp/refactor/web/headless-input-tracking
refactor(web): all gesture-oriented input control flows now have a headless form 🐵
2023-06-30 11:58:12 +07:00
Joshua Horton
951ef90157
Merge pull request #9126 from keymanapp/chore/web/sample-gesture-recording-end
fix(web): touchpath recordings always sample end of path, even when stationary 🐵
2023-06-30 11:58:05 +07:00