Commit graph

11407 commits

Author SHA1 Message Date
Darcy Wong
8a176dcb8f fix(android/engine): Add help method to localize Toast notifications 2021-03-04 14:57:58 +07:00
Darcy Wong
bdb4755ed9 chore(android/engine): Remove unused string
Cleaning up unused string failed_to_access_downloaded_file
2021-03-04 14:57:12 +07:00
Keyman Server
194b6cd054
Merge pull request #4580 from keymanapp/auto/version-beta-14.0.252
auto: increment beta version to 14.0.252
2021-03-04 05:03:42 +11:00
Keyman Build Agent
08257cf633 auto: increment beta version to 14.0.252 2021-03-03 13:02:52 -05:00
Eberhard Beilharz
a5d0e7cdae
Merge pull request #4569 from keymanapp/feat/linux/issue-4542
chore(common/core/desktop): write debug output to console
2021-03-03 14:54:59 +01:00
Darcy Wong
d1e21fca7c
Merge pull request #4578 from keymanapp/common/crowdin-de
chore(common): Update crowdin files for `de`
2021-03-03 16:38:24 +07:00
Darcy Wong
f442dee615 chore(windows): Check in crowdin files for de 2021-03-03 14:47:43 +07:00
Darcy Wong
2c6bff4f43 chore(linux): Check in crowdin files for de 2021-03-03 14:47:16 +07:00
Darcy Wong
f1133d0fc9 chore(android): Check in crowdin files for de 2021-03-03 14:45:53 +07:00
Joshua Horton
4ab75cef6d
Merge pull request #4573 from keymanapp/chore/ios/4339-progress-feedback
chore(ios): better visual feedback for keyboard search during poor internet connectivity
2021-03-03 14:35:25 +07:00
jahorton
d2a7012716 fix(ios): handling of cases with no welcome.htm 2021-03-03 13:21:49 +07:00
jahorton
0f7f2739f5 fix(ios): better ux for net-delayed package installations, kbd display mgmt 2021-03-03 13:01:49 +07:00
jahorton
39064e1935 feat(ios): adds a progress bar to search during page loads 2021-03-03 10:17:15 +07:00
Marc Durdin
6180b01a31
Merge pull request #4562 from keymanapp/fix/developer/3337-track-modified-state-wordlist-editor
fix(developer): track modified state in wordlist editor better
2021-03-03 10:48:21 +11:00
Marc Durdin
726e93bcc3
Merge pull request #4559 from keymanapp/feat/developer/2556-isRTL-support-for-lexical-models
feat(developer): isRTL support for lexical model editor
2021-03-03 10:47:34 +11:00
Marc Durdin
290d21f4c6 chore(developer): address review feedback 2021-03-03 10:45:52 +11:00
Marc Durdin
e4d09ece72
Merge pull request #4564 from keymanapp/fix/developer/3011-osk-import-avoid-blank-keys
fix(developer): Avoid blank keys when importing KMX to KVKS
2021-03-03 09:28:29 +11:00
Marc Durdin
16e5b9c358
Merge pull request #4563 from keymanapp/fix/developer/2998-package-compile-require-langugae-tag
fix(developer): require language tag when compiling keyboard package
2021-03-03 09:28:07 +11:00
Marc Durdin
a0734f153b
Merge pull request #4552 from keymanapp/fix/developer/2740-touch-editor-importing-osk-right-alt-layer
fix(developer): touch layout osk import handling of multiple modifiers
2021-03-03 09:27:11 +11:00
Marc Durdin
7856932e2b
Merge pull request #4548 from keymanapp/fix/developer/3199-model-package-compiler-schema-conformance
fix(developer): schema conformance for model package compiler
2021-03-03 09:26:28 +11:00
Marc Durdin
ef0961fd1c
Merge pull request #4547 from keymanapp/fix/developer/4423-named-constants-cleanup
fix(developer): Improve stability of named code constants
2021-03-03 09:26:17 +11:00
Eberhard Beilharz
958fb3ac1f
docs(common): More readme improvements 2021-03-02 19:16:19 +01:00
Keyman Server
c4d74d8fdb
Merge pull request #4570 from keymanapp/auto/version-beta-14.0.251
auto: increment beta version to 14.0.251
2021-03-03 05:01:55 +11:00
Keyman Build Agent
2f5c001c61 auto: increment beta version to 14.0.251 2021-03-02 13:01:09 -05:00
Eberhard Beilharz
268a42cba4
chore(common): Fix Windows build 2021-03-02 17:37:31 +01:00
Eberhard Beilharz
2421af506e
chore(common): write debug output to console
We have a `g_debug_ToConsole` variable. However, so far this was
always set to true and output to `syslog`. This change modifies
the default to `false`, and in that case logs to `syslog`. If
`g_debug_ToConsole` is true we no output to the console.

When running the KMX unit tests we set `g_debug_ToConsole` to true.
2021-03-02 16:55:22 +01:00
Eberhard Beilharz
2593c7873f
docs(common): Add readme for unit tests 2021-03-02 16:55:22 +01:00
Eberhard Beilharz
64f9f9297a
chore(linux): Improve readme
Also ignore some more generated files.
2021-03-02 16:55:22 +01:00
Darcy Wong
0801d69bbc
Merge pull request #4565 from keymanapp/fix/ios-help-path
fix(common/resources): Fix help.keyman.com path for CI
2021-03-02 09:58:28 +07:00
Marc Durdin
84c0202d85 chore(developer): tweak casing 2021-03-02 13:27:17 +11:00
Marc Durdin
85b9e04345 chore(developer): address review comment 2021-03-02 13:26:40 +11:00
Darcy Wong
b10ae8b0d4 fix(common/resources): Fix help.keyman.com path for CI 2021-03-02 08:41:44 +07:00
Marc Durdin
36f5788651 fix(developer): Avoid blank keys when importing KMX to KVKS
Fixes #3011.

Keys that have only whitespace will no longer generate separate key data
for the on screen keyboard, as they have no visual presentation anyway.
2021-03-02 12:16:09 +11:00
Marc Durdin
1f87c7608c fix(developer): require language tag when compiling keyboard package
Fixes #2998.

Three parts to this:

* The package compiler will now give a warning if a keyboard in a
  package does not contain any language metadata.

* Removed old canonicalization check during compile which is now handled
  better in `TPackageInfoRefreshKeyboards`.

* Reduced non-canonical BCP 47 tag warnings in
  `TPackageInfoRefreshKeyboards` to "info" so they do not block the
  build.

Point 3 above is one part of the outcome of our BCP 47 discussion at:
https://docs.google.com/document/d/1N5CkTX7tlLlmUB9Mbd-LblY1ch1e642XxlTasC_WE_Q/edit#heading=h.fiy983iliay5
2021-03-02 11:59:12 +11:00
Marc Durdin
7ea7ba0e11 fix(developer): track modified state in wordlist editor better
Fixes #3337.

In some situations, the wordlist editor was not tracking modified state
100% correctly, which meant that edits could be lost. This resolves that
by simplifying the modification state tracking.
2021-03-02 09:27:18 +11:00
Keyman Server
6bb00124ee
Merge pull request #4561 from keymanapp/auto/version-beta-14.0.250
auto: increment beta version to 14.0.250
2021-03-02 05:02:12 +11:00
Keyman Build Agent
3a2e4741bb auto: increment beta version to 14.0.250 2021-03-01 13:01:24 -05:00
Marc Durdin
eb713ec274 feat(developer): isRTL support for lexical model editor
Fixes #2556.

This adds support for `isRTL`, `insertAfterWord`, and
`quotesForKeepSuggestions` punctuation options for lexical models, both
in the parsing and in the user interface. A number of options are
presented to the user for the quotes and word breaking characters.

The parser continues to be a regex-based typescriptish parser. Expect it
to be gross. It's too big a job to do properly right now, so it is
somewhat limited and will bail if it finds structures it can't
understand.

I would hope to use something a bit smarter in the future to interface
with the editor. Probably when we are actually fully web-based and can
depend on a Typescript compiler directly.

Please don't get mad at me! 😟😟😟
2021-03-01 21:46:51 +11:00
Darcy Wong
a249a89e9a
Merge pull request #4550 from keymanapp/chore/ios/custom-dictionary-help
chore(ios/app): Adjust help titles for installing custom dictionaries
2021-03-01 14:09:28 +07:00
Marc Durdin
1fcfefa3cf fix(developer): support for smp names 2021-03-01 16:05:17 +11:00
Marc Durdin
3f54c81461 fix(developer): touch layout osk import handling of multiple modifiers
Fixes #2740.

The definitions for several of the combined modifiers was incorrect,
which led to a mismatch when attempting to import those layers from a
visual keyboard into the touch layout editor.
2021-03-01 15:44:55 +11:00
Darcy Wong
9ce0d72267 chore(ios/app): Adjust help titles for installing custom dictionaries 2021-03-01 10:02:10 +07:00
Joshua Horton
d2278c6494
Merge pull request #4540 from keymanapp/fix/web/1125-ff-keymaps-with-mnemonics
fix(web): mnemonic keystrokes w FF keymapping
2021-03-01 08:17:01 +07:00
Marc Durdin
2f2f998da6 fix(developer): schema conformance for model package compiler
Fixes #3199.

Ensures that the model package compiler passes schema validation for
kmp.json. Three problems were corrected:

1. `followKeyboardVersion` is a source-only property; it should not be
   in deployable kmp.json.
2. `copyLocation` should have been a number not a string (in XML
   everything is a string... but JSON has more control here)
3. `fileType` is a source-only property; it also should not be in
   deployable kmp.json.

I have checked that the resulting files validate against the package
kmp.json schema version 1.1.0 defined at
https://github.com/keymanapp/api.keyman.com/blob/master/schemas/package/1.1.0/package.json.

None of these fixes should impact the use of these packages in target
apps. `followKeyboardVersion` and `fileType` are used only in the source
at package development time, and `copyLocation` is unused (and should be
eliminated from Keyman altogether in the future).
2021-03-01 10:57:49 +11:00
Marc Durdin
17c94770ef chore(windows): update test project 2021-03-01 10:34:30 +11:00
Marc Durdin
26b1d777f7 fix(developer): Improve stability of named code constants
Fixes #4423.

Using a named character constant with a store name that included
characters outside ascii could cause kmcmpdll to crash with an assertion
failure.

This fix allows store names defined in the .kmn file to use characters
outside ascii.

Note that more work needs to be done on which characters are acceptable
to use, as this is somewhat implementation-specific according to the C++
specification for `iswalpha`.

Added a test case to verify various named code constant examples.

Also removes dead code for `IsCJKUnifiedIdeograph` as this was never
used and somewhat pointless in any case.

NamedCodeConstants.cpp could stand to be rewritten using `std::map` or
equivalent. Current implementation is pretty icky.
2021-03-01 10:25:06 +11:00
Keyman Server
aaaddb597c
Merge pull request #4546 from keymanapp/auto/version-beta-14.0.249
auto: increment beta version to 14.0.249
2021-02-27 05:03:29 +11:00
Keyman Build Agent
eabc2e4f3c auto: increment beta version to 14.0.249 2021-02-26 13:02:44 -05:00
Marc Durdin
d4bf9f910e
Merge pull request #4535 from keymanapp/fix/windows/4445-upgrade-of-14-re-registered-all-tips
fix(windows): prevent re-registration of TIPs on 14.0 upgrade
2021-02-26 19:56:48 +11:00
Marc Durdin
d496d266fa
Merge pull request #4378 from keymanapp/fix/windows/4289-altgr-refresh-on-64-bit
fix(windows): Refresh settings on 64-bit apps
2021-02-26 19:55:28 +11:00