Commit graph

16324 commits

Author SHA1 Message Date
Keyman Build Agent
5762cd6f68 auto: increment master version to 16.0.76 2022-10-05 14:01:30 -04:00
Joshua Horton
a8d0b540ce
Merge pull request #7405 from keymanapp/chore/common/builder-trap-chained-exit
chore(common): builder script maintenance
2022-10-05 15:31:41 +07:00
Joshua A. Horton
7f60cdab71 fix(common): builder unit-test script chmod+x 2022-10-05 14:33:07 +07:00
Joshua A. Horton
cc4f4cb56c chore(common): builder script maintenance 2022-10-05 08:54:11 +07:00
Keyman Server
dd1d166e14
Merge pull request #7399 from keymanapp/auto/version-master-16.0.75
auto: increment master version to 16.0.75
2022-10-05 05:02:30 +11:00
Keyman Build Agent
880c14fca0 auto: increment master version to 16.0.75 2022-10-04 14:01:50 -04:00
Darcy Wong
3a3aa806a6
Merge pull request #7388 from keymanapp/fix/android/no-basekey
fix(android/engine): Dismiss subkeys on multi-touch
2022-10-04 07:40:01 +07:00
Darcy Wong
6ce5e15137 Merge pull request #7390 from keymanapp/chore/android/add-toast-to-kmwlog
chore(android/engine): Display Toast notifications on Sentry errors
2022-10-04 07:24:38 +07:00
Keyman Server
aa87f50437
Merge pull request #7393 from keymanapp/auto/version-master-16.0.74
auto: increment master version to 16.0.74
2022-10-04 05:02:16 +11:00
Keyman Build Agent
364f5b52a9 auto: increment master version to 16.0.74 2022-10-03 14:01:39 -04:00
Darcy Wong
8bd0a6ed51 fix(android/engine): Display Toast notifications on exceptions 2022-10-03 14:42:56 +07:00
Darcy Wong
b0b2e72670 chore(android/engine): Update the displayed kmp filename in the Toast 2022-10-03 10:38:24 +07:00
Marc Durdin
61a058fcec
Merge pull request #7371 from keymanapp/fix/developer/7368-handle-invalid-kps-in-project-view
fix(developer): handle invalid kps xml when loading project view
2022-10-03 14:26:59 +11:00
Darcy Wong
f8f3fe1873 chore(android): Add Toast notifications to KMLog 2022-10-03 07:55:38 +07:00
Keyman Server
04bde69ab6
Merge pull request #7389 from keymanapp/auto/version-master-16.0.73
auto: increment master version to 16.0.73
2022-10-01 04:02:13 +10:00
Keyman Build Agent
d1f75f73e2 auto: increment master version to 16.0.73 2022-09-30 14:01:30 -04:00
Darcy Wong
4c1651baf4 fix(android/engine): Dismiss subkeys on multi-touch 2022-09-30 14:14:02 +07:00
Darcy Wong
6cfa06fa27
Merge pull request #7365 from keymanapp/chore/common/split-builder-utils
refactor(common): Split builder utilities to separate script
2022-09-30 07:07:05 +07:00
Darcy Wong
637bd7560c
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-09-30 07:06:10 +07:00
Darcy Wong
c21b6f5cf6
Merge pull request #7383 from keymanapp/fix/web/highlight-suggestion-crash
fix(web): Only unhighlight suggestion if there's a pending one
2022-09-30 06:38:26 +07:00
Keyman Server
6ba0486714
Merge pull request #7384 from keymanapp/auto/version-master-16.0.72
auto: increment master version to 16.0.72
2022-09-30 04:02:53 +10:00
Keyman Build Agent
8d92399c4b auto: increment master version to 16.0.72 2022-09-29 14:02:13 -04:00
Darcy Wong
afba43b898 fix(web): Only unhighlight suggestion if there's a pending one 2022-09-29 13:33:42 +07:00
Joshua Horton
a3dde68d52
Merge pull request #7345 from keymanapp/fix/common/web/mock-deadkey-handling
fix(common/web): mock deadkey handling after rules manipulating context 📴
2022-09-29 10:37:49 +07:00
Darcy Wong
f06578714e chore(common): Update standard example 2022-09-29 10:34:25 +07:00
Darcy Wong
0ee5055907 chore(common): Clarify assumption that THIS_SCRIPT has been set 2022-09-29 08:45:31 +07:00
Darcy Wong
32b002cf23
Merge pull request #7348 from keymanapp/fix/android/spacebar-caption-reload-osk
fix(web): Update spacebar caption when refreshing layout
2022-09-29 08:35:52 +07:00
Marc Durdin
687c8bae99
Merge pull request #7370 from keymanapp/fix/developer/7090-7091-use-path-backslash-format-for-parameters
fix(developer): ensure backslash in paths passed to kmcomp
2022-09-29 09:22:57 +10:00
Marc Durdin
d8f6a092b3
Merge pull request #7369 from keymanapp/fix/developer/7005-invalid-js-when-using-digits-in-stores
fix(developer): generate valid js when using unquoted digits in stores
2022-09-29 09:22:46 +10:00
Darcy Wong
86c740e708
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2022-09-28 19:48:07 +07:00
Marc Durdin
73e0a2e461 fix(developer): generate valid js when using unquoted digits in stores
Fixes #7005.

If a developer used single digit values in stores, unquoted (which is
not really the usual approach, but should work just fine for non-zero
values), the KMW compiler would emit invalid single-digit hexadecimal
escapes for them, e.g. `"\x1"` instead of `"\x01"`.

Sample code:

```
store(option) 1

if(option = 1) + 'a' > 'one'
if(option = 2) + 'a' > 'two'
+ '1' > set(option = 1)
+ '2' > set(option = 2)
```

It is not immediately obvious from this code, but the value `1` is
actually a character with value `'\x01'` or `U+0001`!

The more usual approach will not encounter this problem:

```
store(option) '1'

if(option = '1') + 'a' > 'one'
if(option = '2') + 'a' > 'two'
+ '1' > set(option = '1')
+ '2' > set(option = '2')
```

Note that the following is a compile error (due to internal use of
null terminated strings).

```
store(option) 0
```
2022-09-28 17:00:55 +10:00
Marc Durdin
f5b8effaae fix(developer): ensure backslash in paths passed to kmcomp
Fixes #7090.
Fixes #7091.

While kmcomp loads most files just fine when paths with forward slashes
are passed in, it fails to parse target path correctly when building one
file out of a project.

For example, if the user runs:

```
kmcomp.exe -t khmer_angkor.kmn release/k/khmer_angkor/khmer_angkor.kpj
```

Then the following error arises:

```
khmer_angkor.kps: Error: 0001 Validation error: The system cannot find the path specified.
khmer_angkor.kps: Failure: Package C:\Projects\keyman\keyboards\source\khmer_angkor.kps had validation errors.
```

This patch ensures all paths passed in as command-line parameters are
converted to backslashes, matching the expected Windows format. While I
only needed to fix the `FParamTarget` parameter in order to address the
reported issues, for consistency I applied the same fix to all input
paths.
2022-09-28 16:50:58 +10:00
Marc Durdin
50614fb088 fix(developer): handle invalid kps xml when loading project view
Fixes #7368.
2022-09-28 16:32:36 +10:00
Darcy Wong
06e31e5cfc chore(common): Update builder.inc.sh path 2022-09-28 12:57:01 +07:00
Darcy Wong
28ddfdb70a chore(common): Move builder.inc.sh up to resources/ 2022-09-28 12:56:43 +07:00
Darcy Wong
0645524022
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-09-28 12:56:16 +07:00
Darcy Wong
e021116aea chore(common): Add newline 2022-09-28 09:22:05 +07:00
Darcy Wong
ae892c10f7 chore(common): Resolve review comments 2022-09-28 09:09:24 +07:00
Darcy Wong
fcc4fdca61 chore(common): Add _builder_init 2022-09-28 09:09:09 +07:00
Darcy Wong
17435c310b chore(common): Add builder_die 2022-09-28 08:29:16 +07:00
Darcy Wong
824319d398 chore(common): Revert move of die to builder_die 2022-09-28 08:24:08 +07:00
Darcy Wong
dd07f1c333 refactor(common): Add _builder_findRepoRoot 2022-09-28 08:10:57 +07:00
Darcy Wong
f95e17483b refactor(common): Revert move of KEYMAN_ROOT to REPO_ROOT 2022-09-28 07:56:08 +07:00
Darcy Wong
d5df060e76 chore(common): Move KEYMAN_ROOT to REPO_ROOT 2022-09-27 15:23:32 +07:00
Darcy Wong
a31c8931f1 chore(common): Move die to builder_die 2022-09-27 15:18:48 +07:00
Darcy Wong
22767bd6be chore(common): Split builder portion of script 2022-09-27 14:43:14 +07:00
Joshua A. Horton
0bbc3e7375 chore(web): reverts accidental branch creep 2022-09-27 08:59:56 +07:00
Joshua Horton
fc7dfb9879
Merge pull request #7346 from keymanapp/chore/web/update-toolchain
chore(web): update Node dev-dependencies
2022-09-27 08:53:42 +07:00
Keyman Server
497a8613db
Merge pull request #7356 from keymanapp/auto/version-master-16.0.71
auto: increment master version to 16.0.71
2022-09-27 04:02:24 +10:00
Keyman Build Agent
ee86250eec auto: increment master version to 16.0.71 2022-09-26 14:01:38 -04:00