Commit graph

16274 commits

Author SHA1 Message Date
Darcy Wong
32b002cf23
Merge pull request #7348 from keymanapp/fix/android/spacebar-caption-reload-osk
fix(web): Update spacebar caption when refreshing layout
2022-09-29 08:35:52 +07:00
Marc Durdin
687c8bae99
Merge pull request #7370 from keymanapp/fix/developer/7090-7091-use-path-backslash-format-for-parameters
fix(developer): ensure backslash in paths passed to kmcomp
2022-09-29 09:22:57 +10:00
Marc Durdin
d8f6a092b3
Merge pull request #7369 from keymanapp/fix/developer/7005-invalid-js-when-using-digits-in-stores
fix(developer): generate valid js when using unquoted digits in stores
2022-09-29 09:22:46 +10:00
Marc Durdin
73e0a2e461 fix(developer): generate valid js when using unquoted digits in stores
Fixes #7005.

If a developer used single digit values in stores, unquoted (which is
not really the usual approach, but should work just fine for non-zero
values), the KMW compiler would emit invalid single-digit hexadecimal
escapes for them, e.g. `"\x1"` instead of `"\x01"`.

Sample code:

```
store(option) 1

if(option = 1) + 'a' > 'one'
if(option = 2) + 'a' > 'two'
+ '1' > set(option = 1)
+ '2' > set(option = 2)
```

It is not immediately obvious from this code, but the value `1` is
actually a character with value `'\x01'` or `U+0001`!

The more usual approach will not encounter this problem:

```
store(option) '1'

if(option = '1') + 'a' > 'one'
if(option = '2') + 'a' > 'two'
+ '1' > set(option = '1')
+ '2' > set(option = '2')
```

Note that the following is a compile error (due to internal use of
null terminated strings).

```
store(option) 0
```
2022-09-28 17:00:55 +10:00
Marc Durdin
f5b8effaae fix(developer): ensure backslash in paths passed to kmcomp
Fixes #7090.
Fixes #7091.

While kmcomp loads most files just fine when paths with forward slashes
are passed in, it fails to parse target path correctly when building one
file out of a project.

For example, if the user runs:

```
kmcomp.exe -t khmer_angkor.kmn release/k/khmer_angkor/khmer_angkor.kpj
```

Then the following error arises:

```
khmer_angkor.kps: Error: 0001 Validation error: The system cannot find the path specified.
khmer_angkor.kps: Failure: Package C:\Projects\keyman\keyboards\source\khmer_angkor.kps had validation errors.
```

This patch ensures all paths passed in as command-line parameters are
converted to backslashes, matching the expected Windows format. While I
only needed to fix the `FParamTarget` parameter in order to address the
reported issues, for consistency I applied the same fix to all input
paths.
2022-09-28 16:50:58 +10:00
Keyman Server
497a8613db
Merge pull request #7356 from keymanapp/auto/version-master-16.0.71
auto: increment master version to 16.0.71
2022-09-27 04:02:24 +10:00
Keyman Build Agent
ee86250eec auto: increment master version to 16.0.71 2022-09-26 14:01:38 -04:00
Darcy Wong
28fd95fce2
Merge pull request #7350 from keymanapp/chore/history-15-0-stable
chore(common): Add 15.0 stable entries to HISTORY.md 🍒
2022-09-26 12:57:29 +07:00
Darcy Wong
4e1efb2fc1
Merge pull request #7347 from keymanapp/fix/android/en-language-name
fix(android): Add language name when installing default lexical-model
2022-09-26 08:13:49 +07:00
Darcy Wong
3239a1e7e3 fix(web): Update spacebar caption when refreshing layout 2022-09-23 12:45:17 +07:00
Darcy Wong
6418852eec chore(common): Add 15.0 stable entries to HISTORY.md 2022-09-23 10:11:21 +07:00
Darcy Wong
8a4dbd76ec fix(android/engine): Refresh OSK after changing spacebar caption 2022-09-22 15:35:50 +07:00
Darcy Wong
f21ffde0fc fix(android/engine): Add language name when installing lexical-model 2022-09-22 14:28:54 +07:00
Keyman Server
1a7ad09fdb
Merge pull request #7344 from keymanapp/auto/version-master-16.0.70
auto: increment master version to 16.0.70
2022-09-22 04:03:08 +10:00
Keyman Build Agent
304b87d571 auto: increment master version to 16.0.70 2022-09-21 14:02:29 -04:00
Marc Durdin
551e24c01c
Merge pull request #7339 from keymanapp/chore/common/builder-extra-params-cherry-pick
chore(common): builder extra params support 🏗 🍒
2022-09-21 14:44:09 +10:00
Marc Durdin
2a2c852fab
Merge pull request #7334 from keymanapp/feat/common/builder-feature-tests
feat(common): builder trap-functionality testing 🏗️
2022-09-21 14:44:00 +10:00
Marc Durdin
c704e33708
Merge pull request #7333 from keymanapp/refactor/common/builder_has_vs_start
refactor(common): `builder` script tweaks - "has action" vs "start action" 🏗️
2022-09-21 14:43:51 +10:00
Marc Durdin
f53bfad78e
Merge pull request #7319 from keymanapp/refactor/web/low-level-build-scripts
refactor(common/web): reworks low-level module build scripts 🏗️
2022-09-21 14:43:43 +10:00
Marc Durdin
a9b08480e3 chore(common): builder extra params support 2022-09-21 13:52:06 +10:00
Darcy Wong
7e3a7847e8
Merge pull request #7325 from keymanapp/fix/android/check-listview
fix(android/engine): Check listview for setting keyboard selection
2022-09-21 09:54:56 +07:00
Joshua A. Horton
e23bf6b649 chore(common): trap test cleanup post-rebase 2022-09-21 09:40:37 +07:00
Joshua A. Horton
c1bd242047 chore(common): Merge branch 'refactor/common/builder_has_vs_start' into feat/common/builder-feature-tests 2022-09-21 09:35:51 +07:00
Joshua Horton
825cd3c8e9
chore(common): typo fix 2022-09-21 09:24:53 +07:00
Joshua A. Horton
5147ca9159 chore(common): Merge branch 'refactor/web/low-level-build-scripts' into refactor/common/builder_has_vs_start 2022-09-21 09:12:40 +07:00
Joshua A. Horton
82ac924070 feat(common): extra test - errors within functions 2022-09-21 08:45:13 +07:00
Joshua A. Horton
c4d924aa73 chore(common): cleanup, review adjustments 2022-09-21 08:39:21 +07:00
Joshua A. Horton
f6a480c6e6 chore(common): Merge branch 'refactor/web/low-level-build-scripts' into feat/common/builder-feature-tests 2022-09-21 08:31:34 +07:00
Joshua A. Horton
f7c399aa96 change(common): more adjustments per PR review 2022-09-21 08:30:32 +07:00
Marc Durdin
51b1808c9a chore: typo in lm-worker build 2022-09-21 10:32:33 +10:00
Marc Durdin
a3129adedc refactor(common): rename builder_has_action and document
* `builder_has_action` renamed to `builder_start_action`
* `builder_report` renamed to `builder_finish_action`
* `builder_has_action` created to be a silent test for the action
* Added reasonably comprehensive documentation.
2022-09-21 10:21:35 +10:00
Keyman Server
5d6ffb7655
Merge pull request #7335 from keymanapp/auto/version-master-16.0.69
auto: increment master version to 16.0.69
2022-09-21 04:02:43 +10:00
Keyman Build Agent
e6337301a2 auto: increment master version to 16.0.69 2022-09-20 14:02:05 -04:00
Joshua A. Horton
636e69b841 feat(common): builder trap-functionality testing 2022-09-20 15:46:25 +07:00
Joshua A. Horton
6aaad72d11 docs(common): tweak to new func doc-comments 2022-09-20 13:52:24 +07:00
Joshua A. Horton
5c51597a04 feat(common): _builder_match_action 2022-09-20 13:47:02 +07:00
Joshua A. Horton
7bc5220495 change(common): minor tweak to msg 2022-09-20 13:31:30 +07:00
Joshua A. Horton
675bd60d83 fix(common): trap with set -e + func use, feat: report on uncompleted actions 2022-09-20 13:13:36 +07:00
Joshua A. Horton
12ac0df573 chore(common): low-hanging requested changes 2022-09-20 12:07:14 +07:00
Joshua A. Horton
ccf2919bb4 feat(web): report-scoping no longer option; is perma-on 2022-09-20 10:56:01 +07:00
Marc Durdin
fe9c3955aa
Merge pull request #7321 from keymanapp/chore/developer/server-node-gyp-dependency
chore(developer): update node-windows-trayicon to update node-gyp to 9.1.0
2022-09-20 13:36:06 +10:00
Joshua A. Horton
2f639ecc9c feat(common): builder report scoping option 2022-09-20 10:10:51 +07:00
Joshua A. Horton
94544277fc chore(common): minor cleanup in keyman-version, provides test case 2022-09-20 09:27:29 +07:00
Joshua A. Horton
2bea392baa feat(common): builder_-managed failure-trap 2022-09-20 09:23:38 +07:00
Joshua A. Horton
256b21f691 feat(common): builder current-action tracking 2022-09-20 09:08:02 +07:00
Joshua A. Horton
29e24493bc fix(common): color option needed for builder_describe 2022-09-20 08:52:12 +07:00
Joshua A. Horton
4399548df0 feat(common): DESCRIBE_TERM_START, _END 2022-09-20 08:30:33 +07:00
Joshua A. Horton
18c5fae23b chore(common/web): simple tweaks for PR review 2022-09-20 08:21:22 +07:00
Marc Durdin
d1de02d43e chore(developer): Merge branch 'master' into chore/developer/server-node-gyp-dependency 2022-09-20 10:19:11 +10:00
Marc Durdin
e636fe5e3f
Merge pull request #7314 from keymanapp/chore/developer/server-update-multer-dependency
chore(developer): update multer dependency for server
2022-09-20 10:18:22 +10:00