Commit graph

2838 commits

Author SHA1 Message Date
Steven R. Loomis
018d109560
Merge pull request #8222 from keymanapp/feat/core/7535-process-test-data-epic-ldml
feat(core): ldml: implement xml test cases 🙀
2023-02-20 16:35:03 -06:00
Steven R. Loomis
bccc1e5720 Merge remote-tracking branch 'upstream/master' into chore/merge-master-20230217-epic-ldml 2023-02-17 18:52:33 -06:00
Steven R. Loomis
83adfdd1c6
Update common/web/types/src/kmx/kmx-plus-builder/build-key2.ts
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2023-02-16 21:43:45 -06:00
Steven R. Loomis
8ea87aa828 feat(common): ldml: merge keys into key2 🙀 2023-02-16 12:29:19 -06:00
Joshua A. Horton
889d347c02 chore(common): Merge branch 'master' into chore/common/js-ts-dependency-updates 2023-02-16 13:51:31 +07:00
Steven R. Loomis
dd76a1fc36 feat(developer): add -T option to kmc 🙀
- -T converts testdata.xml into testdata.json

#7535
2023-02-15 17:58:52 -06:00
Steven R. Loomis
228cdd6281 feat(common): ldml read keyboard testdata 🙀
- full data test

#7535
2023-02-15 17:58:52 -06:00
Steven R. Loomis
c2556acc4a feat(common): ldml read keyboard testdata 🙀
- full data read

#7535
2023-02-15 17:58:52 -06:00
Steven R. Loomis
9a31e866df feat(common): ldml read keyboard testdata 🙀
- early scaffolding
- with some basic tests

#7535
2023-02-15 17:58:52 -06:00
Steven R. Loomis
ac2366f460 feat(core): ldml C++ updates to modifiers 🙀
- spec: change caps value to 0x100 #7533
- add a 'mod_all'  for validating valid modifier keys, plus tests
- add asserts on C++ side mapping modifiers to keyman constants
- use 'mod_all' to validate modifiers
- further fix modifier -> mod in binary

For: #7985 and related to #7533
2023-02-14 09:23:03 -06:00
Steven R. Loomis
7983fd9609 fix(developer): ldml spec: layr…mod needs to be a bitfield 🙀
- layr.layers.layer.mod needs to be a bit field just as keys.key.mod

Related to #7533
2023-02-14 09:23:03 -06:00
Steven R. Loomis
7c02ab85af feat(core): ldml C++ feature support 🙀
- make ldml.cpp print FAILED on failure especially because of https://github.com/microsoft/vscode-cpptools/issues/487
- add vkey validation (#7135)
- add disp validation
- fix: a latent bug in disp! disp.count was === vkey.count, oops. Fix and test cases.

For: #7985
2023-02-14 09:23:03 -06:00
Marc Durdin
3c08d8f6b1
Merge pull request #8197 from keymanapp/chore/common/builder-cleanup-color-test
chore(common): automatically apply _builder_check_color
2023-02-11 13:13:30 +11:00
Marc Durdin
d5ca3fb56c
Merge pull request #8179 from keymanapp/fix/developer/8157-bcp47-code-dialog-inconsistencies
fix(developer): Select BCP47 Code dialog inconsistencies
2023-02-11 13:13:14 +11:00
Steven R. Loomis
db272e08e7 Merge remote-tracking branch 'upstream/master' into chore/merge-master-20230210-epic-ldml 2023-02-10 11:01:27 -06:00
Joshua A. Horton
a3752dd9ff chore(common): full-repo ts-node update 2023-02-09 12:39:15 +07:00
Marc Durdin
4598f13ba8 chore(common): automatically apply _builder_check_color 2023-02-09 12:12:18 +07:00
Joshua A. Horton
878e0f0ea2 chore(common): updates typescript to 4.9.5 2023-02-09 08:40:52 +07:00
Marc Durdin
983ae43357 chore(common): add builder_term function 2023-02-08 12:49:54 +07:00
Steven R. Loomis
a8832ea893
Merge pull request #8172 from keymanapp/feat/developer/7965-morehardware-epic-ldml
feat(common): ldml different hardware support 🙀
2023-02-07 17:06:35 -06:00
Steven R. Loomis
9d6289d420
Merge pull request #8171 from keymanapp/feat/core/7533-modifier-epic-ldml
feat(common): ldml modifier support 🙀
2023-02-07 17:05:55 -06:00
Marc Durdin
c155325d73 fix(developer): Select BCP47 Code dialog inconsistencies
Fixes #8157.

There are some limitations in this dialog as it stands; we will rework
it completely when we revisit BCP 47 tagging.

However, for now, this addresses some strange behaviours around the
Reset button and the displayed output:

* The Reset button will only be enabled if you change the text in the
  Language Name field.
* The messaging around a missing language subtag is clearer -- tells
  the user that they need to enter something there.
* The Reset button will now never insert default text strings into the
  Language Name field.

One example of something that is slightly weird, is if you enter a
two-letter region subtag into the script box, it will show what looks
like a valid tag in the output box (e.g. `en-Au`), but it will be
considered invalid, because that two letter subtag needs to be entered
into the region box.
2023-02-07 12:40:31 +07:00
Steven R. Loomis
75fb36b9e0
Merge pull request #8143 from keymanapp/fix/common/7534-more-import-errs-epic-ldml
feat(common): ldml: import error messages from the compiler   🙀
2023-02-06 11:25:20 -06:00
Steven R. Loomis
c4f7f0eb12
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-02-06 11:24:24 -06:00
Steven R. Loomis
f74a419bc6 chore: Review comment 2023-02-03 19:03:26 -06:00
Steven R. Loomis
41f77a874c feat(common): ldml different hardware support 🙀
- add HardwareToKeymap in common/web/types
- add a mt-iso keyboard, very close to stock mt.xml
- add machinery for parsing modifier key sequences
- more test machinery
- add assertions against invalid modifier sequences

Fixes: #7965
2023-02-03 19:00:57 -06:00
Steven R. Loomis
af10312f84 feat(common): ldml modifier support 🙀
- spec: update spec for layr.mod field
- core/include/ldm: update constants
- bitfield modelled after s_modifier_names[]  / LCTRLFLAG etc.
- new test case k_004_tinyshift, also update k_010_mt
- update const builder to ignore all *_map properties
- split utility out to utils, add test

For: #7533
(cherry picked from commit 0346bea488)
2023-02-03 18:54:22 -06:00
Steven R. Loomis
6f51be0684 feat(common): ldml: unit tests for import error messages from the compiler 🙀
- test fixup

For: #7534
2023-02-03 18:54:07 -06:00
Steven R. Loomis
7ffd2b94f5 feat(common): ldml: updates to xml loading 🙀
per review comments

- exit-early on import errs

For: #7534
2023-02-03 18:43:06 -06:00
Steven R. Loomis
ac38c277d8 feat(common): ldml: comprehensive import/implied data tests 🙀
For: #7534
(cherry picked from commit 2b64006dba)
2023-02-03 18:43:06 -06:00
Steven R. Loomis
5c357fad81 feat(common): ldml: unit tests for import error messages from the compiler 🙀
- also, change loadFile in callbacks to return null when file isn't found.

For: #7534
(cherry picked from commit 33274dd2c8)
2023-02-03 18:39:51 -06:00
Steven R. Loomis
20c1f5ec9e feat(common): ldml: import error messages from the compiler 🙀
For: #7534
(cherry picked from commit 3a3729e5c6)
2023-02-03 18:38:01 -06:00
Steven R. Loomis
1f594e6cf1 fix(common): test fix for test-ldml-keyboard-xml-reader 2023-02-03 18:24:43 -06:00
Steven R. Loomis
f527caaf0b feat(common): ldml updates to validation errors 🙀
- Apply suggestions from code review
- move m() into common code
- rename several error-related fields and types
- drop the 'unknown AJV error' - we expect errors to be populated
- halt compilation if validation fails, don't press on

For: #7534

Co-authored-by: Marc Durdin <marc@durdin.net>
(cherry picked from commit 05cc200f2027ee3c61280812a2de85ef20ea8b51)
2023-02-03 18:24:43 -06:00
Steven R. Loomis
0a0a9dcc27 feat(common): ldml: error messages from the compiler 🙀
- more refactor into common/web/types
- refactor test harness
- use reportMessage instead of throwing

For: #7964
(cherry picked from commit a112b847c4)
2023-02-03 18:24:43 -06:00
Steven R. Loomis
ae45295dc6 Merge remote-tracking branch 'upstream/master' into chore/merge-master-a17s5-REDO-epic-ldml 2023-02-03 16:53:35 -06:00
Marc Durdin
224402b9cc
Merge pull request #8151 from keymanapp/feat/developer/8119-duplicated-language-codes
feat(developer): check for duplicated language codes in package editor and compiler
2023-02-03 12:30:11 +11:00
Marc Durdin
8ee8325c74 feat(developer): check for duplicated language codes in package editor and compiler
Fixes #8119.
2023-02-02 15:06:15 +07:00
Joshua Horton
1b220db622
Merge pull request #7894 from keymanapp/feat/common/srcmap-remap-module
feat(common): TS-based sourcemap remapping tool 📜
2023-02-02 09:21:08 +07:00
Joshua A. Horton
ede1068d51 chore(web): Merge branch 'master' into change/web/reorg-source-src-reorg 2023-02-02 09:18:46 +07:00
Joshua A. Horton
61a789a9ca chore(web): Merge branch 'master' into chore/web/top-level-build-script-rework 2023-02-02 08:58:44 +07:00
Joshua A. Horton
e2d1b17dec fix(common): some nits 2023-02-01 13:08:26 +07:00
Steven R. Loomis
709c1ccca5 fix(common) make common/web/types kvk tests pass 🙀
- use hexy and git-diff to show a rich diff when files are changed
- add additional round trip tests
- initialize the underlyingLayout to undefined to promote round tripping
- fix an issue with the CompilerCallbacks in the xml tests (broken in #8107)
- fix an issue with the kvk file writer where it should set strings irregardless (#7955)

Fixes #7967, again
2023-01-31 12:15:39 -06:00
Steven R. Loomis
80a001520c chore(common): imports: Apply suggestions from code review 🙀
-  rename compiler.ts to compiler-interfaces.ts

applies to 5a4b44f2d7

Co-authored-by: Marc Durdin <marc@durdin.net>

For: #7534
2023-01-30 21:04:05 -06:00
Steven R. Loomis
a40ee01767 feat(developer): ldml import/implied keys : review comment 🙀
- add a TODO comment about using a custom error class
2023-01-27 13:06:00 -06:00
Steven R. Loomis
bbd850c03b feat(common): ldml: imports: use cldr version from constants 🙀
- common: more robustness in importing.
- build: don't copy imports to kmc which doesn't need it

supports #7964
2023-01-27 12:45:00 -06:00
Steven R. Loomis
a0b184a022 feat(common): ldml: use cldr version from constants 🙀
- update several config files

supports #7964
2023-01-27 12:45:00 -06:00
Steven R. Loomis
e5c5fd025e feat(common): ldml: change importer to use callbacks for fs 🙀
supports #7964
2023-01-27 12:45:00 -06:00
Steven R. Loomis
3eb7f05df6 feat(developer): ldml implied keys work 🙀
- update test cases per review

- review comment
2023-01-27 12:42:18 -06:00
Steven R. Loomis
727056cb87 feat(developer): ldml support implied keys 🙀
- automatically add the import

Fixes: #7964

Apply suggestions from code review

Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-27 12:41:39 -06:00