erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-02 21:57:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

feat(developer): ldml import/implied keys : review comment 🙀

Browse source 
- add a TODO comment about using a custom error class
This commit is contained in:
Steven R. Loomis 2023-01-27 13:06:00 -06:00
parent 55f5a57425
commit a40ee01767
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
common/web/types/src/ldml-keyboard/ldml-keyboard-xml-reader.ts
View file

@ -118,10 +118,11 @@ export default class LDMLKeyboardXMLSourceFileReader {
private resolveOneImport(obj: any, subtag: string, asImport: LKImport) {
if (asImport.base !== constants.cldr_import_base) {
// TODO-LDML: use custom error class CompilerImportResolveError
throw new Error(`import element with base ${asImport.base} is unsupported, only ${constants.cldr_import_base} is supported.`);
}
const paths = asImport.path.split('/');
if (!paths[0] || !paths[1] || paths.length !== 2) {
if (paths[0] == '' || paths[1] == '' || paths.length !== 2) {
throw new Error(`import element with invalid path ${asImport.path}: expect the form '${constants.cldr_version_latest}./*.xml'`);
}
const importData: Uint8Array = this.readImportFile(paths[0], paths[1]);