A recent change (#14324) consolidated (and thus renamed) some functions that were in several places. A PR that got created earlier but merged later (#14267) added new functionality that still used the old function names. This lead to release build failures on Windows and Developer.
This change fixes the names of the called functions.
Fixes: #14412
Follow-up-of: #14324
Follow-up-of: #14267
A recent change (#14324) consolidated (and thus renamed) some functions
that were in several places. A PR that got created earlier but merged
later (#14267) added new functionality that still used the old function
names. This lead to release build failures on Windows and Developer.
This change fixes the names of the called functions.
Fixes: #14412
Follow-up-of: #14324
Test-bot: skip
- added `tc_` prefix to functions in `includes/tc-*.inc.sh`
- moved `includes/tc-actions.inc.sh` → `linux/linux-actions.inc.sh`
- didn't change `write_download_info`. That will be done as part of #14259.
- didn't change `is_*`. That will be done as part of #14109.
- removed unnecessary functions that only call another function.
- moved functions from `tc-windows.inc.sh` → `tc-helpers.inc.sh` because they are no longer Windows-specific (although currently only used for Windows).
Fixes: #14201
`resources/builder.inc.sh` is designed to be used on other non-builder scripts, so not all variables can be assumed to be set. This change fixes some "unbound variable" errors.
`resources/builder.inc.sh` is designed to be used on other non-builder
scripts, so not all variables can be assumed to be set. This change
fixes some "unbound variable" errors.
Test-bot: skip
If the `$EMSCRIPTEN_BASE` dir is missing (which usually points to `emsdk/upstream/emscripten`), but we have the `emsdk` root directory with `emsdk/emsdk`, we can have everything we need to install the desired emscripten version.
Issue #13464 describes an error where the `upstream/emscripten` directory was missing - probably because the build got interrupted while installing emscripten. This change fixes this.
Fixes: #13464
This changes makes use of the logic that used to be in `win/zip.inc.sh`: if the environment variable `GO_FAST` is set to 1, we use a low compression level, resulting in faster builds. If it is set to 0 we use maximum compression, resulting in slower builds. If `GO_FAST` is not set we don't specify the compression level and rely on the defaults.
Also make use of the new functionality by replacing the use of the `wzzip` function.
Note: `GO_FAST` gets set in some existing scripts.
Previously `add_zip_files` didn't work if the zip filename was not specified as first parameter. This change allows it to come after flags.
This will fix web release and other builds.
This partially reverts the previous commit in that it doesn't set the
`RELEASE_OEM` and `RELEASE_OEM_FIRSTVOICES` env variables if called with
`--fv`. Instead we rely on these variables being set in the TC config.
See also #14388 for a better solution.
`jq.inc.sh` gets also used in some scripts that don't source our builder scripts, e.g. in git hooks. This means that `builder_is_windows` is not defined. This change replaces the call of that function with a slightly modified version of the previous implementation.
Follow-up-of: #14324
Previously `add_zip_files` didn't work if the zip filename was not
specified as first parameter. This change allows it to come after flags.
This will fix web release builds.
Test-bot: skip
`jq.inc.sh` gets also used in some scripts that don't source our
builder scripts, e.g. in git hooks. This means that `builder_is_windows`
is not defined. This change replaces the call of that function with
a slightly modified version of the previous implementation.
Follow-up-of: #14324
Build-bot: skip
Test-bot: skip
This makes of the testing framework added in #14345 and also renames
the tests to better separate the parts of the test name.
Build-bot: skip
Test-bot: skip
