Include files are not directly executable, so it doesn't make sense to
have the shebang line. However, shellcheck needs to know what shell we
use. Turns out there is a shellcheck line that we can add instead of
the shebang line.
Follow-up-of: #14253
Build-bot: skip
Test-bot: skip
`--ci` is deprecated since the current code discovers automatically
when we're building on CI, so we don't have to pass that option when
calling the `android/build.sh` script.
Also remove the option itself since we're no longer using it.
Build-bot: build android
Test-bot: skip
The previous code showed a warning in the Firefox console: "Unreachable code after return statement". Moving the helper functions to the beginning of the surrounding function solves it.
Also make some variables `const`.
Refactors the Powershell scripts that download and upload files and create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting that msys does when calling Windows rsync.
Refactors the Powershell scripts that download and upload files and create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting that msys does when calling Windows rsync. Part of this change was done for developer in #14255.
Refactors the Powershell scripts that download and upload files and
create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting
that msys does when calling Windows rsync.
Fixes: #14226
Related: #14236
Build-bot: skip
Test-bot: skip
Also make `_tc_rsync` function cross-platform. A comparison might show
that we omit `--perms` when calling rsync with this change. However the
short form (`-p`) is already included, so we don't have to additional
add the long form `--perms`.
There is one difference compared to the old build configurations on TC:
previously we had a separate build step to build and test FV that would
run only if environment variables were set.
This change combines building and testing FV with building the engine
and the app. If the environment variables are set we pass an additional
parameter to the TC build script.
Fixes: #14188
Part-of: #13399
Build-bot: release android
Test-bot: skip
Refactors the Powershell scripts that download and upload files and
create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting
that msys does when calling Windows rsync. Part of this change was done
for developer in #14255.
Related: #14236, #14255
The previous code showed a warning in the Firefox console: "Unreachable
code after return statement". Moving the helper functions to the
beginning of the surrounding function solves it.
Also make some variables `const`.
