This change addresses code review comments. `common` and `core` also
have TC build configs, so we add labels for them as well.
Co-authored-by: Marc Durdin <marc@durdin.net>
Add label `$platform` for changes to `resources/teamcity/$platform`
or `resources/teamcity/includes`.
Also remove no longer existent `linux/legacy/` paths.
Fixes: #13943
Test-bot: skip
The recent update of one of the `docker/build-push-action` dependency
referenced in the `gha-ubuntu-packaging` dependency now adds the
`.dockerbuild` log files as artifacts which confuses the
`prepare_api_verification` step. This change now limits the artifacts
we pass to the API verification to the keyman package related ones.
Test-bot: skip
This change fixes the fix that #13891 implemented. However that only
used the string `VERSION` instead of the variable... Fixes the package
builds of `stable-18.0` branch.
Fixes: #13891
Test-bot: skip
Previously the builder scripts defined a readonly `VERSION` environment
variable for the Keyman version. That caused problems when another
(external) script tried to define a `VERSION` variable. We encountered
this problem when trying to move the TC build steps of a configuration
into a single script (#13399) when we tried to source `~/.nvm/nvm.sh`.
This change uses a Keyman specific prefix for the version variables and
renames `VERSION` → `KEYMAN_VERSION` etc. Unfortunately these variables
are used in a lot of places, so this turned out to be a bit of a yak
shave.
Test-bot: skip
During the "M3: Maintenance Sprints" session of the April 2025 planning
conference we discussed that we'd rename the `chore` GH label to `maint`.
However, this change doesn't remove the existing `chore` label because
that is also used for merge commits.
Note: m:predictive-text and m:developer-ide mark a change where we have
some modules with fuzzy boundaries and where it may not be easy to
automatically determine all changes by pathname. I am not altogether
comfortable with these so we may iterate a bit further yet.
So far the GHA was called "Ubuntu packaging" but the status reported as
"Debian packaging" which was confusing. This change now uses "Ubuntu
packaging" in both places.
We still keep the filename `deb-packaging.yml` because we're packaging
the .deb format, and because it's shorter.
Fixes: #13497
- remove useless branch name from name (this is always `master` due to
the way the workflow gets triggered)
- add PR# to step summary so that it's visible on the Summary page
- fix PR check message to say "API verification" instead of "Package build"
The previous wildcard was too broad and matched on `libkeymancore-dev`
which is missing the API version number in the filename. This change
requires a digit after the name.
This change reverts #11659 and moves setting the environment and
restoring the artifacts in the same job as the actual API verification.
It keeps checking out the git files to a separate directory.
In #11571 we tried to fix the failing API verification by moving
setting up the environment and restoring artifacts to the same job
as the api verification itself. However, this doesn't help and the
`artifacts` subdirectory still vanishes, caused by
https://github.com/actions/checkout/issues/1201.
This change reverts the change introduced in #11571 and changes the
git checkout to end in a separate subdirectory.
Reverts: #11571
Previously we had an extra job where we setup the environment and
restored the artifacts. However, the artifacts then were no longer
available in the next job, `api_verification`. Instead of restoring
the artifacts a second time this change squashes the two jobs. This will
hopefully fix the API verification.
