erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-19 14:17:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(web): don't clear context when beep happens

Browse source 
After review with @ermshiperete, we decided to remove this. It is
unclear to me why we were ever clearing the context when a beep was
triggered by the keyboard. This is legacy from v2.0 of KeymanWeb, and I
suspect it's an edge case that no one has ever noticed, but I can't see
a reason to keep it.

Test-bot: skip
This commit is contained in:
Marc Durdin 2025-11-07 09:52:45 +00:00
parent 9376f08761
commit db187e52ad
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
web/src/app/browser/src/beepHandler.ts
View file

@ -1,5 +1,4 @@
import { type JSKeyboardInterface } from 'keyman/engine/js-processor';
import { JSKeyboard, type KeyboardMinimalInterface } from 'keyman/engine/keyboard';
import { type KeyboardMinimalInterface } from 'keyman/engine/keyboard';
import { DesignIFrameElementTextStore, AbstractElementTextStore } from 'keyman/engine/element-text-stores';
// Utility object used to handle beep (keyboard error response) operations.
@ -76,11 +75,6 @@ export class BeepHandler {
* Description Reset/terminate beep or flash (not currently used: Aug 2011)
*/
readonly reset = () => {
// TODO-web-core: implement for KMX keyboards if needed
if (this.keyboardInterface.activeKeyboard instanceof JSKeyboard) {
(this.keyboardInterface as JSKeyboardInterface).resetContextCache();
}
this._BeepTimeout = 0;
for(let Lbo=0;Lbo<this._BeepObjects.length;Lbo++) { // I1511 - array prototype extended
this._BeepObjects[Lbo].reset();