From db187e52ad8504837b1ef5e2afec97fc69fa7cbd Mon Sep 17 00:00:00 2001 From: Marc Durdin Date: Fri, 7 Nov 2025 09:52:45 +0000 Subject: [PATCH] fix(web): don't clear context when beep happens After review with @ermshiperete, we decided to remove this. It is unclear to me why we were ever clearing the context when a beep was triggered by the keyboard. This is legacy from v2.0 of KeymanWeb, and I suspect it's an edge case that no one has ever noticed, but I can't see a reason to keep it. Test-bot: skip --- web/src/app/browser/src/beepHandler.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/web/src/app/browser/src/beepHandler.ts b/web/src/app/browser/src/beepHandler.ts index 76936c220c..b520c709ce 100644 --- a/web/src/app/browser/src/beepHandler.ts +++ b/web/src/app/browser/src/beepHandler.ts @@ -1,5 +1,4 @@ -import { type JSKeyboardInterface } from 'keyman/engine/js-processor'; -import { JSKeyboard, type KeyboardMinimalInterface } from 'keyman/engine/keyboard'; +import { type KeyboardMinimalInterface } from 'keyman/engine/keyboard'; import { DesignIFrameElementTextStore, AbstractElementTextStore } from 'keyman/engine/element-text-stores'; // Utility object used to handle beep (keyboard error response) operations. @@ -76,11 +75,6 @@ export class BeepHandler { * Description Reset/terminate beep or flash (not currently used: Aug 2011) */ readonly reset = () => { - // TODO-web-core: implement for KMX keyboards if needed - if (this.keyboardInterface.activeKeyboard instanceof JSKeyboard) { - (this.keyboardInterface as JSKeyboardInterface).resetContextCache(); - } - this._BeepTimeout = 0; for(let Lbo=0;Lbo