mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-26 18:27:53 +00:00
8e5adde0b3
The network list compat API requires us to include all containers with their ip addresses for the selected networks. Because we have no network -> container mapping in the db we have to go through all containers every time. However the old code did it in the most ineffective way possible, it quered the containers from the db for each individual network. The of course is extremely expensive. Now the other expensive call is calling Inspect() on the container each time. Inspect does for more than we need. To fix this we fist query containers only once for the API call, then replace the inspect call with directly accessing the network status. This will speed things up a lot! The reported scenario includes 100 containers and 25 networks, previously it took 1.5s for the API call not it takes 24ms, that is a more than a 62x improvement. (tested with curl) [NO NEW TESTS NEEDED] We have no timing tests. Fixes #20035 Signed-off-by: Paul Holzinger <pholzing@redhat.com> |
||
|---|---|---|
| .. | ||
| auth.go | ||
| changes.go | ||
| containers.go | ||
| containers_archive.go | ||
| containers_attach.go | ||
| containers_create.go | ||
| containers_export.go | ||
| containers_logs.go | ||
| containers_pause.go | ||
| containers_prune.go | ||
| containers_restart.go | ||
| containers_start.go | ||
| containers_stats_freebsd.go | ||
| containers_stats_linux.go | ||
| containers_stop.go | ||
| containers_top.go | ||
| containers_unpause.go | ||
| events.go | ||
| exec.go | ||
| images.go | ||
| images_build.go | ||
| images_history.go | ||
| images_prune.go | ||
| images_push.go | ||
| images_remove.go | ||
| images_save.go | ||
| images_search.go | ||
| images_tag.go | ||
| info.go | ||
| networks.go | ||
| ping.go | ||
| resize.go | ||
| secrets.go | ||
| system.go | ||
| types.go | ||
| unsupported.go | ||
| version.go | ||
| volumes.go | ||