mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-10 01:27:54 +00:00
258749e43d
When I originally wrote this code I had no idea what POST
would look like so I did a sloppy job, deferring making it
usable. Now that we have some real-world examples in place,
I have a better understanding of what params look like and
how to make tests more readable/maintainable. (Deferring isn't
always bad: one of my early ideas was to separate params using
commas; that would've been a disaster because some JSON values,
such as arrays, include commas).
This commit implements a better way of dealing with POST:
* The main concept is still 'key=value'
* When value is a JSON object (dictionary, array), it
can be quoted.
* Multiple params are simply separated by spaces.
The 3-digit HTTP code is a prominent, readable separator
between POST params and expected results. The parsing
code is a little uglier, but test developers need
never see that. The important thing is that writing
tests is now easier.
* POST params can be empty (this removes the need for a
useless '')
I snuck in one unrelated change: one of the newly-added
tests, .NetworkSettings, was failing when run rootless
(which is how I test on my setup). I made it conditional.
Signed-off-by: Ed Santiago <santiago@redhat.com>
39 lines
843 B
Bash
39 lines
843 B
Bash
# -*- sh -*-
|
|
#
|
|
# secret-related tests
|
|
#
|
|
|
|
# secret create
|
|
t POST secrets/create Name=mysecret Data=c2VjcmV0 200\
|
|
.ID~.* \
|
|
|
|
# secret create unsupported labels
|
|
t POST secrets/create Name=mysecret Data=c2VjcmV0 Labels='{"fail":"fail"}' 400
|
|
|
|
# secret create name already in use
|
|
t POST secrets/create Name=mysecret Data=c2VjcmV0 409
|
|
|
|
# secret inspect
|
|
t GET secrets/mysecret 200 \
|
|
.Spec.Name=mysecret \
|
|
.Version.Index=1
|
|
|
|
# secret inspect non-existent secret
|
|
t GET secrets/bogus 404
|
|
|
|
# secret list
|
|
t GET secrets 200 \
|
|
length=1 \
|
|
.[0].Spec.Name=mysecret \
|
|
.[0].Version.Index=1
|
|
|
|
# secret list unsupported filters
|
|
t GET secrets?filters='{"name":["foo1"]}' 400
|
|
|
|
# secret rm
|
|
t DELETE secrets/mysecret 204
|
|
# secret rm non-existent secret
|
|
t DELETE secrets/bogus 404
|
|
|
|
# secret update not implemented
|
|
t POST secrets/mysecret/update 501
|