mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-10 01:27:54 +00:00
0f7d54b026
Migrate the Podman code base over to `common/libimage` which replaces `libpod/image` and a lot of glue code entirely. Note that I tried to leave bread crumbs for changed tests. Miscellaneous changes: * Some errors yield different messages which required to alter some tests. * I fixed some pre-existing issues in the code. Others were marked as `//TODO`s to prevent the PR from exploding. * The `NamesHistory` of an image is returned as is from the storage. Previously, we did some filtering which I think is undesirable. Instead we should return the data as stored in the storage. * Touched handlers use the ABI interfaces where possible. * Local image resolution: previously Podman would match "foo" on "myfoo". This behaviour has been changed and Podman will now only match on repository boundaries such that "foo" would match "my/foo" but not "myfoo". I consider the old behaviour to be a bug, at the very least an exotic corner case. * Futhermore, "foo:none" does *not* resolve to a local image "foo" without tag anymore. It's a hill I am (almost) willing to die on. * `image prune` prints the IDs of pruned images. Previously, in some cases, the names were printed instead. The API clearly states ID, so we should stick to it. * Compat endpoint image removal with _force_ deletes the entire not only the specified tag. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
74 lines
2 KiB
Go
74 lines
2 KiB
Go
package compat
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/libpod"
|
|
"github.com/containers/podman/v3/pkg/api/handlers"
|
|
"github.com/containers/podman/v3/pkg/api/handlers/utils"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/domain/infra/abi"
|
|
"github.com/containers/podman/v3/pkg/util"
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
func PruneImages(w http.ResponseWriter, r *http.Request) {
|
|
var (
|
|
filters []string
|
|
)
|
|
runtime := r.Context().Value("runtime").(*libpod.Runtime)
|
|
|
|
filterMap, err := util.PrepareFilters(r)
|
|
if err != nil {
|
|
utils.Error(w, "Something went wrong.", http.StatusInternalServerError, errors.Wrapf(err, "failed to parse parameters for %s", r.URL.String()))
|
|
return
|
|
}
|
|
|
|
for k, v := range *filterMap {
|
|
for _, val := range v {
|
|
filters = append(filters, fmt.Sprintf("%s=%s", k, val))
|
|
}
|
|
}
|
|
|
|
imageEngine := abi.ImageEngine{Libpod: runtime}
|
|
|
|
pruneOptions := entities.ImagePruneOptions{Filter: filters}
|
|
imagePruneReports, err := imageEngine.Prune(r.Context(), pruneOptions)
|
|
if err != nil {
|
|
utils.InternalServerError(w, err)
|
|
return
|
|
}
|
|
|
|
idr := make([]types.ImageDeleteResponseItem, len(imagePruneReports))
|
|
var reclaimedSpace uint64
|
|
var errorMsg bytes.Buffer
|
|
for _, p := range imagePruneReports {
|
|
if p.Err != nil {
|
|
// Docker stops on first error vs. libpod which keeps going. Given API constraints, concatenate all errors
|
|
// and return that string.
|
|
errorMsg.WriteString(p.Err.Error())
|
|
errorMsg.WriteString("; ")
|
|
continue
|
|
}
|
|
|
|
idr = append(idr, types.ImageDeleteResponseItem{
|
|
Deleted: p.Id,
|
|
})
|
|
reclaimedSpace = reclaimedSpace + p.Size
|
|
}
|
|
if errorMsg.Len() > 0 {
|
|
utils.InternalServerError(w, errors.New(errorMsg.String()))
|
|
return
|
|
}
|
|
|
|
payload := handlers.ImagesPruneReport{
|
|
ImagesPruneReport: types.ImagesPruneReport{
|
|
ImagesDeleted: idr,
|
|
SpaceReclaimed: reclaimedSpace,
|
|
},
|
|
}
|
|
utils.WriteResponse(w, http.StatusOK, payload)
|
|
}
|