mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-09 17:17:53 +00:00
Restored containers, until now, had the same port mappings as the original started container. This commit adds the parameter '--publish' to 'podman container restore' with the same semantic as during create/run. With this change it is possible to create a copy from a container with a '--publish' rule and replace the original '--publish' setting with a new one. # podman run -p 2345:8080 container # podman container checkpoint -l --export=dump.tar # podman container restore -p 5432:8080 --import=dump.tar The restored container will now listen on localhost:5432 instead of localhost:2345 as the original created container. Signed-off-by: Adrian Reber <areber@redhat.com>
136 lines
5.1 KiB
Go
136 lines
5.1 KiB
Go
package containers
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/containers/common/pkg/completion"
|
|
"github.com/containers/podman/v3/cmd/podman/common"
|
|
"github.com/containers/podman/v3/cmd/podman/registry"
|
|
"github.com/containers/podman/v3/cmd/podman/utils"
|
|
"github.com/containers/podman/v3/cmd/podman/validate"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/rootless"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
var (
|
|
restoreDescription = `
|
|
podman container restore
|
|
|
|
Restores a container from a checkpoint. The container name or ID can be used.
|
|
`
|
|
restoreCommand = &cobra.Command{
|
|
Use: "restore [options] CONTAINER [CONTAINER...]",
|
|
Short: "Restores one or more containers from a checkpoint",
|
|
Long: restoreDescription,
|
|
RunE: restore,
|
|
Args: func(cmd *cobra.Command, args []string) error {
|
|
return validate.CheckAllLatestAndCIDFile(cmd, args, true, false)
|
|
},
|
|
ValidArgsFunction: common.AutocompleteContainers,
|
|
Example: `podman container restore ctrID
|
|
podman container restore --latest
|
|
podman container restore --all`,
|
|
}
|
|
)
|
|
|
|
var restoreOptions entities.RestoreOptions
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: restoreCommand,
|
|
Parent: containerCmd,
|
|
})
|
|
flags := restoreCommand.Flags()
|
|
flags.BoolVarP(&restoreOptions.All, "all", "a", false, "Restore all checkpointed containers")
|
|
flags.BoolVarP(&restoreOptions.Keep, "keep", "k", false, "Keep all temporary checkpoint files")
|
|
flags.BoolVar(&restoreOptions.TCPEstablished, "tcp-established", false, "Restore a container with established TCP connections")
|
|
|
|
importFlagName := "import"
|
|
flags.StringVarP(&restoreOptions.Import, importFlagName, "i", "", "Restore from exported checkpoint archive (tar.gz)")
|
|
_ = restoreCommand.RegisterFlagCompletionFunc(importFlagName, completion.AutocompleteDefault)
|
|
|
|
nameFlagName := "name"
|
|
flags.StringVarP(&restoreOptions.Name, nameFlagName, "n", "", "Specify new name for container restored from exported checkpoint (only works with --import)")
|
|
_ = restoreCommand.RegisterFlagCompletionFunc(nameFlagName, completion.AutocompleteNone)
|
|
|
|
importPreviousFlagName := "import-previous"
|
|
flags.StringVar(&restoreOptions.ImportPrevious, importPreviousFlagName, "", "Restore from exported pre-checkpoint archive (tar.gz)")
|
|
_ = restoreCommand.RegisterFlagCompletionFunc(importPreviousFlagName, completion.AutocompleteDefault)
|
|
|
|
flags.BoolVar(&restoreOptions.IgnoreRootFS, "ignore-rootfs", false, "Do not apply root file-system changes when importing from exported checkpoint")
|
|
flags.BoolVar(&restoreOptions.IgnoreStaticIP, "ignore-static-ip", false, "Ignore IP address set via --static-ip")
|
|
flags.BoolVar(&restoreOptions.IgnoreStaticMAC, "ignore-static-mac", false, "Ignore MAC address set via --mac-address")
|
|
flags.BoolVar(&restoreOptions.IgnoreVolumes, "ignore-volumes", false, "Do not export volumes associated with container")
|
|
|
|
flags.StringSliceP(
|
|
"publish", "p", []string{},
|
|
"Publish a container's port, or a range of ports, to the host (default [])",
|
|
)
|
|
_ = restoreCommand.RegisterFlagCompletionFunc("publish", completion.AutocompleteNone)
|
|
|
|
validate.AddLatestFlag(restoreCommand, &restoreOptions.Latest)
|
|
}
|
|
|
|
func restore(cmd *cobra.Command, args []string) error {
|
|
var errs utils.OutputErrors
|
|
if rootless.IsRootless() {
|
|
return errors.New("restoring a container requires root")
|
|
}
|
|
if restoreOptions.Import == "" && restoreOptions.ImportPrevious != "" {
|
|
return errors.Errorf("--import-previous can only be used with --import")
|
|
}
|
|
if restoreOptions.Import == "" && restoreOptions.IgnoreRootFS {
|
|
return errors.Errorf("--ignore-rootfs can only be used with --import")
|
|
}
|
|
if restoreOptions.Import == "" && restoreOptions.IgnoreVolumes {
|
|
return errors.Errorf("--ignore-volumes can only be used with --import")
|
|
}
|
|
if restoreOptions.Import == "" && restoreOptions.Name != "" {
|
|
return errors.Errorf("--name can only be used with --import")
|
|
}
|
|
if restoreOptions.Name != "" && restoreOptions.TCPEstablished {
|
|
return errors.Errorf("--tcp-established cannot be used with --name")
|
|
}
|
|
|
|
inputPorts, err := cmd.Flags().GetStringSlice("publish")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(inputPorts) > 0 {
|
|
restoreOptions.PublishPorts, err = common.CreatePortBindings(inputPorts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
argLen := len(args)
|
|
if restoreOptions.Import != "" {
|
|
if restoreOptions.All || restoreOptions.Latest {
|
|
return errors.Errorf("Cannot use --import with --all or --latest")
|
|
}
|
|
if argLen > 0 {
|
|
return errors.Errorf("Cannot use --import with positional arguments")
|
|
}
|
|
}
|
|
if (restoreOptions.All || restoreOptions.Latest) && argLen > 0 {
|
|
return errors.Errorf("--all or --latest and containers cannot be used together")
|
|
}
|
|
if argLen < 1 && !restoreOptions.All && !restoreOptions.Latest && restoreOptions.Import == "" {
|
|
return errors.Errorf("you must provide at least one name or id")
|
|
}
|
|
responses, err := registry.ContainerEngine().ContainerRestore(context.Background(), args, restoreOptions)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, r := range responses {
|
|
if r.Err == nil {
|
|
fmt.Println(r.Id)
|
|
} else {
|
|
errs = append(errs, r.Err)
|
|
}
|
|
}
|
|
return errs.PrintErrors()
|
|
}
|