mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-05 07:07:51 +00:00
InfraContainer should go through the same creation process as regular containers. This change was from the cmd level down, involving new container CLI opts and specgen creating functions. What now happens is that both container and pod cli options are populated in cmd and used to create a podSpecgen and a containerSpecgen. The process then goes as follows FillOutSpecGen (infra) -> MapSpec (podOpts -> infraOpts) -> PodCreate -> MakePod -> createPodOptions -> NewPod -> CompleteSpec (infra) -> MakeContainer -> NewContainer -> newContainer -> AddInfra (to pod state) Signed-off-by: cdoern <cdoern@redhat.com>
293 lines
8.7 KiB
Go
293 lines
8.7 KiB
Go
package pods
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"runtime"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/containers/common/pkg/completion"
|
|
"github.com/containers/common/pkg/config"
|
|
"github.com/containers/common/pkg/sysinfo"
|
|
"github.com/containers/podman/v3/cmd/podman/common"
|
|
"github.com/containers/podman/v3/cmd/podman/containers"
|
|
"github.com/containers/podman/v3/cmd/podman/parse"
|
|
"github.com/containers/podman/v3/cmd/podman/registry"
|
|
"github.com/containers/podman/v3/cmd/podman/validate"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/errorhandling"
|
|
"github.com/containers/podman/v3/pkg/specgen"
|
|
"github.com/containers/podman/v3/pkg/specgenutil"
|
|
"github.com/containers/podman/v3/pkg/util"
|
|
"github.com/docker/docker/pkg/parsers"
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
var (
|
|
podCreateDescription = `After creating the pod, the pod ID is printed to stdout.
|
|
|
|
You can then start it at any time with the podman pod start <pod_id> command. The pod will be created with the initial state 'created'.`
|
|
|
|
createCommand = &cobra.Command{
|
|
Use: "create [options]",
|
|
Args: validate.NoArgs,
|
|
Short: "Create a new empty pod",
|
|
Long: podCreateDescription,
|
|
RunE: create,
|
|
ValidArgsFunction: completion.AutocompleteNone,
|
|
}
|
|
)
|
|
|
|
var (
|
|
createOptions entities.PodCreateOptions
|
|
infraOptions entities.ContainerCreateOptions
|
|
labels, labelFile []string
|
|
podIDFile string
|
|
replace bool
|
|
share string
|
|
)
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: createCommand,
|
|
Parent: podCmd,
|
|
})
|
|
flags := createCommand.Flags()
|
|
flags.SetInterspersed(false)
|
|
infraOptions.IsInfra = true
|
|
common.DefineCreateFlags(createCommand, &infraOptions, true)
|
|
common.DefineNetFlags(createCommand)
|
|
|
|
flags.BoolVar(&createOptions.Infra, "infra", true, "Create an infra container associated with the pod to share namespaces with")
|
|
|
|
nameFlagName := "name"
|
|
flags.StringVarP(&createOptions.Name, nameFlagName, "n", "", "Assign a name to the pod")
|
|
_ = createCommand.RegisterFlagCompletionFunc(nameFlagName, completion.AutocompleteNone)
|
|
|
|
infraImageFlagName := "infra-image"
|
|
flags.String(infraImageFlagName, containerConfig.Engine.InfraImage, "The image of the infra container to associate with the pod")
|
|
_ = createCommand.RegisterFlagCompletionFunc(infraImageFlagName, common.AutocompleteImages)
|
|
|
|
podIDFileFlagName := "pod-id-file"
|
|
flags.StringVar(&podIDFile, podIDFileFlagName, "", "Write the pod ID to the file")
|
|
_ = createCommand.RegisterFlagCompletionFunc(podIDFileFlagName, completion.AutocompleteDefault)
|
|
|
|
flags.BoolVar(&replace, "replace", false, "If a pod with the same name exists, replace it")
|
|
|
|
shareFlagName := "share"
|
|
flags.StringVar(&share, shareFlagName, specgen.DefaultKernelNamespaces, "A comma delimited list of kernel namespaces the pod will share")
|
|
_ = createCommand.RegisterFlagCompletionFunc(shareFlagName, common.AutocompletePodShareNamespace)
|
|
|
|
flags.SetNormalizeFunc(aliasNetworkFlag)
|
|
}
|
|
|
|
func aliasNetworkFlag(_ *pflag.FlagSet, name string) pflag.NormalizedName {
|
|
if name == "net" {
|
|
name = "network"
|
|
}
|
|
return pflag.NormalizedName(name)
|
|
}
|
|
|
|
func create(cmd *cobra.Command, args []string) error {
|
|
var (
|
|
err error
|
|
podIDFD *os.File
|
|
imageName string
|
|
rawImageName string
|
|
)
|
|
labelFile = infraOptions.LabelFile
|
|
labels = infraOptions.Label
|
|
createOptions.Labels, err = parse.GetAllLabels(labelFile, labels)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "unable to process labels")
|
|
}
|
|
|
|
imageName = config.DefaultInfraImage
|
|
img := imageName
|
|
if !createOptions.Infra {
|
|
if cmd.Flag("no-hosts").Changed {
|
|
return fmt.Errorf("cannot specify no-hosts without an infra container")
|
|
}
|
|
flags := cmd.Flags()
|
|
createOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
logrus.Debugf("Not creating an infra container")
|
|
createOptions.InfraImage = ""
|
|
if createOptions.InfraName != "" {
|
|
return errors.New("cannot set infra-name without an infra container")
|
|
}
|
|
|
|
if cmd.Flag("share").Changed && share != "none" && share != "" {
|
|
return fmt.Errorf("cannot set share(%s) namespaces without an infra container", cmd.Flag("share").Value)
|
|
}
|
|
createOptions.Share = nil
|
|
} else {
|
|
// reassign certain optios for lbpod api, these need to be populated in spec
|
|
createOptions.InfraConmonPidFile = infraOptions.ConmonPIDFile
|
|
createOptions.InfraName = infraOptions.Name
|
|
createOptions.Hostname = infraOptions.Hostname
|
|
createOptions.Cpus = infraOptions.CPUS
|
|
createOptions.CpusetCpus = infraOptions.CPUSetCPUs
|
|
createOptions.Pid = infraOptions.PID
|
|
flags := cmd.Flags()
|
|
infraOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
infraOptions, err = containers.CreateInit(cmd, infraOptions, true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
createOptions.Net = infraOptions.Net
|
|
createOptions.Share = strings.Split(share, ",")
|
|
if cmd.Flag("infra-command").Changed {
|
|
// Only send content to server side if user changed defaults
|
|
cmdIn, err := cmd.Flags().GetString("infra-command")
|
|
infraOptions.Entrypoint = &cmdIn
|
|
createOptions.InfraCommand = cmdIn
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if cmd.Flag("infra-image").Changed {
|
|
// Only send content to server side if user changed defaults
|
|
img, err = cmd.Flags().GetString("infra-image")
|
|
imageName = img
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
if cmd.Flag("pod-id-file").Changed {
|
|
podIDFD, err = util.OpenExclusiveFile(podIDFile)
|
|
if err != nil && os.IsExist(err) {
|
|
return errors.Errorf("pod id file exists. Ensure another pod is not using it or delete %s", podIDFile)
|
|
}
|
|
if err != nil {
|
|
return errors.Errorf("error opening pod-id-file %s", podIDFile)
|
|
}
|
|
defer errorhandling.CloseQuiet(podIDFD)
|
|
defer errorhandling.SyncQuiet(podIDFD)
|
|
}
|
|
|
|
if len(createOptions.Net.PublishPorts) > 0 {
|
|
if !createOptions.Infra {
|
|
return errors.Errorf("you must have an infra container to publish port bindings to the host")
|
|
}
|
|
}
|
|
|
|
createOptions.CreateCommand = os.Args
|
|
|
|
if replace {
|
|
if err := replacePod(createOptions.Name); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
numCPU := sysinfo.NumCPU()
|
|
if numCPU == 0 {
|
|
numCPU = runtime.NumCPU()
|
|
}
|
|
if createOptions.Cpus > float64(numCPU) {
|
|
createOptions.Cpus = float64(numCPU)
|
|
}
|
|
copy := createOptions.CpusetCpus
|
|
cpuSet := createOptions.Cpus
|
|
if cpuSet == 0 {
|
|
cpuSet = float64(sysinfo.NumCPU())
|
|
}
|
|
ret, err := parsers.ParseUintList(copy)
|
|
copy = ""
|
|
if err != nil {
|
|
errors.Wrapf(err, "could not parse list")
|
|
}
|
|
var vals []int
|
|
for ind, val := range ret {
|
|
if val {
|
|
vals = append(vals, ind)
|
|
}
|
|
}
|
|
sort.Ints(vals)
|
|
for ind, core := range vals {
|
|
if core > int(cpuSet) {
|
|
if copy == "" {
|
|
copy = "0-" + strconv.Itoa(int(cpuSet))
|
|
createOptions.CpusetCpus = copy
|
|
break
|
|
} else {
|
|
createOptions.CpusetCpus = copy
|
|
break
|
|
}
|
|
} else if ind != 0 {
|
|
copy += "," + strconv.Itoa(core)
|
|
} else {
|
|
copy = "" + strconv.Itoa(core)
|
|
}
|
|
}
|
|
podSpec := specgen.NewPodSpecGenerator()
|
|
podSpec, err = entities.ToPodSpecGen(*podSpec, &createOptions)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if createOptions.Infra {
|
|
rawImageName = img
|
|
if !infraOptions.RootFS {
|
|
curr := infraOptions.Quiet
|
|
infraOptions.Quiet = true
|
|
name, err := containers.PullImage(imageName, infraOptions)
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
}
|
|
imageName = name
|
|
infraOptions.Quiet = curr
|
|
}
|
|
podSpec.InfraImage = imageName
|
|
if infraOptions.Entrypoint != nil {
|
|
createOptions.InfraCommand = *infraOptions.Entrypoint
|
|
}
|
|
infraOptions.CPUS = createOptions.Cpus
|
|
infraOptions.CPUSetCPUs = createOptions.CpusetCpus
|
|
infraOptions.PID = createOptions.Pid
|
|
podSpec.InfraContainerSpec = specgen.NewSpecGenerator(imageName, false)
|
|
podSpec.InfraContainerSpec.RawImageName = rawImageName
|
|
podSpec.InfraContainerSpec.NetworkOptions = podSpec.NetworkOptions
|
|
err = specgenutil.FillOutSpecGen(podSpec.InfraContainerSpec, &infraOptions, []string{})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
PodSpec := entities.PodSpec{PodSpecGen: *podSpec}
|
|
response, err := registry.ContainerEngine().PodCreate(context.Background(), PodSpec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(podIDFile) > 0 {
|
|
if err = ioutil.WriteFile(podIDFile, []byte(response.Id), 0644); err != nil {
|
|
return errors.Wrapf(err, "failed to write pod ID to file")
|
|
}
|
|
}
|
|
fmt.Println(response.Id)
|
|
return nil
|
|
}
|
|
|
|
func replacePod(name string) error {
|
|
if len(name) == 0 {
|
|
return errors.New("cannot replace pod without --name being set")
|
|
}
|
|
rmOptions := entities.PodRmOptions{
|
|
Force: true, // stop and remove pod
|
|
Ignore: true, // ignore if pod doesn't exist
|
|
}
|
|
return removePods([]string{name}, rmOptions, false)
|
|
}
|