mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-20 14:47:48 +00:00
ec30a4f7b7
The step summary posted when a CI job fails is useless for the bindings suite: it carries a bare failure count and never the failure itself. Two reasons stack up. github_log_summary.py picks between the ginkgo and bats parsers by looking for "int-" in the file name, but int is not the only ginkgo suite - bindings runs ginkgo as well, so its log is handed to the bats parser, which finds nothing beyond the count in ginkgo's summary line. logformatter decides the layout from the log contents, so do the same here. That alone still leaves the summary empty. Only ginkgo run under -p reports a failure on the line logformatter reads the test status from, and `make testbindings` does not pass -p, so every test in a bindings log heads 'log-passed' and the stack trace div is the sole mark of a failure. Key on that div as well. Not on the class by itself: logformatter gives it to error-level logrus lines too, which passing tests emit, but those are spans. Three more things the script got wrong along the way, all of them kept out of sight by the "|| true" on the workflow step. The workflow passes it a glob but only argv[1] was ever read, so any further log was dropped without a word. A job that produces no html log at all leaves that glob unexpanded, which ended in a traceback. And logformatter reads its input through ':utf8', which validates nothing, so a test that wrote raw bytes leaves behind a log that the summary could not even decode. Signed-off-by: rjgoyln <pt40419@gmail.com> |
||
|---|---|---|
| .. | ||
| ci.sh | ||
| ci_yaml_test.py | ||
| get-local-registry-script | ||
| gha_mac_cleanup.sh | ||
| github_log_summary.py | ||
| github_log_summary_test.py | ||
| lib.sh | ||
| logcollector.sh | ||
| logformatter | ||
| logformatter.t | ||
| make-and-check-size.sh | ||
| pr-removes-fixed-skips | ||
| pr-removes-fixed-skips.t | ||
| pr-should-include-tests | ||
| pr-should-include-tests.t | ||
| runner.sh | ||
| template.lima.yml | ||
| timestamp.awk | ||
| win-lib.ps1 | ||