spiegel_podman/libpod
Paul Holzinger 15b8bb72a8
libpod: restart always reconfigure the netns
Always teardown the network, trying to reuse the netns has caused
a significant amount of bugs in this code here. It also never worked
for containers with user namespaces. So once and for all simplify this
by never reusing the netns. Originally this was done to have a faster
restart of containers but with netavark now we are much faster so it
shouldn't be that noticeable in practice. It also makes more sense to
reconfigure the netns as it is likely that the container exited due
some broken network state in which case reusing would just cause more
harm than good.

The main motivation for this change was the pasta change to use
--dns-forward by default. As the restarted contianer had no idea what
nameserver to use as pasta just kept running.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-03-19 12:21:18 +01:00
..
define Merge pull request #21601 from flobz/feature/docker_v1.44_compat 2024-02-29 18:42:01 +00:00
driver Bump Go module to v5 2024-02-08 09:35:39 -05:00
events properly implement pull-error event status 2024-03-05 10:50:42 +01:00
layers Initial checkin from CRI-O repo 2017-11-01 11:24:59 -04:00
linkmode chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
lock Bump Go module to v5 2024-02-08 09:35:39 -05:00
logs Bump Go module to v5 2024-02-08 09:35:39 -05:00
plugin Bump Go module to v5 2024-02-08 09:35:39 -05:00
shutdown play kube: Add --wait option 2023-02-28 13:45:36 -05:00
boltdb_state.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
boltdb_state_internal.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
common_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
container_api.go logging: new mode -l passthrough-tty 2024-02-28 17:23:59 +01:00
container_commit.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_config.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_copy_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_copy_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_copy_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_exec.go Use persist dir for oom file 2024-02-12 09:13:39 -05:00
container_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_graph.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_graph_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_inspect.go feat: allow compatibility with podman v4 machine 2024-02-28 19:45:03 +01:00
container_inspect_freebsd.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_inspect_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_internal.go libpod: restart always reconfigure the netns 2024-03-19 12:21:18 +01:00
container_internal_common.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
container_internal_freebsd.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
container_internal_linux.go libpod: restart always reconfigure the netns 2024-03-19 12:21:18 +01:00
container_internal_linux_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_internal_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_log.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_log_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_log_unsupported.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_path_resolution.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_path_resolution_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_stat_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_stat_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_stat_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_top_freebsd.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_top_linux.c chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_top_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
container_top_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
container_validate.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
diff.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
doc.go document that using libpod package directly is not supported 2022-03-23 19:05:29 +01:00
events.go libpod/events: remove duplicated Details ID field 2024-02-22 13:37:27 +01:00
healthcheck.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
healthcheck_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
healthcheck_nosystemd_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
healthcheck_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
info.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
info_freebsd.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
info_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
info_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
kube.go Comply to Kubernetes specifications for annotation size. 2024-02-20 14:58:35 -08:00
mounts_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
networking_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
networking_freebsd.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
networking_linux.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
networking_linux_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
networking_machine.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
networking_pasta_linux.go use new c/common pasta2 setup logic to fix dns 2024-03-19 12:09:31 +01:00
networking_slirp4netns.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
oci.go Use persist dir for oom file 2024-02-12 09:13:39 -05:00
oci_conmon.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
oci_conmon_attach_common.go logging: new mode -l passthrough-tty 2024-02-28 17:23:59 +01:00
oci_conmon_attach_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
oci_conmon_attach_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
oci_conmon_common.go logging: new mode -l passthrough-tty 2024-02-28 17:23:59 +01:00
oci_conmon_exec_common.go Use persist dir for oom file 2024-02-12 09:13:39 -05:00
oci_conmon_exec_freebsd.go Cease using deprecated runc userlookup 2024-02-02 11:02:43 -05:00
oci_conmon_exec_linux.go Cease using deprecated runc userlookup 2024-02-02 11:02:43 -05:00
oci_conmon_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
oci_conmon_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
oci_missing.go Use persist dir for oom file 2024-02-12 09:13:39 -05:00
oci_util.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
options.go logging: new mode -l passthrough-tty 2024-02-28 17:23:59 +01:00
pod.go Add volumes-from support using annotation in kube yaml 2024-02-14 07:31:43 -08:00
pod_api.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
pod_internal.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
pod_internal_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
pod_internal_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
pod_status.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
pod_top_freebsd.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
pod_top_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
reset.go Use stop timeout of zero for system reset 2024-03-01 10:51:58 -06:00
rlimit_int64.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
rlimit_uint64.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime.go properly implement pull-error event status 2024-03-05 10:50:42 +01:00
runtime_cstorage.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_ctr.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_ctr_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime_ctr_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime_img.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_migrate_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_migrate_unsupported.go Remove Libpod special-init conditions 2024-01-12 09:19:34 -05:00
runtime_pod.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_pod_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_pod_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime_pod_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_pre_go1.20.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime_renumber.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
runtime_volume.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_volume_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
runtime_worker.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
service.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
sqlite_state.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
sqlite_state_internal.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
state.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
state_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
stats_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
stats_freebsd.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
stats_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
storage.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
util.go fix invalid HTTP header values when hijacking a connection 2024-03-12 23:05:25 +01:00
util_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
util_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
util_linux_test.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
util_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
volume.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
volume_inspect.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
volume_internal.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
volume_internal_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
volume_internal_freebsd.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
volume_internal_linux.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00