mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-19 14:17:48 +00:00
There is no reason to define the same code every time in each file, just use global nodes. This diff should speak for itself. CleanupSecrets()/Volume() no longer call Cleanup() directly, as the global AfterEach node will always call Cleanup() this is no longer necessary. If one AfterEach() node fails it will still run the others. Also always unset the CONTAINERS_CONF env vars. This prevents people from forgetting to unset it. And fix the special CONTAINERS_CONF logic in the system connection tests, we do not want to preserve CONTAINERS_CONF anyway so just remove this logic. Ginkgo orders the BeforeEach and AfterEach nodes. They will be executed from the outer-most defined to inner-most. This means our global BeforeEach is always first. Only then the inner one (in the Describe() function in each file). For AfterEach it is inverted, from the inner to the outer. Also see https://onsi.github.io/ginkgo/#organizing-specs-with-container-nodes Signed-off-by: Paul Holzinger <pholzing@redhat.com>
163 lines
6.2 KiB
Go
163 lines
6.2 KiB
Go
package integration
|
|
|
|
import (
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
. "github.com/containers/podman/v4/test/utils"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
"github.com/syndtr/gocapability/capability"
|
|
)
|
|
|
|
// helper function for confirming that container capabilities are equal
|
|
// to those of the host, but only to the extent of caps we (podman)
|
|
// know about at compile time. That is: the kernel may have more caps
|
|
// available than we are aware of, leading to host=FFF... and ctr=3FF...
|
|
// because the latter is all we request. Accept that.
|
|
func containerCapMatchesHost(ctrCap string, hostCap string) {
|
|
if isRootless() {
|
|
return
|
|
}
|
|
ctrCapN, err := strconv.ParseUint(ctrCap, 16, 64)
|
|
Expect(err).NotTo(HaveOccurred(), "Error parsing %q as hex", ctrCap)
|
|
|
|
hostCapN, err := strconv.ParseUint(hostCap, 16, 64)
|
|
Expect(err).NotTo(HaveOccurred(), "Error parsing %q as hex", hostCap)
|
|
|
|
// host caps can never be zero (except rootless).
|
|
// and host caps must always be a superset (inclusive) of container
|
|
Expect(hostCapN).To(BeNumerically(">", 0), "host cap %q should be nonzero", hostCap)
|
|
Expect(hostCapN).To(BeNumerically(">=", ctrCapN), "host cap %q should never be less than container cap %q", hostCap, ctrCap)
|
|
hostCapMasked := hostCapN & (1<<len(capability.List()) - 1)
|
|
Expect(ctrCapN).To(Equal(hostCapMasked), "container cap %q is not a subset of host cap %q", ctrCap, hostCap)
|
|
}
|
|
|
|
var _ = Describe("Podman privileged container tests", func() {
|
|
|
|
It("podman privileged make sure sys is mounted rw", func() {
|
|
session := podmanTest.Podman([]string{"run", "--privileged", BB, "mount"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(session.OutputToString()).To(ContainSubstring("sysfs (rw,"))
|
|
})
|
|
|
|
It("podman privileged CapEff", func() {
|
|
hostCap := SystemExec("awk", []string{"/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
Expect(hostCap).Should(Exit(0))
|
|
|
|
session := podmanTest.Podman([]string{"run", "--privileged", BB, "awk", "/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
containerCapMatchesHost(session.OutputToString(), hostCap.OutputToString())
|
|
})
|
|
|
|
It("podman cap-add CapEff", func() {
|
|
// Get caps of current process
|
|
hostCap := SystemExec("awk", []string{"/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
Expect(hostCap).Should(Exit(0))
|
|
|
|
session := podmanTest.Podman([]string{"run", "--cap-add", "all", BB, "awk", "/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
containerCapMatchesHost(session.OutputToString(), hostCap.OutputToString())
|
|
})
|
|
|
|
It("podman cap-add CapEff with --user", func() {
|
|
// Get caps of current process
|
|
hostCap := SystemExec("awk", []string{"/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
Expect(hostCap).Should(Exit(0))
|
|
|
|
session := podmanTest.Podman([]string{"run", "--user=bin", "--cap-add", "all", BB, "awk", "/^CapEff/ { print $2 }", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
containerCapMatchesHost(session.OutputToString(), hostCap.OutputToString())
|
|
})
|
|
|
|
It("podman cap-drop CapEff", func() {
|
|
session := podmanTest.Podman([]string{"run", "--cap-drop", "all", BB, "grep", "CapEff", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
capEff := strings.Split(session.OutputToString(), " ")
|
|
Expect("0000000000000000").To(Equal(capEff[1]))
|
|
})
|
|
|
|
It("podman privileged should disable seccomp by default", func() {
|
|
hostSeccomp := SystemExec("grep", []string{"-Ei", "^Seccomp:\\s+0$", "/proc/self/status"})
|
|
Expect(hostSeccomp).Should(Exit(0))
|
|
|
|
session := podmanTest.Podman([]string{"run", "--privileged", ALPINE, "grep", "-Ei", "^Seccomp:\\s+0$", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
})
|
|
|
|
It("podman non-privileged should have very few devices", func() {
|
|
session := podmanTest.Podman([]string{"run", "-t", BB, "ls", "-l", "/dev"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(session.OutputToStringArray()).To(HaveLen(17))
|
|
})
|
|
|
|
It("podman privileged should inherit host devices", func() {
|
|
session := podmanTest.Podman([]string{"run", "--privileged", ALPINE, "ls", "-l", "/dev"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(len(session.OutputToStringArray())).To(BeNumerically(">", 20))
|
|
})
|
|
|
|
It("podman privileged should restart after host devices change", func() {
|
|
containerName := "privileged-restart-test"
|
|
SkipIfRootless("Cannot create devices in /dev in rootless mode")
|
|
Expect(os.MkdirAll("/dev/foodevdir", os.ModePerm)).To(Succeed())
|
|
|
|
mknod := SystemExec("mknod", []string{"/dev/foodevdir/null", "c", "1", "3"})
|
|
mknod.WaitWithDefaultTimeout()
|
|
Expect(mknod).Should(Exit(0))
|
|
|
|
session := podmanTest.Podman([]string{"run", "--name=" + containerName, "--privileged", fedoraMinimal, "ls", "/dev"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
deviceFiles := session.OutputToStringArray()
|
|
|
|
os.RemoveAll("/dev/foodevdir")
|
|
session = podmanTest.Podman([]string{"start", "--attach", containerName})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
deviceFilesAfterRemoval := session.OutputToStringArray()
|
|
Expect(deviceFiles).To(Not(Equal(deviceFilesAfterRemoval)))
|
|
})
|
|
|
|
It("run no-new-privileges test", func() {
|
|
// Check if our kernel is new enough
|
|
k, err := IsKernelNewerThan("4.14")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
if !k {
|
|
Skip("Kernel is not new enough to test this feature")
|
|
}
|
|
|
|
cap := SystemExec("grep", []string{"NoNewPrivs", "/proc/self/status"})
|
|
if cap.ExitCode() != 0 {
|
|
Skip("Can't determine NoNewPrivs")
|
|
}
|
|
|
|
session := podmanTest.Podman([]string{"run", BB, "grep", "NoNewPrivs", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
privs := strings.Split(session.OutputToString(), ":")
|
|
session = podmanTest.Podman([]string{"run", "--security-opt", "no-new-privileges", BB, "grep", "NoNewPrivs", "/proc/self/status"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
noprivs := strings.Split(session.OutputToString(), ":")
|
|
Expect(privs[1]).To(Not(Equal(noprivs[1])))
|
|
})
|
|
|
|
})
|