spiegel_podman/cmd/podman
Paul Holzinger b7b8fedea9 fix empty newline in version output
When podman is build without git commit information it will print a
empty newline instead. This is undesirable and a regression introduced
in commit 7d22cc88ef.

To test build podman with `go build -mod=vendor -o bin/podman ./cmd/podman`
and check the output of bin/podman version with and without this commit.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-03-30 14:03:45 -04:00
..
common Fix handling of tmpfs-mode for tmpfs creation in compat mode 2022-03-30 13:56:41 -04:00
completion bump go module to version 4 2022-01-18 12:47:07 +01:00
containers bump go module to version 4 2022-01-18 12:47:07 +01:00
diff bump go module to version 4 2022-01-18 12:47:07 +01:00
generate Handlers for generate systemd with custom dependencies 2022-01-19 21:46:16 +05:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images podman image scp syntax correction 2022-02-03 15:02:39 -05:00
inspect bump go module to version 4 2022-01-18 12:47:07 +01:00
machine Handle incompatible machines 2022-03-18 17:36:37 -05:00
manifest bump go module to version 4 2022-01-18 12:47:07 +01:00
networks netavark e2e tests 2022-02-11 11:23:24 -05:00
parse import: write stdin to tmp file 2021-07-23 10:21:37 +02:00
play kube: honor --build=false and make --build=true by default 2022-02-23 14:30:25 -05:00
pods Podman pod create --share-parent vs --share=cgroup 2022-02-10 13:49:46 -05:00
registry Revert "Option --url and --connection should imply --remote." 2022-03-01 13:15:03 -06:00
secrets bump go module to version 4 2022-01-18 12:47:07 +01:00
system fix empty newline in version output 2022-03-30 14:03:45 -04:00
utils bump go module to version 4 2022-01-18 12:47:07 +01:00
validate bump go module to version 4 2022-01-18 12:47:07 +01:00
volumes bump go module to version 4 2022-01-18 12:47:07 +01:00
auto-update.go bump go module to version 4 2022-01-18 12:47:07 +01:00
diff.go bump go module to version 4 2022-01-18 12:47:07 +01:00
early_init_linux.go bump go module to version 4 2022-01-18 12:47:07 +01:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-17 20:53:38 +02:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go provide better error on invalid flag 2022-02-23 14:32:05 -05:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
root.go Show correct default values or show none 2022-01-24 13:15:42 -05:00
root_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())