spiegel_podman/cmd/podman
Lokesh Mandvekar ec8e61e60a
Fix podman-remote build output not being displayed
The podman-remote build command was not displaying build output, causing
remotesystem tests to fail when expecting output like "COMMIT", "cache",
"Successfully built", etc.

Root causes:
1. BuildOptions.Out was set to nil when no --logfile was specified,
   causing all build output to be discarded
2. BuildOptions.Err was not set, preventing auxiliary build output
   from being displayed

Changes:
- Set Out and Err to default to os.Stdout and os.Stderr respectively
- Both redirect to logfile when --logfile is specified
- Remove incorrect client-side quiet flag handling (already handled
  by build engine via Quiet option)

This matches the behavior of the non-remote build implementation in
build.go and ensures build output is properly streamed from the server
through the bindings to the client's stdout/stderr.

Fixes test failures in make remotesystem for build-related tests.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2026-01-19 16:38:44 +05:30
..
common [v4.4-rhel] Adjust for common bump 2025-12-17 15:40:01 -05:00
completion build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 2022-10-12 14:54:19 +02:00
containers Fix multiple podman cp issues for podman-remote 2026-01-19 16:38:28 +05:30
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
generate Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
healthcheck Add support for startup healthchecks 2022-11-28 13:30:29 -05:00
images Fix podman-remote build output not being displayed 2026-01-19 16:38:44 +05:30
inspect podman inspect return exit code > 0 on print error 2022-09-13 10:33:14 +02:00
kube kube play: only enforce passthrough in Quadlet 2023-02-20 07:53:56 +00:00
machine [v4.4-rhel] Adjust for common bump 2025-12-17 15:40:01 -05:00
manifest Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml) 2023-01-27 16:46:28 +01:00
networks network: add support for podman network update and --network-dns-server 2023-01-12 20:19:14 +05:30
parse Use containers/storage/pkg/regexp in place of regexp 2023-01-12 18:33:38 -05:00
pods Unify --noheading and -n to be consistent on all commands 2022-12-19 13:18:43 -05:00
registry bump golangci-lint to v1.50.1 2022-12-15 13:39:56 +01:00
secrets Unify --noheading and -n to be consistent on all commands 2022-12-19 13:18:43 -05:00
system system df: improve json output code 2023-01-03 18:12:06 +01:00
utils Add build-tagged splits for libimage-dependent code 2025-12-18 10:27:49 -05:00
validate bump golangci-lint to v1.49.0 2022-10-17 09:19:41 +02:00
volumes make example volume import, not import volume 2023-01-24 14:29:45 -08:00
auto-update.go podman auto-update: use report.Formatter over Template 2022-09-13 10:33:12 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go Fix stutters 2022-09-10 07:52:00 -04:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go Add "podman kube play" cmd 2022-07-13 15:27:03 +01:00
main_experimental.go Introduce podman machine os commands 2022-11-28 11:50:01 -05:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
root.go [v4.4-rhel] Adjust for common bump 2025-12-17 15:40:01 -05:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_common.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00
syslog_unsupported.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())