mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-14 11:37:53 +00:00
6864a5547a
...plus a few others. And fixes to actual parsing. If a command's usage message includes '...' in the argument list, assume it can take unlimited arguments. Nothing we can check. For all others, though, the ALL-CAPS part on the right-hand side of the usage message will define an upper bound on the number of arguments accepted by the command. So in our 'podman --help' test, generate N+1 args and run that command. We expect a 125 exit status and a suitably helpful error message. Not all podman commands or subcommands were checking, so I fixed that. And, fixed some broken usage messages (all-caps FLAGS, and '[flags]' at the end of 'ARGS'). Add new checks to the help test to prevent those in the future. Plus a little refactoring/cleanup where necessary. Signed-off-by: Ed Santiago <santiago@redhat.com>
35 lines
1.1 KiB
Go
35 lines
1.1 KiB
Go
package validate
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
// NoArgs returns an error if any args are included.
|
|
func NoArgs(cmd *cobra.Command, args []string) error {
|
|
if len(args) > 0 {
|
|
return fmt.Errorf("`%s` takes no arguments", cmd.CommandPath())
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SubCommandExists returns an error if no sub command is provided
|
|
func SubCommandExists(cmd *cobra.Command, args []string) error {
|
|
if len(args) > 0 {
|
|
return errors.Errorf("unrecognized command `%[1]s %[2]s`\nTry '%[1]s --help' for more information.", cmd.CommandPath(), args[0])
|
|
}
|
|
return errors.Errorf("missing command '%[1]s COMMAND'\nTry '%[1]s --help' for more information.", cmd.CommandPath())
|
|
}
|
|
|
|
// IDOrLatestArgs used to validate a nameOrId was provided or the "--latest" flag
|
|
func IDOrLatestArgs(cmd *cobra.Command, args []string) error {
|
|
if len(args) > 1 {
|
|
return fmt.Errorf("`%s` accepts at most one argument", cmd.CommandPath())
|
|
}
|
|
if len(args) == 0 && !cmd.Flag("latest").Changed {
|
|
return fmt.Errorf("`%s` requires a name, id, or the \"--latest\" flag", cmd.CommandPath())
|
|
}
|
|
return nil
|
|
}
|