spiegel_podman/cmd/podman
Matthew Heon 7ac3d906b5 Rework port parsing to support --expose and -P
As part of this, make a major change to the type we use to
represent port mappings in SpecGen (from using existing OCICNI
structs to using our own custom one). This struct has the
advantage of supporting ranges, massively reducing traffic over
the wire for Podman commands using them (for example, the
`podman run -p 5000-6000` command will now send only one struct
instead of 1000). This struct also allows us to easily validate
which ports are in use, and which are not, which is necessary for
--expose.

Once we have parsed the ports from the new struct, we can produce
an accurate map including all currently requested ports, and use
that to determine what ports need to be exposed (some requested
exposed ports may already be included in a mapping from --publish
and will be ignored) and what open ports on the host we can map
them to.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-05-04 20:57:27 -04:00
..
common Rework port parsing to support --expose and -P 2020-05-04 20:57:27 -04:00
containers Merge pull request #6060 from sujil02/systemprune-v2 2020-05-01 21:08:50 +02:00
generate V2 enable ps tests 2020-04-29 15:51:37 -07:00
healthcheck V2 enable ps tests 2020-04-29 15:51:37 -07:00
images Merge pull request #6051 from rhatdan/containers.conf 2020-05-04 11:08:43 +02:00
inspect enable inspect tests 2020-04-29 07:25:31 +02:00
manifest V2 enable ps tests 2020-04-29 15:51:37 -07:00
networks v2networking enable commands 2020-04-30 14:53:54 -05:00
parse V2 enable ps tests 2020-04-29 15:51:37 -07:00
pods And system prune feature for v2. 2020-05-01 13:57:16 -04:00
registry V2 enable ps tests 2020-04-29 15:51:37 -07:00
report Provide a json variable pointing to a configured json API 2020-04-21 07:56:10 -07:00
system And system prune feature for v2. 2020-05-01 13:57:16 -04:00
utils And system prune feature for v2. 2020-05-01 13:57:16 -04:00
validate V2 enable ps tests 2020-04-29 15:51:37 -07:00
volumes And system prune feature for v2. 2020-05-01 13:57:16 -04:00
build.go podmanV2: implement build 2020-04-17 10:26:50 +02:00
diff.go V2 enable ps tests 2020-04-29 15:51:37 -07:00
inspect.go enable inspect tests 2020-04-29 07:25:31 +02:00
login.go check --get-login when login 2020-05-01 11:27:22 -04:00
logout.go System tests: help messages: check required-arg 2020-04-30 14:55:10 -05:00
main.go v2networking enable commands 2020-04-30 14:53:54 -05:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
root.go V2 enable ps tests 2020-04-29 15:51:37 -07:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())