spiegel_podman/cmd/podman
Nalin Dahyabhai 81068edf81 Accept a config blob alongside the "changes" slice when committing
When committing containers to create new images, accept a container
config blob being passed in the body of the API request by adding a
Config field to our API structures.  Populate it from the body of
requests that we receive, and use its contents as the body of requests
that we make.

Make the libpod commit endpoint split changes values at newlines, just
like the compat endpoint does.

Pass both the config blob and the "changes" slice to buildah's Commit()
API, so that it can handle cases where they overlap or conflict.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2024-02-07 20:23:42 +00:00
..
common farm build: push built images to registry 2024-01-22 09:56:34 -05:00
completion build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 2022-10-12 14:54:19 +02:00
containers Accept a config blob alongside the "changes" slice when committing 2024-02-07 20:23:42 +00:00
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
farm farm build: push built images to registry 2024-01-22 09:56:34 -05:00
generate Deprecate podman generate systemd 2023-08-03 06:58:53 -04:00
healthcheck man pages and command help: clean up descriptions 2023-05-28 18:57:43 +02:00
images Podman push --help should reveal default compression 2023-11-04 07:33:53 -05:00
inspect Add bash-completion for podman inspect 2023-07-18 14:31:50 +01:00
kube [v4.8] podman kube play: fix broken annotation parsing 2024-01-12 16:33:58 -05:00
machine vmtypes names cannot be used as machine names 2023-11-17 12:24:21 -06:00
manifest container.conf: support attributed string slices 2023-10-27 12:44:33 +02:00
networks Add support for passing container stop timeout as -1 (infinite) 2023-08-04 08:36:45 -04:00
parse Add support for host-gateway 2023-08-07 21:38:10 +02:00
pods Merge pull request #19888 from giuseppe/fix-pod-lifecycle 2023-09-10 20:36:21 -04:00
registry Remove Libpod special-init conditions 2024-01-15 12:14:17 -05:00
secrets document available secret drivers 2023-08-16 16:23:39 +02:00
system Remove Libpod special-init conditions 2024-01-15 12:14:17 -05:00
utils Fix typos. Improve language. 2023-02-09 21:56:27 +01:00
validate source code comments and docs: fix typos, language, Markdown layout 2023-05-22 07:52:16 +02:00
volumes Add support for passing container stop timeout as -1 (infinite) 2023-08-04 08:36:45 -04:00
auto-update.go Make sure users changes --authfile before checking 2023-07-27 12:06:25 -04:00
client.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
client_supported.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
client_unsupported.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
compose.go Add API forwarding support for HyperV 2024-01-08 16:26:27 -05:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_darwin.go set RLIMIT_NOFILE soft limit to match the hard limit on mac 2023-11-10 15:35:57 -06:00
early_init_linux.go Fix stutters 2022-09-10 07:52:00 -04:00
early_init_unsupported.go set RLIMIT_NOFILE soft limit to match the hard limit on mac 2023-11-10 15:35:57 -06:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go Add support for --compat-auth-file in login/logout 2023-11-17 16:44:06 +01:00
logout.go Add support for --compat-auth-file in login/logout 2023-11-17 16:44:06 +01:00
main.go Podmansh: use podmansh_timeout 2023-09-12 09:18:24 -04:00
README.md fix: typos in links, path and code example 2023-09-27 20:44:23 -03:00
root.go Merge pull request #20369 from cgiradkar/Issue-16759-docs 2023-10-30 10:22:00 +00:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_common.go pass --syslog to the cleanup process 2023-09-20 15:37:07 +02:00
syslog_unsupported.go pass --syslog to the cleanup process 2023-09-20 15:37:07 +02:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podman/manifest

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/manifest.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podman/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifest"

Adding a new sub command podman manifest list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/inspect.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())