There is a problem where our tail code does not handles correctly partial log lines. This makes podman logs --tail output possibly incorrect lines when k8s-file is used. This manifests as flake in CI because partial lines are only sometimes written, basically always when the output is flushed before writing a newline. For our code we must not count partial lines which was already done but the important thing we must keep reading backwards until the next full (F) line. This is because all partial (P) lines still must be added to the full line. See the added tests for details on how the log file looks like. While fixing this, I rework the tail logic a bit, there is absolutely no reason to read the lines in a separate goroutine just to pass the lines back via channel. We can do this in the same routine. The logic is very simple, read the lines backwards, append lines to result and then at the end invert the result slice as tail must return the lines in the correct order. This more efficient then having to allocate two different slices or to prepend the line as this would require a new allocation for each line. Lastly the readFromLogFile() function wrote the lines back to the log line channel in the same routine as the log lines we read, this was bad and causes a deadlock when the returned lines are bigger than the channel size. There is no reason to allocate a big channel size we can just write the log lines in a different goroutine, in this case the main routine were read the logs anyway. A new system test and unit tests have been added to check corner cases. Fixes #19545 Signed-off-by: Paul Holzinger <pholzing@redhat.com> |
||
|---|---|---|
| .. | ||
| 000-TEMPLATE | ||
| 001-basic.bats | ||
| 005-info.bats | ||
| 010-images.bats | ||
| 011-image.bats | ||
| 012-manifest.bats | ||
| 015-help.bats | ||
| 020-tag.bats | ||
| 030-run.bats | ||
| 032-sig-proxy.bats | ||
| 035-logs.bats | ||
| 037-runlabel.bats | ||
| 040-ps.bats | ||
| 045-start.bats | ||
| 050-stop.bats | ||
| 055-rm.bats | ||
| 060-mount.bats | ||
| 065-cp.bats | ||
| 070-build.bats | ||
| 075-exec.bats | ||
| 080-pause.bats | ||
| 090-events.bats | ||
| 110-history.bats | ||
| 120-load.bats | ||
| 125-import.bats | ||
| 130-kill.bats | ||
| 140-diff.bats | ||
| 150-login.bats | ||
| 160-volumes.bats | ||
| 170-run-userns.bats | ||
| 180-blkio.bats | ||
| 190-run-ipcns.bats | ||
| 195-run-namespaces.bats | ||
| 200-pod.bats | ||
| 220-healthcheck.bats | ||
| 250-systemd.bats | ||
| 251-system-service.bats | ||
| 252-quadlet.bats | ||
| 255-auto-update.bats | ||
| 260-sdnotify.bats | ||
| 270-socket-activation.bats | ||
| 271-tcp-cors-server.bats | ||
| 272-system-connection.bats | ||
| 280-update.bats | ||
| 300-cli-parsing.bats | ||
| 320-system-df.bats | ||
| 330-corrupt-images.bats | ||
| 400-unprivileged-access.bats | ||
| 410-selinux.bats | ||
| 420-cgroups.bats | ||
| 450-interactive.bats | ||
| 500-networking.bats | ||
| 505-networking-pasta.bats | ||
| 520-checkpoint.bats | ||
| 550-pause-process.bats | ||
| 600-completion.bats | ||
| 610-format.bats | ||
| 620-option-conflicts.bats | ||
| 700-play.bats | ||
| 710-kube.bats | ||
| 750-trust.bats | ||
| 800-config.bats | ||
| 850-compose.bats | ||
| 900-ssh.bats | ||
| 950-preexec-hooks.bats | ||
| build-systemd-image | ||
| build-testimage | ||
| helpers.bash | ||
| helpers.network.bash | ||
| helpers.registry.bash | ||
| helpers.sig-proxy.bash | ||
| helpers.systemd.bash | ||
| helpers.t | ||
| README.md | ||
| setup_suite.bash | ||
| TODO.md | ||
Quick overview of podman system tests. The idea is to use BATS, but with a framework for making it easy to add new tests and to debug failures.
Quick Start
Look at 030-run.bats for a simple but packed example. This introduces the basic set of helper functions:
-
setup(implicit) - resets container storage so there's one and only one (standard) image, and no running containers. -
parse_table- you can define tables of inputs and expected results, then read those in awhileloop. This makes it easy to add new tests. Because bash is not a programming language, the caller ofparse_tablesometimes needs to massage the returned values;015-run.batsoffers examples of how to deal with the more typical such issues. -
run_podman- runs command defined in$PODMAN(default: 'podman' but could also be './bin/podman' or 'podman-remote'), with a timeout. Checks its exit status. -
is- compare actual vs expected output. Emits a useful diagnostic on failure. -
die- output a properly-formatted message to stderr, and fail test -
skip_if_rootless- if rootless, skip this test with a helpful message. -
skip_if_remote- like the above, but skip if testingpodman-remote -
random_string- returns a pseudorandom alphanumeric string
Test files are of the form NNN-name.bats where NNN is a three-digit
number. Please preserve this convention, it simplifies viewing the
directory and understanding test order. In particular, 00x tests
should be reserved for a first-pass fail-fast subset of tests:
bats test/system/00*.bats || exit 1
bats test/system
...the goal being to provide quick feedback on catastrophic failures without having to wait for the entire test suite.
Running tests
To run the tests locally in your sandbox, you can use one of these methods:
- make;PODMAN=./bin/podman bats ./test/system/070-build.bats # runs just the specified test
- make;PODMAN=./bin/podman bats ./test/system # runs all
- make;PODMAN=./bin/podman NETWORK_BACKEND=netavark bats ./test/system # Assert & enable netavark testing
To test as root:
- $ PODMAN=./bin/podman sudo --preserve-env=PODMAN bats test/system
Analyzing test failures
The top priority for this scheme is to make it easy to diagnose
what went wrong. To that end, podman_run always logs all invoked
commands, their output and exit codes. In a normal run you will never
see this, but BATS will display it on failure. The goal here is to
give you everything you need to diagnose without having to rerun tests.
The is comparison function is designed to emit useful diagnostics,
in particular, the actual and expected strings. Please do not use
the horrible BATS standard of [ x = y ]; that's nearly useless
for tracking down failures.
If the above are not enough to help you track down a failure:
Debugging tests
Some functions have dprint statements. To see the output of these,
set PODMAN_TEST_DEBUG="funcname" where funcname is the name of
the function or perhaps just a substring.
Requirements
- bats
- jq
- skopeo
- nmap-ncat
- httpd-tools
- openssl
- socat
- buildah
- gnupg
Further Details
TBD. For now, look in helpers.bash; each helper function
has (what are intended to be) helpful header comments. For even more
examples, see and/or run helpers.t; that's a regression test
and provides a thorough set of examples of how the helpers work.