mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-10-14 18:07:43 +00:00
768ad8653a
One of the problems with the Events() API was that you had to call it in
a new goroutine. This meant the the error returned by it had to be read
back via a second channel. This cuased other bugs in the past but here
the biggest problem is that basic errors such as invalid since/until
options were not directly returned to the caller.
It meant in the API we were not able to write http code 200 quickly
because we always waited for the first event or error from the
channels. This in turn made some clients not happy as they assume the
server hangs on time out if no such events are generated.
To fix this we resturcture the entire event flow. First we spawn the
goroutine inside the eventer Read() function so not all the callers have
to. Then we can return the basic error quickly without the goroutine.
The caller then checks the error like any normal function and the API
can use this one to decide which status code to return.
Second we now return errors/event in one channel then the callers can
decide to ignore or log them which makes it a bit more clear.
Fixes
|
||
|---|---|---|
| .. | ||
| reports | ||
| types | ||
| apply.go | ||
| auto-update.go | ||
| container_ps.go | ||
| containers.go | ||
| engine.go | ||
| engine_container.go | ||
| engine_image.go | ||
| events.go | ||
| filters.go | ||
| generate.go | ||
| healthcheck.go | ||
| images.go | ||
| machine.go | ||
| manifest.go | ||
| network.go | ||
| play.go | ||
| pods.go | ||
| scp.go | ||
| secrets.go | ||
| set.go | ||
| system.go | ||
| types.go | ||
| volumes.go | ||