mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-15 12:07:53 +00:00
6b64861922
Backports #17755 from @adrianreber to fix an append issue. Will be used for a ZeroDay delivery to RHEL 8.8/9.2. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2177611 Original commit message: The code was not using append() to add items to a slice. Accessing non allocated elements of the slice failed with: ``` $ podman container restore -l panic: runtime error: index out of range [0] with length 0 goroutine 1 [running]: github.com/containers/podman/v4/pkg/domain/infra/abi.(*ContainerEngine).ContainerRestore(0xc00051a8b8, {0x1dbced0, 0xc0000440d0}, {0x2a31b30, 0x0, 0x0}, {0x0, 0x0, 0x0, 0x0, ...}) /share/go/src/github.com/containers/podman/pkg/domain/infra/abi/containers.go:676 +0x39c github.com/containers/podman/v4/cmd/podman/containers.restore(0x28fb6c0?, {0xc0002c9080, 0x0, 0x1?}) /share/go/src/github.com/containers/podman/cmd/podman/containers/restore.go:171 +0x4ef github.com/spf13/cobra.(*Command).execute(0x28fb6c0, {0xc0000400b0, 0x1, 0x1}) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:916 +0x862 github.com/spf13/cobra.(*Command).ExecuteC(0x291ab00) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:1044 +0x3bd github.com/spf13/cobra.(*Command).Execute(...) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:968 github.com/spf13/cobra.(*Command).ExecuteContext(...) /share/go/src/github.com/containers/podman/vendor/github.com/spf13/cobra/command.go:961 main.Execute() /share/go/src/github.com/containers/podman/cmd/podman/root.go:107 +0xcc main.main() /share/go/src/github.com/containers/podman/cmd/podman/main.go:41 +0x7c ``` [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com> |
||
|---|---|---|
| .. | ||
| annotations | ||
| api | ||
| auth | ||
| autoupdate | ||
| bindings | ||
| channel | ||
| checkpoint | ||
| copy | ||
| criu | ||
| ctime | ||
| domain | ||
| env | ||
| errorhandling | ||
| inspect | ||
| k8s.io | ||
| lookup | ||
| machine | ||
| namespaces | ||
| parallel | ||
| ps | ||
| rctl | ||
| rootless | ||
| rootlessport | ||
| seccomp | ||
| selinux | ||
| servicereaper | ||
| signal | ||
| specgen | ||
| specgenutil | ||
| systemd | ||
| terminal | ||
| timetype | ||
| trust | ||
| util | ||