mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-07 17:36:22 +00:00
8f6a0243f4
First, make podman diff accept optionally a second argument. This allows the user to specify a second image/container to compare the first with. If it is not set the parent layer will be used as before. Second, podman container diff should only use containers and podman image diff should only use images. Previously, podman container diff would use the image when both an image and container with this name exists. To make this work two new parameters have been added to the api. If they are not used the previous behaviour is used. The same applies to the bindings. Fixes #10649 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
55 lines
1.9 KiB
Go
55 lines
1.9 KiB
Go
package containers
|
|
|
|
import (
|
|
"github.com/containers/podman/v3/cmd/podman/common"
|
|
"github.com/containers/podman/v3/cmd/podman/diff"
|
|
"github.com/containers/podman/v3/cmd/podman/registry"
|
|
"github.com/containers/podman/v3/cmd/podman/validate"
|
|
"github.com/containers/podman/v3/libpod/define"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
var (
|
|
// podman container _diff_
|
|
diffCmd = &cobra.Command{
|
|
Use: "diff [options] CONTAINER [CONTAINER]",
|
|
Args: diff.ValidateContainerDiffArgs,
|
|
Short: "Inspect changes to the container's file systems",
|
|
Long: `Displays changes to the container filesystem's'. The container will be compared to its parent layer or the second argument when given.`,
|
|
RunE: diffRun,
|
|
ValidArgsFunction: common.AutocompleteContainers,
|
|
Example: `podman container diff myCtr
|
|
podman container diff -l --format json myCtr`,
|
|
}
|
|
diffOpts *entities.DiffOptions
|
|
)
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: diffCmd,
|
|
Parent: containerCmd,
|
|
})
|
|
|
|
diffOpts = &entities.DiffOptions{}
|
|
flags := diffCmd.Flags()
|
|
|
|
// FIXME: Why does this exists? It is not used anywhere.
|
|
flags.BoolVar(&diffOpts.Archive, "archive", true, "Save the diff as a tar archive")
|
|
_ = flags.MarkHidden("archive")
|
|
|
|
formatFlagName := "format"
|
|
flags.StringVar(&diffOpts.Format, formatFlagName, "", "Change the output format (json)")
|
|
_ = diffCmd.RegisterFlagCompletionFunc(formatFlagName, common.AutocompleteFormat(nil))
|
|
|
|
validate.AddLatestFlag(diffCmd, &diffOpts.Latest)
|
|
}
|
|
|
|
func diffRun(cmd *cobra.Command, args []string) error {
|
|
if len(args) == 0 && !diffOpts.Latest {
|
|
return errors.New("container must be specified: podman container diff [options [...]] ID-NAME")
|
|
}
|
|
diffOpts.Type = define.DiffContainer
|
|
return diff.Diff(cmd, args, *diffOpts)
|
|
}
|