spiegel_podman/cmd/podman
Jhon Honce b64d29bdf2 Remove help/usage from --remote pre-check
--remote pre-check was providing usage context, which was also being
provided by the root podman command.

Fixes #7273

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-08-30 15:39:01 +02:00
..
common Ensure DefaultEnvVariables is used in Specgen 2020-08-20 12:16:53 -04:00
containers Merge pull request #7363 from mheon/lets_try_this_again 2020-08-21 12:58:55 +02:00
generate Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
healthcheck Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
images Default .Repository and .Tag values to <none> 2020-08-20 12:16:53 -04:00
inspect Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
manifest Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
networks replace the html/template package with text/template 2020-07-31 11:37:22 -04:00
parse version/info: format: allow more json variants 2020-07-22 14:42:53 -04:00
play Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
pods Fix container and pod create commands for remote create 2020-07-22 14:39:41 -04:00
registry Remove help/usage from --remote pre-check 2020-08-30 15:39:01 +02:00
report move go module to v2 2020-07-06 15:52:17 +02:00
system podman-remote fixes for msi and client 2020-08-25 15:20:27 -05:00
utils move go module to v2 2020-07-06 15:52:17 +02:00
validate Fix imports (podman -> libpod for v2.0 branch) 2020-08-20 13:21:17 -04:00
volumes replace the html/template package with text/template 2020-07-31 11:37:22 -04:00
auto-update.go auto-update: clarify systemd-unit requirements 2020-07-06 13:08:56 -04:00
diff.go Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
early_init_linux.go Add support for --connection 2020-08-20 12:42:28 -04:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-22 14:05:20 -04:00
inspect.go Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
login.go move go module to v2 2020-07-06 15:52:17 +02:00
logout.go move go module to v2 2020-07-06 15:52:17 +02:00
main.go Merge pull request #7363 from mheon/lets_try_this_again 2020-08-21 12:58:55 +02:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
root.go Add support for --connection 2020-08-20 12:42:28 -04:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())